You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:13:03 UTC

[GitHub] [pulsar-manager] tbsj opened a new pull request #350: Fix README

tbsj opened a new pull request #350:
URL: https://github.com/apache/pulsar-manager/pull/350


   ### Motivation
   
   In README, the bash example for creating a super-user is incorrect: It encloses the `$CSRF_TOKEN` variable in single quotes, which do not interpolate variables. Double quotes must be used instead. Also, this code block has an incorrect language of `$xslt`.
   
   Additionally, in several cases in README, missing/incorrect indentation has caused code block delimiters (triple backquotes) to literally appear in the displayed code.
   
   ### Modifications
   
   Fixed the issues mentioned above.
   
   Also, added a bullet point before `backend-service` to be consistent with an earlier example (`SPRING_CONFIGURATION_FILE`).
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the `./gradlew build` checks.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-manager] tuteng merged pull request #350: Fix README

Posted by GitBox <gi...@apache.org>.
tuteng merged pull request #350:
URL: https://github.com/apache/pulsar-manager/pull/350


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org