[jira] [Commented] (FELIX-3458) Resolver should populate results with wires to self

["Thomas Watson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-3458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272555#comment-13272555 ] 

Thomas Watson commented on FELIX-3458:
--------------------------------------

The patch looks good.  Richard, as you may recall we had a discussion around require-bundle.  At one point during the R4 spec process we had debated around allowing a bundle to require itself.  I thought that may have made it into the specification, but I do not see it so I think it is safe to exclude all osgi.wiring.* namespaces in the check like you are doing.

+1

                
> Resolver should populate results with wires to self
> ---------------------------------------------------
>
>                 Key: FELIX-3458
>                 URL: https://issues.apache.org/jira/browse/FELIX-3458
>             Project: Felix
>          Issue Type: Bug
>          Components: Resolver
>         Environment: All
>            Reporter: Thomas Watson
>            Priority: Minor
>         Attachments: FELIX-3458.txt
>
>
> Except for the osgi.wiring.* namespaces, I think all other namespaces should include results where the Wire has the same provider and requirer.  Currently org.apache.felix.resolver.ResolverImpl.populateWireMap() has a check omits the wire from the result if a resource requriement gets wired to its own capability.
> This has to be done for osgi.wiring.package namespace because that is a case where the import got dropped in favor of the export.  But for other namespaces I am not sure that is a valid assumption.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira