You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/05 15:28:37 UTC
[GitHub] [doris] adonis0147 commented on pull request #15661: [fix](compile) compile failed in Mac with clang14
adonis0147 commented on PR #15661:
URL: https://github.com/apache/doris/pull/15661#issuecomment-1372365663
> Describe your changes.
>
> 1. unused-but-set-variable error while compile vectorscan
> doris/thirdparty/src/vectorscan-vectorscan-5.4.7/src/nfa/mcclellancompile.cpp:1485:13: > error: variable 'total_daddy' set but not used [-Werror,-Wunused-but-set-variable]
> u16 total_daddy = 0;
> 2. we should compile gflags with Release mode, to output libgflags.a instead of libgflags_debug.a
The second change is ok. But I don't think it is good to resolve the first issue by adding a patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org