You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/06/04 08:36:44 UTC
Review Request 67431: Removed unused libprocess test tools.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67431/
-----------------------------------------------------------
Review request for mesos, Jan Schlicht and Till Toenshoff.
Repository: mesos
Description
-------
Removed unused libprocess test tools.
Diffs
-----
3rdparty/libprocess/src/test-master.cpp 5026af32c6d72d3e031ebf265680ab7bbf937435
3rdparty/libprocess/src/test-slave.cpp 4516bdca66de5889c3163ff7d6890a9806dc4322
Diff: https://reviews.apache.org/r/67431/diff/1/
Testing
-------
`make check`
Used `grep` to confimr that the files are unused.
Thanks,
Benjamin Bannier
Re: Review Request 67431: Removed unused libprocess test tools.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67431/#review204245
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On June 4, 2018, 8:36 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67431/
> -----------------------------------------------------------
>
> (Updated June 4, 2018, 8:36 a.m.)
>
>
> Review request for mesos, Jan Schlicht and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unused libprocess test tools.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/test-master.cpp 5026af32c6d72d3e031ebf265680ab7bbf937435
> 3rdparty/libprocess/src/test-slave.cpp 4516bdca66de5889c3163ff7d6890a9806dc4322
>
>
> Diff: https://reviews.apache.org/r/67431/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> Used `grep` to confimr that the files are unused.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67431: Removed unused libprocess test tools.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67431/#review204249
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67431]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 4, 2018, 8:36 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67431/
> -----------------------------------------------------------
>
> (Updated June 4, 2018, 8:36 a.m.)
>
>
> Review request for mesos, Jan Schlicht and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unused libprocess test tools.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/test-master.cpp 5026af32c6d72d3e031ebf265680ab7bbf937435
> 3rdparty/libprocess/src/test-slave.cpp 4516bdca66de5889c3163ff7d6890a9806dc4322
>
>
> Diff: https://reviews.apache.org/r/67431/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> Used `grep` to confimr that the files are unused.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67431: Removed unused libprocess test tools.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67431/#review204247
-----------------------------------------------------------
PASS: Mesos patch 67431 was successfully built and tested.
Reviews applied: `['67431']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67431
- Mesos Reviewbot Windows
On June 4, 2018, 8:36 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67431/
> -----------------------------------------------------------
>
> (Updated June 4, 2018, 8:36 a.m.)
>
>
> Review request for mesos, Jan Schlicht and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unused libprocess test tools.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/test-master.cpp 5026af32c6d72d3e031ebf265680ab7bbf937435
> 3rdparty/libprocess/src/test-slave.cpp 4516bdca66de5889c3163ff7d6890a9806dc4322
>
>
> Diff: https://reviews.apache.org/r/67431/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> Used `grep` to confimr that the files are unused.
>
>
> Thanks,
>
> Benjamin Bannier
>
>