You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/08 09:39:15 UTC
[GitHub] [arrow] sanjibansg opened a new pull request #12104: ARROW-15269: [C++][Docs] Clarify that not all compute functions are invocable via CallFunction
sanjibansg opened a new pull request #12104:
URL: https://github.com/apache/arrow/pull/12104
This PR updates the documentation for Compute Functions to clarify that stateful compute functions like `Grouped Aggregations` are not invocable via `CallFunction`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sanjibansg commented on a change in pull request #12104: ARROW-15269: [C++][Docs] Clarify that not all compute functions are invocable via CallFunction
Posted by GitBox <gi...@apache.org>.
sanjibansg commented on a change in pull request #12104:
URL: https://github.com/apache/arrow/pull/12104#discussion_r781968947
##########
File path: docs/source/cpp/compute.rst
##########
@@ -98,6 +98,8 @@ exact semantics of the function::
min_value = min_max.scalar_as<arrow::StructScalar>().value[0];
max_value = min_max.scalar_as<arrow::StructScalar>().value[1];
+However, stateful compute functions like `Grouped Aggregations <#grouped-aggregations-group-by>`_ are not invocable via ``CallFunction``
+
Review comment:
@lidavidm made the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12104: ARROW-15269: [C++][Docs] Clarify that not all compute functions are invocable via CallFunction
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12104:
URL: https://github.com/apache/arrow/pull/12104#discussion_r781594316
##########
File path: docs/source/cpp/compute.rst
##########
@@ -98,6 +98,8 @@ exact semantics of the function::
min_value = min_max.scalar_as<arrow::StructScalar>().value[0];
max_value = min_max.scalar_as<arrow::StructScalar>().value[1];
+However, stateful compute functions like `Grouped Aggregations <#grouped-aggregations-group-by>`_ are not invocable via ``CallFunction``
+
Review comment:
A few things:
- I think it's only grouped aggregations that cannot be invoked this way, so can we just state that directly?
- We should use the proper reST syntax for linking to a section.
- Can we break the line to be roughly consistent with the rest of the file?
- Just a small typo: there's no period at the end of the sentence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12104: ARROW-15269: [C++][Docs] Clarify that not all compute functions are invocable via CallFunction
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12104:
URL: https://github.com/apache/arrow/pull/12104#issuecomment-1009973329
Benchmark runs are scheduled for baseline = d88e23273fd4eb7945a5fb94cfdb6315f412ea83 and contender = 7a0141a8cc867e5b406ed97e5decc227923eb3f5. 7a0141a8cc867e5b406ed97e5decc227923eb3f5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1370983ba5d74b9eb2bf54946eaf8ea3...424d64b6b5e34533bc7f1c63332e9d3c/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7d4d0afb8ee44100b056610addf095a9...697f12ce4d4f48a5a2b79bb42c7fbfb4/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ce70628f4cec48c5ac08e06449f85e89...0bd1e5b6de5c4a08b2109f8f98951dfd/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12104: ARROW-15269: [C++][Docs] Clarify that not all compute functions are invocable via CallFunction
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12104:
URL: https://github.com/apache/arrow/pull/12104#issuecomment-1009973329
Benchmark runs are scheduled for baseline = d88e23273fd4eb7945a5fb94cfdb6315f412ea83 and contender = 7a0141a8cc867e5b406ed97e5decc227923eb3f5. 7a0141a8cc867e5b406ed97e5decc227923eb3f5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1370983ba5d74b9eb2bf54946eaf8ea3...424d64b6b5e34533bc7f1c63332e9d3c/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7d4d0afb8ee44100b056610addf095a9...697f12ce4d4f48a5a2b79bb42c7fbfb4/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ce70628f4cec48c5ac08e06449f85e89...0bd1e5b6de5c4a08b2109f8f98951dfd/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12104: ARROW-15269: [C++][Docs] Clarify that not all compute functions are invocable via CallFunction
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12104:
URL: https://github.com/apache/arrow/pull/12104#issuecomment-1009973329
Benchmark runs are scheduled for baseline = d88e23273fd4eb7945a5fb94cfdb6315f412ea83 and contender = 7a0141a8cc867e5b406ed97e5decc227923eb3f5. 7a0141a8cc867e5b406ed97e5decc227923eb3f5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1370983ba5d74b9eb2bf54946eaf8ea3...424d64b6b5e34533bc7f1c63332e9d3c/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7d4d0afb8ee44100b056610addf095a9...697f12ce4d4f48a5a2b79bb42c7fbfb4/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ce70628f4cec48c5ac08e06449f85e89...0bd1e5b6de5c4a08b2109f8f98951dfd/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #12104: ARROW-15269: [C++][Docs] Clarify that not all compute functions are invocable via CallFunction
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12104:
URL: https://github.com/apache/arrow/pull/12104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12104: ARROW-15269: [C++][Docs] Clarify that not all compute functions are invocable via CallFunction
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12104:
URL: https://github.com/apache/arrow/pull/12104#issuecomment-1009973329
Benchmark runs are scheduled for baseline = d88e23273fd4eb7945a5fb94cfdb6315f412ea83 and contender = 7a0141a8cc867e5b406ed97e5decc227923eb3f5. 7a0141a8cc867e5b406ed97e5decc227923eb3f5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1370983ba5d74b9eb2bf54946eaf8ea3...424d64b6b5e34533bc7f1c63332e9d3c/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7d4d0afb8ee44100b056610addf095a9...697f12ce4d4f48a5a2b79bb42c7fbfb4/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ce70628f4cec48c5ac08e06449f85e89...0bd1e5b6de5c4a08b2109f8f98951dfd/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12104: ARROW-15269: [C++][Docs] Clarify that not all compute functions are invocable via CallFunction
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12104:
URL: https://github.com/apache/arrow/pull/12104#issuecomment-1007926067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12104: ARROW-15269: [C++][Docs] Clarify that not all compute functions are invocable via CallFunction
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12104:
URL: https://github.com/apache/arrow/pull/12104#issuecomment-1007926067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org