Re: [PR] CASSANDRA-21139 - Feature/guardrail for misprepare statements [cassandra]

["smiklosovic (via GitHub)" <gi...@apache.org>]

smiklosovic commented on code in PR #4596:
URL: https://github.com/apache/cassandra/pull/4596#discussion_r3099786573


##########
conf/cassandra.yaml:
##########
@@ -2536,6 +2536,14 @@ drop_compact_storage_enabled: false
 # This would also apply to system keyspaces.
 # maximum_replication_factor_warn_threshold: -1
 # maximum_replication_factor_fail_threshold: -1
+#
+# Guardrail to warn or fail when a statement is prepared without bind markers (parameters).
+# This prevents the Prepared Statement Cache from being flooded with unique entries caused
+# by hardcoded literals.
+# When true, warns on the usage of misprepared statements
+# When false, misprepared statements will result in an error
+prepared_statements_require_parameters_warn: true
+prepared_statements_require_parameters_fail: false

Review Comment:
   could you comment it all out? Just comment it out but keep true / false there. It is on defaults like that in Config.java, same in _latest.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org