You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@cn.ibm.com> on 2016/12/02 08:51:45 UTC
Review Request 54302: Added three tests to ensure master validates
roles.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54302/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Guangya Liu.
Bugs: MESOS-6629
https://issues.apache.org/jira/browse/MESOS-6629
Repository: mesos
Description
-------
Frameworks should fail on subscription with invalid settings of
'roles'. Otherwise master should accept subscription.
Diffs
-----
src/tests/master_validation_tests.cpp 5c44967a077551944831383a6bcc6dcb1c626df9
Diff: https://reviews.apache.org/r/54302/diff/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 54302: Added three tests to ensure master
validates roles.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54302/#review157882
-----------------------------------------------------------
Fix it, then Ship it!
Looks good, just some minor suggestions.
src/tests/master_validation_tests.cpp (line 2465)
<https://reviews.apache.org/r/54302/#comment228503>
s/RejectFrameworkWithRolesWithoutMultipleRoleCapability/MissingMultiRoleCapability
src/tests/master_validation_tests.cpp (lines 2472 - 2475)
<https://reviews.apache.org/r/54302/#comment228501>
Can you just set one role here? It should fail if the roles field is used at all, not just if there are multiple roles. Be sure to update the test comments accordingly.
src/tests/master_validation_tests.cpp (lines 2523 - 2524)
<https://reviews.apache.org/r/54302/#comment228504>
s/RejectMultiRoleFrameworkWithNonWhitelistedRole/MultiRoleWhitelist/
- Benjamin Mahler
On Dec. 3, 2016, 1:55 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54302/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2016, 1:55 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Guangya Liu.
>
>
> Bugs: MESOS-6629
> https://issues.apache.org/jira/browse/MESOS-6629
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Frameworks should fail on subscription with invalid settings of
> 'roles'. Otherwise master should accept subscription.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 5c44967a077551944831383a6bcc6dcb1c626df9
>
> Diff: https://reviews.apache.org/r/54302/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 54302: Added three tests to ensure master
validates roles.
Posted by Jay Guo <gu...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54302/
-----------------------------------------------------------
(Updated Dec. 3, 2016, 1:55 a.m.)
Review request for mesos, Benjamin Mahler and Guangya Liu.
Changes
-------
address guangya's comments
Bugs: MESOS-6629
https://issues.apache.org/jira/browse/MESOS-6629
Repository: mesos
Description
-------
Frameworks should fail on subscription with invalid settings of
'roles'. Otherwise master should accept subscription.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 5c44967a077551944831383a6bcc6dcb1c626df9
Diff: https://reviews.apache.org/r/54302/diff/
Testing (updated)
-------
make
make check
Thanks,
Jay Guo
Re: Review Request 54302: Added three tests to ensure master
validates roles.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54302/#review157748
-----------------------------------------------------------
Fix it, then Ship it!
The `Testing Done` section needs some update as previous comments in this patch chain.
src/tests/master_validation_tests.cpp (lines 2485 - 2486)
<https://reviews.apache.org/r/54302/#comment228368>
new line here
- Guangya Liu
On \u5341\u4e8c\u6708 2, 2016, 8:51 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54302/
> -----------------------------------------------------------
>
> (Updated \u5341\u4e8c\u6708 2, 2016, 8:51 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Guangya Liu.
>
>
> Bugs: MESOS-6629
> https://issues.apache.org/jira/browse/MESOS-6629
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Frameworks should fail on subscription with invalid settings of
> 'roles'. Otherwise master should accept subscription.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 5c44967a077551944831383a6bcc6dcb1c626df9
>
> Diff: https://reviews.apache.org/r/54302/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>