You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "Darrel Schneider (JIRA)" <ji...@apache.org> on 2018/05/15 19:22:00 UTC

[jira] [Resolved] (GEODE-5154) null checks on callbackEvent are not needed in txApplyPut

     [ https://issues.apache.org/jira/browse/GEODE-5154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Darrel Schneider resolved GEODE-5154.
-------------------------------------
    Resolution: Not A Problem

The conversion of txApplyPut to RegionMapCommitPut removed the null check on pendingCallbacks

> null checks on callbackEvent are not needed in txApplyPut
> ---------------------------------------------------------
>
>                 Key: GEODE-5154
>                 URL: https://issues.apache.org/jira/browse/GEODE-5154
>             Project: Geode
>          Issue Type: Sub-task
>          Components: transactions
>            Reporter: Darrel Schneider
>            Priority: Major
>
> The txApplyPut code has a number of null checks on the "callbackEvent" which is a field that could be made final and always has a non-null value. In general this is true for all the txApply* methods on AbstractRegionMap. txApplyInvalidate and txApplyDestroy are more complicated would need some additional refactoring to make sure "callbackEvent" is never null.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)