You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/07/28 19:03:33 UTC

[GitHub] [arrow] lidavidm opened a new issue, #36933: [Python] Pointless ellipsis in array repr

lidavidm opened a new issue, #36933:
URL: https://github.com/apache/arrow/issues/36933

   ### Describe the enhancement requested
   
   ```python
   >>> import pyarrow
   >>> pyarrow.array([None] * 5, pyarrow.list_(pyarrow.int8()))
   <pyarrow.lib.ListArray object at 0x7f495698eb60>
   [
     null,
     null,
     ...
     null,
     null
   ]
   >>> pyarrow.__version__
   '12.0.1'
   ```
   
   There's no point ellipsizing the middle of the list; there's only one element, so we may as well show it!
   
   ### Component(s)
   
   Python


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm closed issue #36933: [C++] Pointless ellipsis in array repr

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm closed issue #36933: [C++] Pointless ellipsis in array repr
URL: https://github.com/apache/arrow/issues/36933


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] raycursive commented on issue #36933: [Python] Pointless ellipsis in array repr

Posted by "raycursive (via GitHub)" <gi...@apache.org>.
raycursive commented on issue #36933:
URL: https://github.com/apache/arrow/issues/36933#issuecomment-1676535732

   I guess this is intended, see [Here](https://github.com/apache/arrow/blob/757e0d5cca1124139cd08512882debcb7b4d65d5/cpp/src/arrow/pretty_print_test.cc#L765), it is a part of the test case (tho I don't really understand)
   Here's the [related issue](https://issues.apache.org/jira/browse/ARROW-14798) where the testcase was introduced
   
   I was thinking would it be better to check if the `element size == 2*window + 1`, and if so just erase the ellipsis?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] raycursive commented on issue #36933: [Python] Pointless ellipsis in array repr

Posted by "raycursive (via GitHub)" <gi...@apache.org>.
raycursive commented on issue #36933:
URL: https://github.com/apache/arrow/issues/36933#issuecomment-1679902741

   > > I guess this is intended, see [Here](https://github.com/apache/arrow/blob/757e0d5cca1124139cd08512882debcb7b4d65d5/cpp/src/arrow/pretty_print_test.cc#L765), it is a part of the test case (tho I don't really understand)
   > 
   > Don't take the tests as fixed truth. ;-)
   > 
   > We're manufacturing a new desirable invariant now: don't show `...` in place of only 1 item — an ellipsis replaces 2 or more entries.
   
   Thanks! After thinking of this I do consider that the current implementation doesn't behave as desired. 
   The improvement has been introduced in #37168 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] felipecrv commented on issue #36933: [Python] Pointless ellipsis in array repr

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on issue #36933:
URL: https://github.com/apache/arrow/issues/36933#issuecomment-1679656712

   > I guess this is intended, see [Here](https://github.com/apache/arrow/blob/757e0d5cca1124139cd08512882debcb7b4d65d5/cpp/src/arrow/pretty_print_test.cc#L765), it is a part of the test case (tho I don't really understand)
   
   Don't take the tests as fixed truth. ;-)
    
   We're manufacturing a new desirable invariant now: don't show `...` in place of only 1 item — an ellipsis replaces 2 or more entries.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org