You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/29 21:36:06 UTC

[GitHub] [superset] codecov[bot] edited a comment on pull request #13801: fix(explore): strip semicolons in virtual table SQL

codecov[bot] edited a comment on pull request #13801:
URL: https://github.com/apache/superset/pull/13801#issuecomment-807650850


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13801?src=pr&el=h1) Report
   > Merging [#13801](https://codecov.io/gh/apache/superset/pull/13801?src=pr&el=desc) (10d62df) into [master](https://codecov.io/gh/apache/superset/commit/1d5c58d005646aa4495223bcd49701b14dfae99a?el=desc) (1d5c58d) will **increase** coverage by `0.15%`.
   > The diff coverage is `50.69%`.
   
   > :exclamation: Current head 10d62df differs from pull request most recent head f43e6b3. Consider uploading reports for the commit f43e6b3 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13801/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13801?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13801      +/-   ##
   ==========================================
   + Coverage   76.79%   76.95%   +0.15%     
   ==========================================
     Files         934      939       +5     
     Lines       47201    47692     +491     
     Branches     5876     6016     +140     
   ==========================================
   + Hits        36248    36699     +451     
   - Misses      10794    10851      +57     
   + Partials      159      142      -17     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.06% <22.72%> (-1.66%)` | :arrow_down: |
   | hive | `80.27% <96.77%> (+0.01%)` | :arrow_up: |
   | mysql | `80.58% <96.77%> (+0.01%)` | :arrow_up: |
   | postgres | `80.59% <96.77%> (+<0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.96% <96.77%> (-0.15%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13801?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/superset/pull/13801/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `66.66% <ø> (ø)` | |
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13801/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13801/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `55.05% <ø> (ø)` | |
   | [...perset-frontend/src/components/FormLabel/index.tsx](https://codecov.io/gh/apache/superset/pull/13801/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRm9ybUxhYmVsL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/ProgressBar/index.tsx](https://codecov.io/gh/apache/superset/pull/13801/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUHJvZ3Jlc3NCYXIvaW5kZXgudHN4) | `16.66% <ø> (ø)` | |
   | [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13801/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `85.29% <ø> (+0.37%)` | :arrow_up: |
   | [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/13801/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `67.78% <ø> (+14.84%)` | :arrow_up: |
   | [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13801/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `85.57% <ø> (-1.03%)` | :arrow_down: |
   | [...e/components/controls/SelectAsyncControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13801/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RBc3luY0NvbnRyb2wvaW5kZXguanN4) | `33.33% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/types.ts](https://codecov.io/gh/apache/superset/pull/13801/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
   | ... and [88 more](https://codecov.io/gh/apache/superset/pull/13801/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13801?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13801?src=pr&el=footer). Last update [1d5c58d...f43e6b3](https://codecov.io/gh/apache/superset/pull/13801?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org