You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/09/25 14:48:40 UTC

[commons-email] branch master updated (5420eb8 -> 725bece)

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-email.git


    from 5420eb8  Drop FindBugs property, it is no longer used.
     new 5e24787  Drop FindBugs, SpotBugs is already there
     new 30f92c0  Update property names for SpotBugs
     new 725bece  Bump spotbugs-maven-plugin from 4.2.2 to 4.7.2

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 ...xclude-filter.xml => spotbugs-exclude-filter.xml} |  9 +++++++++
 pom.xml                                              | 20 +++++---------------
 src/changes/changes.xml                              |  4 ++--
 3 files changed, 16 insertions(+), 17 deletions(-)
 rename conf/{findbugs-exclude-filter.xml => spotbugs-exclude-filter.xml} (88%)


[commons-email] 01/03: Drop FindBugs, SpotBugs is already there

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-email.git

commit 5e24787799f27a4fc5dd0e43c11f1b15b6f1e23e
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Sep 25 10:39:38 2022 -0400

    Drop FindBugs, SpotBugs is already there
---
 pom.xml | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/pom.xml b/pom.xml
index bbccadc..61ac746 100644
--- a/pom.xml
+++ b/pom.xml
@@ -318,6 +318,10 @@
         <easymock.version>4.3</easymock.version>
         <spotbugs.plugin.version>4.2.2</spotbugs.plugin.version>
         <spotbugs.impl.version>4.2.2</spotbugs.impl.version>
+        
+        <commons.spotbugs.plugin.version>4.5.3.0</commons.spotbugs.plugin.version>
+        <commons.spotbugs.impl.version>4.5.3</commons.spotbugs.impl.version>    
+
         <commons.jacoco.version>0.8.8</commons.jacoco.version>
     </properties> 
 
@@ -479,16 +483,6 @@
                     <targetJdk>${maven.compiler.target}</targetJdk>
                 </configuration>
             </plugin>
-            <plugin>
-                <groupId>org.codehaus.mojo</groupId>
-                <artifactId>findbugs-maven-plugin</artifactId>
-                <version>${findbugs.version}</version>
-                <configuration>
-                    <threshold>Normal</threshold>
-                    <effort>Default</effort>
-                    <excludeFilterFile>${basedir}/conf/findbugs-exclude-filter.xml</excludeFilterFile>
-                </configuration>
-            </plugin>
             <plugin>
                 <groupId>org.apache.rat</groupId>
                 <artifactId>apache-rat-plugin</artifactId>


[commons-email] 02/03: Update property names for SpotBugs

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-email.git

commit 30f92c03b1a955b11938c8af938e5b21fb264a17
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Sep 25 10:41:30 2022 -0400

    Update property names for SpotBugs
---
 pom.xml | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/pom.xml b/pom.xml
index 61ac746..bc93e1c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -316,12 +316,8 @@
         
         <powermock.version>2.0.9</powermock.version>
         <easymock.version>4.3</easymock.version>
-        <spotbugs.plugin.version>4.2.2</spotbugs.plugin.version>
-        <spotbugs.impl.version>4.2.2</spotbugs.impl.version>
-        
-        <commons.spotbugs.plugin.version>4.5.3.0</commons.spotbugs.plugin.version>
-        <commons.spotbugs.impl.version>4.5.3</commons.spotbugs.impl.version>    
-
+        <commons.spotbugs.plugin.version>4.2.2</commons.spotbugs.plugin.version>
+        <commons.spotbugs.impl.version>4.2.2</commons.spotbugs.impl.version>    
         <commons.jacoco.version>0.8.8</commons.jacoco.version>
     </properties> 
 
@@ -425,12 +421,12 @@
           <plugin>
             <groupId>com.github.spotbugs</groupId>
             <artifactId>spotbugs-maven-plugin</artifactId>
-            <version>${spotbugs.plugin.version}</version>
+            <version>${commons.spotbugs.plugin.version}</version>
             <dependencies>
               <dependency>
                 <groupId>com.github.spotbugs</groupId>
                 <artifactId>spotbugs</artifactId>
-                <version>${spotbugs.impl.version}</version>
+                <version>${commons.spotbugs.impl.version}</version>
               </dependency>
             </dependencies>        
             <configuration>


[commons-email] 03/03: Bump spotbugs-maven-plugin from 4.2.2 to 4.7.2

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-email.git

commit 725becea9e4d907eeae2b4da05f65dffcecc3e78
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Sep 25 10:47:57 2022 -0400

    Bump spotbugs-maven-plugin from 4.2.2 to 4.7.2
    
    - Bump spotbugs from 4.2.2 to 4.7.2
    - TODO Can any of these be done without breaking binary compatibility
    -- EI_EXPOSE_REP
    -- EI_EXPOSE_REP2
---
 .../{findbugs-exclude-filter.xml => spotbugs-exclude-filter.xml} | 9 +++++++++
 pom.xml                                                          | 6 +++---
 src/changes/changes.xml                                          | 4 ++--
 3 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/conf/findbugs-exclude-filter.xml b/conf/spotbugs-exclude-filter.xml
similarity index 88%
rename from conf/findbugs-exclude-filter.xml
rename to conf/spotbugs-exclude-filter.xml
index bd13e25..eba9cdc 100644
--- a/conf/findbugs-exclude-filter.xml
+++ b/conf/spotbugs-exclude-filter.xml
@@ -41,4 +41,13 @@
     <Bug pattern="DM_DEFAULT_ENCODING" />
   </Match>
 
+  <!-- TODO Can any of these be done without breaking binary compatibility? -->
+  <Match>
+    <Class name="~.*" />
+    <Or>
+      <Bug pattern="EI_EXPOSE_REP" />
+      <Bug pattern="EI_EXPOSE_REP2" />
+    </Or>
+  </Match>
+
 </FindBugsFilter>
diff --git a/pom.xml b/pom.xml
index bc93e1c..d9229fe 100644
--- a/pom.xml
+++ b/pom.xml
@@ -316,8 +316,8 @@
         
         <powermock.version>2.0.9</powermock.version>
         <easymock.version>4.3</easymock.version>
-        <commons.spotbugs.plugin.version>4.2.2</commons.spotbugs.plugin.version>
-        <commons.spotbugs.impl.version>4.2.2</commons.spotbugs.impl.version>    
+        <commons.spotbugs.plugin.version>4.7.2.0</commons.spotbugs.plugin.version>
+        <commons.spotbugs.impl.version>4.7.2</commons.spotbugs.impl.version>    
         <commons.jacoco.version>0.8.8</commons.jacoco.version>
     </properties> 
 
@@ -430,7 +430,7 @@
               </dependency>
             </dependencies>        
             <configuration>
-            <!-- <excludeFilterFile>${basedir}/spotbugs-exclude-filter.xml</excludeFilterFile> -->
+            <excludeFilterFile>${basedir}/conf/spotbugs-exclude-filter.xml</excludeFilterFile>
             </configuration>
           </plugin>
         </plugins>
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 01d4d74..2403886 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -59,10 +59,10 @@
         Bump commons-parent from 50 to 53.
       </action>
       <action type="update" due-to="Dependabot, Gary Gregory" dev="ggregory">
-        Bump spotbugs-maven-plugin from 4.0.0 to 4.2.2 #18.
+        Bump spotbugs-maven-plugin from 4.0.0 to 4.7.2 #18.
       </action>
       <action type="update" due-to="Dependabot" dev="ggregory">
-        Bump spotbugs from 4.0.6 to 4.2.2 #40.
+        Bump spotbugs from 4.0.6 to 4.7.2 #40.
       </action>
       <action type="update" due-to="Dependabot, Gary Gregory" dev="ggregory">
         Bump junit from 4.13 to 4.13.2 #32.