[M] Change in asterixdb[master]: [ASTERIXDB-3884][HYR] Release a job's state when its submission fails

[AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>]

From Ali Alsuliman <al...@gmail.com>:

Hello Anon. E. Moose #1000171, Jenkins, 

I'd like you to reexamine a change. Please visit

    https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21815?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Contrib+1 by Anon. E. Moose #1000171, Integration-Tests+1 by Jenkins, Verified+1 by Jenkins


Change subject: [ASTERIXDB-3884][HYR] Release a job's state when its submission fails
......................................................................

[ASTERIXDB-3884][HYR] Release a job's state when its submission fails

- user model changes: no
- storage format changes: no
- interface changes: yes

Details:
JobManager.add notifies the job lifecycle listeners that a job has been
created and only then queues or executes it. When that throws - a full
job queue being the reachable case - the job neither starts nor finishes
and its id never reaches the client, so no later notification and no
caller can release what the listeners registered. For an atomic
statement that strands the global transaction context, and the resource
map it holds, in a repository that is filled from the job lifecycle but
drained only from the statement path.

Notify the listeners of the failure instead, defaulting the new method
to a no-op so the other implementors are untouched. It is called from a
finally rather than the existing catch, which sees only
HyracksDataException while queueing, execution and an unknown submission
status can all fail unchecked.

Ext-ref: MB-73831

Co-Authored-By: Claude Opus 5 <no...@anthropic.com>
Change-Id: Ie110c960950a75c8edc7e5e5f92dc33b49e6115e
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java
M asterixdb/asterix-app/src/test/java/org/apache/asterix/app/cc/GlobalTxManagerTest.java
M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/IJobLifecycleListener.java
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/application/CCServiceContext.java
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/test/java/org/apache/hyracks/control/cc/job/JobManagerTest.java
6 files changed, 178 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/15/21815/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21815?usp=email
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie110c960950a75c8edc7e5e5f92dc33b49e6115e
Gerrit-Change-Number: 21815
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>