[GitHub] [flink] tillrohrmann commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times

[GitBox <gi...@apache.org>]

tillrohrmann commented on issue #10657: [FLINK-15360][e2e] Fix the parameter issue in retry_times
URL: https://github.com/apache/flink/pull/10657#issuecomment-568423724
 
 
   Quick question, isn't the problem that we pass the `command` in https://github.com/apache/flink/commit/cce1cef50d993aba5060ea5ac597174525ae895e as multiple strings instead of wrapping the command in `""` before we pass it to `retry_times`? If I look at `retry_times_with_backoff_and_cleanup` then one also needs to pass the `command` and `cleanup_command` as a single string (meaning one needs to wrap it into `""`). The fix seems to underline this as we are joining `${@:3}` into a single string.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services