You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/13 10:18:46 UTC
[GitHub] [spark] leoluan2009 opened a new pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
leoluan2009 opened a new pull request #31822:
URL: https://github.com/apache/spark/pull/31822
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Remove all SQLConf.get to conf in all rules, since all rules extended from SQLConfHelper
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Clean up code.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-800112354
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40691/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #31822:
URL: https://github.com/apache/spark/pull/31822#discussion_r593734245
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala
##########
@@ -97,7 +96,7 @@ object PartitionPruning extends Rule[LogicalPlan] with PredicateHelper {
filteringPlan,
joinKeys,
index,
- SQLConf.get.dynamicPartitionPruningReuseBroadcastOnly || !hasBenefit),
+ รง.dynamicPartitionPruningReuseBroadcastOnly || !hasBenefit),
Review comment:
typo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798117358
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798199566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from SQLConfHelper
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31822:
URL: https://github.com/apache/spark/pull/31822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798117358
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798161413
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40611/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798151983
**[Test build #136027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136027/testReport)** for PR 31822 at commit [`ead156c`](https://github.com/apache/spark/commit/ead156c8bf57201268e438642c48b5334513f113).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-800112316
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40691/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798837163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-799968426
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798837163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-800042290
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136102/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-800006790
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136095/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from SQLConfHelper
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-801725630
**[Test build #136193 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136193/testReport)** for PR 31822 at commit [`10e5128`](https://github.com/apache/spark/commit/10e5128de550b91ef375888917ef994bfa5f037c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class Abs(child: Expression, failOnError: Boolean = SQLConf.get.ansiEnabled)`
* `case class TimestampAddYMInterval(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] leoluan2009 commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
leoluan2009 commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798097704
cc @wangyum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798151983
**[Test build #136027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136027/testReport)** for PR 31822 at commit [`ead156c`](https://github.com/apache/spark/commit/ead156c8bf57201268e438642c48b5334513f113).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-799968426
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798202364
**[Test build #136029 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136029/testReport)** for PR 31822 at commit [`096b2da`](https://github.com/apache/spark/commit/096b2dadc5481dcb296995b54d885458f9a06152).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-799238739
looks good, let's fix all the places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-800107755
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136109/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from SQLConfHelper
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-801654549
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-799322067
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40646/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798101456
ok to test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798153607
**[Test build #136027 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136027/testReport)** for PR 31822 at commit [`ead156c`](https://github.com/apache/spark/commit/ead156c8bf57201268e438642c48b5334513f113).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from SQLConfHelper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-801621810
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40775/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from SQLConfHelper
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-801603687
**[Test build #136193 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136193/testReport)** for PR 31822 at commit [`10e5128`](https://github.com/apache/spark/commit/10e5128de550b91ef375888917ef994bfa5f037c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798125473
There are still some rules that have not been cleaned up:
https://github.com/apache/spark/blob/9e6882feca0800d5d4f9920886cb5dae73bbe1d4/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CTESubstitution.scala#L34
https://github.com/apache/spark/blob/e3058ba17cb4512537953eb4ded884e24ee93ba2/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala#L84
https://github.com/apache/spark/blob/66c5e0132209a5a94f9d7efb5e895f143b0ef53b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala#L101
https://github.com/apache/spark/blob/5d9cfd727c21f0f50f92c0236cdeb20f3b9111dc/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala#L275
https://github.com/apache/spark/blob/32a523b56fc329e858f3a463314c13e3710be5e0/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/QueryStageExec.scala#L225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-799323340
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136063/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798210087
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136029/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798210009
**[Test build #136029 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136029/testReport)** for PR 31822 at commit [`096b2da`](https://github.com/apache/spark/commit/096b2dadc5481dcb296995b54d885458f9a06152).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from SQLConfHelper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-801621810
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40775/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-800109410
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40691/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-800041096
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40684/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-799943342
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from SQLConfHelper
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-801603687
**[Test build #136193 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136193/testReport)** for PR 31822 at commit [`10e5128`](https://github.com/apache/spark/commit/10e5128de550b91ef375888917ef994bfa5f037c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-800007611
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40678/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-799322067
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40646/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798291151
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40613/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-800107755
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136109/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-800026210
Rename `Remove all SQLConf.get if extends from Rule` to `Remove all SQLConf.get if extends from SQLConfHelper`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from SQLConfHelper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-801744634
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136193/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-799323340
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136063/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798202364
**[Test build #136029 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136029/testReport)** for PR 31822 at commit [`096b2da`](https://github.com/apache/spark/commit/096b2dadc5481dcb296995b54d885458f9a06152).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from SQLConfHelper
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-801744634
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136193/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-800007611
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-798839864
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31822:
URL: https://github.com/apache/spark/pull/31822#issuecomment-800112354
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40691/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org