You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/11 06:57:19 UTC
[GitHub] [incubator-nuttx] yamt opened a new issue #536: unclear
NuttXCCodingStandard examples
yamt opened a new issue #536: unclear NuttXCCodingStandard examples
URL: https://github.com/apache/incubator-nuttx/issues/536
NuttXCCodingStandard.html lists the following examples in both of "Preferred" and "Acceptable".
extern int g_someint;
static int g_anotherint;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #536: unclear
NuttXCCodingStandard examples
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #536: unclear NuttXCCodingStandard examples
URL: https://github.com/apache/incubator-nuttx/issues/536#issuecomment-597812352
@patacongo good to know - Should we add this note to the repo so that that never happens?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #536: unclear
NuttXCCodingStandard examples
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #536: unclear NuttXCCodingStandard examples
URL: https://github.com/apache/incubator-nuttx/issues/536#issuecomment-597758167
We should carefully entertain any PR to modify the coding standard. Remember that the version in Confluence is NOT the master. The master is in the nuttx repository at Documents/NuttXCCCodingStandard.html and can be updated via PR as with any other file. The verion on Confluence is then a copy of that. Any changes made in Confluence will be lost the next time that the Documents are updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #536: unclear
NuttXCCodingStandard examples
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #536: unclear NuttXCCodingStandard examples
URL: https://github.com/apache/incubator-nuttx/issues/536#issuecomment-597613353
I think the problem is bigger then just this one.
Why do we have N ways? Acceptable, Discouraged, Correct, Preferred,
In the past if you choose to do it the any way other then Preferred, your contribution would be modified to be the Preferred way.
This sort of thing is what makes having or creating a formatting tool a complex mess for NO ADDED value.
Why not remove all the ambiguity from the fix the CS document and fix the tool?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #536: unclear
NuttXCCodingStandard examples
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #536: unclear NuttXCCodingStandard examples
URL: https://github.com/apache/incubator-nuttx/issues/536#issuecomment-597815127
> Should we add this note to the repo so that that never happens?
It is true of all of the documents under the documents tabs. These are only copies. The really should just be read-only
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services