You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/16 19:07:21 UTC

[GitHub] [airflow] aaronfowles opened a new pull request #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras

aaronfowles opened a new pull request #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras
URL: https://github.com/apache/airflow/pull/7739
 
 
   This PR adds a new option in the SSH connection extras where you can specify base64 ssh-rsa public key of a host. The SSHHook constructor will then add this key to ~/.ssh/known_hosts if not present.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] RosterIn commented on a change in pull request #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras

Posted by GitBox <gi...@apache.org>.
RosterIn commented on a change in pull request #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras
URL: https://github.com/apache/airflow/pull/7739#discussion_r410988476
 
 

 ##########
 File path: airflow/providers/ssh/hooks/ssh.py
 ##########
 @@ -275,3 +281,36 @@ def create_tunnel(
                       category=DeprecationWarning)
 
         return self.get_tunnel(remote_port, remote_host, local_port)
+
+    @staticmethod
+    def _add_new_record_to_known_hosts(record, file):
+        file.write(''.join([record, '\n']))
+
+    @staticmethod
+    def add_host_to_known_hosts(host, key_type, host_key):
+        """This adds a specified remote_host public key to the known_hosts
+            in order to prevent man-in-the-middle attacks."""
+        # The .ssh hidden directory is required and not present on all airflow deployments
+        known_hosts_file_ref = SSHHook._create_known_hosts()
 
 Review comment:
   Is there assumption here that this method always successful?
   Can there be cases where it throws exception that isn't handled?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras
URL: https://github.com/apache/airflow/pull/7739#issuecomment-600042897
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=h1) Report
   > Merging [#7739](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4ff9d63db82a7799b495cd41f8678ac8d0817a53&el=desc) will **decrease** coverage by `0.77%`.
   > The diff coverage is `90.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7739/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7739      +/-   ##
   ==========================================
   - Coverage   86.94%   86.17%   -0.78%     
   ==========================================
     Files         915      915              
     Lines       44176    44196      +20     
   ==========================================
   - Hits        38411    38085     -326     
   - Misses       5765     6111     +346     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/providers/ssh/hooks/ssh.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc3NoL2hvb2tzL3NzaC5weQ==) | `88.05% <90.00%> (+0.34%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `95.07% <100.00%> (ø)` | |
   | [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0.00%> (-72.16%)` | :arrow_down: |
   | [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | ... and [12 more](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=footer). Last update [4ff9d63...d11472e](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras
URL: https://github.com/apache/airflow/pull/7739#issuecomment-600042897
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=h1) Report
   > Merging [#7739](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2a98a61f596fa463f921aa4203a3b2019e2ac3a2&el=desc) will **decrease** coverage by `0.73%`.
   > The diff coverage is `90.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7739/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7739      +/-   ##
   ==========================================
   - Coverage   87.10%   86.36%   -0.74%     
   ==========================================
     Files         928      928              
     Lines       45025    45045      +20     
   ==========================================
   - Hits        39217    38902     -315     
   - Misses       5808     6143     +335     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/providers/ssh/hooks/ssh.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc3NoL2hvb2tzL3NzaC5weQ==) | `88.14% <90.00%> (+0.32%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `95.07% <100.00%> (ø)` | |
   | [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
   | [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | ... and [13 more](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=footer). Last update [2a98a61...5f21d05](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras
URL: https://github.com/apache/airflow/pull/7739#issuecomment-600042897
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=h1) Report
   > Merging [#7739](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/97dbc1b168c2a1de76ff30094a60bdcb4a48a5ea?src=pr&el=desc) will **decrease** coverage by `0.31%`.
   > The diff coverage is `90.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7739/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7739      +/-   ##
   ==========================================
   - Coverage   86.94%   86.62%   -0.32%     
   ==========================================
     Files         920      920              
     Lines       44456    44476      +20     
   ==========================================
   - Hits        38651    38527     -124     
   - Misses       5805     5949     +144
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `95.07% <100%> (ø)` | :arrow_up: |
   | [airflow/providers/ssh/hooks/ssh.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc3NoL2hvb2tzL3NzaC5weQ==) | `88.05% <90%> (+0.34%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0%> (-45.66%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.83% <0%> (-0.29%)` | :arrow_down: |
   | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.73% <0%> (-0.15%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=footer). Last update [97dbc1b...7477e61](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras
URL: https://github.com/apache/airflow/pull/7739#issuecomment-600042897
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=h1) Report
   > Merging [#7739](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2a98a61f596fa463f921aa4203a3b2019e2ac3a2&el=desc) will **decrease** coverage by `0.73%`.
   > The diff coverage is `90.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7739/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7739      +/-   ##
   ==========================================
   - Coverage   87.10%   86.36%   -0.74%     
   ==========================================
     Files         928      928              
     Lines       45025    45045      +20     
   ==========================================
   - Hits        39217    38902     -315     
   - Misses       5808     6143     +335     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/providers/ssh/hooks/ssh.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc3NoL2hvb2tzL3NzaC5weQ==) | `88.14% <90.00%> (+0.32%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `95.07% <100.00%> (ø)` | |
   | [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
   | [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
   | [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
   | [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
   | [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
   | ... and [13 more](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=footer). Last update [2a98a61...5f21d05](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras
URL: https://github.com/apache/airflow/pull/7739#issuecomment-600042897
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=h1) Report
   > Merging [#7739](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4ff9d63db82a7799b495cd41f8678ac8d0817a53?src=pr&el=desc) will **decrease** coverage by `22.4%`.
   > The diff coverage is `90.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7739/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7739       +/-   ##
   ===========================================
   - Coverage   86.94%   64.54%   -22.41%     
   ===========================================
     Files         915      914        -1     
     Lines       44176    44183        +7     
   ===========================================
   - Hits        38411    28516     -9895     
   - Misses       5765    15667     +9902
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `75.35% <100%> (-19.72%)` | :arrow_down: |
   | [airflow/providers/ssh/hooks/ssh.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc3NoL2hvb2tzL3NzaC5weQ==) | `88.05% <90%> (+0.34%)` | :arrow_up: |
   | [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/contrib/hooks/vertica\_hook.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3ZlcnRpY2FfaG9vay5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/contrib/sensors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvX19pbml0X18ucHk=) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [...viders/docker/example\_dags/example\_docker\_swarm.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZG9ja2VyL2V4YW1wbGVfZGFncy9leGFtcGxlX2RvY2tlcl9zd2FybS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/hooks/webhdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy93ZWJoZGZzX2hvb2sucHk=) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/contrib/sensors/emr\_base\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZW1yX2Jhc2Vfc2Vuc29yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [...irflow/contrib/operators/slack\_webhook\_operator.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zbGFja193ZWJob29rX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | ... and [493 more](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=footer). Last update [4ff9d63...d11472e](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras
URL: https://github.com/apache/airflow/pull/7739#issuecomment-600042897
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=h1) Report
   > Merging [#7739](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/97dbc1b168c2a1de76ff30094a60bdcb4a48a5ea?src=pr&el=desc) will **decrease** coverage by `0.31%`.
   > The diff coverage is `90.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7739/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7739      +/-   ##
   ==========================================
   - Coverage   86.94%   86.62%   -0.32%     
   ==========================================
     Files         920      920              
     Lines       44456    44476      +20     
   ==========================================
   - Hits        38651    38527     -124     
   - Misses       5805     5949     +144
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `95.07% <100%> (ø)` | :arrow_up: |
   | [airflow/providers/ssh/hooks/ssh.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc3NoL2hvb2tzL3NzaC5weQ==) | `88.05% <90%> (+0.34%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0%> (-45.66%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.83% <0%> (-0.29%)` | :arrow_down: |
   | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.73% <0%> (-0.15%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=footer). Last update [97dbc1b...7477e61](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7739: [AIRFLOW-7044] Add host_key option to SSH connection extras
URL: https://github.com/apache/airflow/pull/7739#issuecomment-600042897
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=h1) Report
   > Merging [#7739](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/3f9f845cd972d5165e4cd0b9249d787ef871d332&el=desc) will **decrease** coverage by `22.71%`.
   > The diff coverage is `90.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7739/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7739       +/-   ##
   ===========================================
   - Coverage   88.32%   65.60%   -22.72%     
   ===========================================
     Files         935      935               
     Lines       45243    45263       +20     
   ===========================================
   - Hits        39959    29694    -10265     
   - Misses       5284    15569    +10285     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/providers/ssh/hooks/ssh.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvc3NoL2hvb2tzL3NzaC5weQ==) | `88.14% <90.00%> (+0.32%)` | :arrow_up: |
   | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `75.35% <100.00%> (-19.72%)` | :arrow_down: |
   | [airflow/hooks/S3\_hook.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9TM19ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/hooks/pig\_hook.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9waWdfaG9vay5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/hooks/hdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oZGZzX2hvb2sucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/hooks/http\_hook.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9odHRwX2hvb2sucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/hooks/jdbc\_hook.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9qZGJjX2hvb2sucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/hooks/druid\_hook.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kcnVpZF9ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [505 more](https://codecov.io/gh/apache/airflow/pull/7739/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=footer). Last update [3f9f845...88fef62](https://codecov.io/gh/apache/airflow/pull/7739?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services