Re: [PR] THRIFT-5712 - Added Dart 3 Compatibility [thrift]

["Jens-G (via GitHub)" <gi...@apache.org>]

Jens-G commented on code in PR #2930:
URL: https://github.com/apache/thrift/pull/2930#discussion_r1495032364


##########
lib/dart/lib/src/console/t_web_socket.dart:
##########
@@ -3,14 +3,14 @@
 /// distributed with this work for additional information
 /// regarding copyright ownership. The ASF licenses this file
 /// to you under the Apache License, Version 2.0 (the
-/// "License"); you may not use this file except in compliance
+/// 'License'); you may not use this file except in compliance

Review Comment:
   Not sure why we need to modify the license header **contents**? 
   There are more places I will not comment every single one.



##########
lib/dart/lib/src/transport/t_message_reader.dart:
##########
@@ -1,3 +1,5 @@
+part of thrift;
+

Review Comment:
   Not sure why we need to modify the license header **location**?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org