You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Andrzej Bialecki (JIRA)" <ji...@apache.org> on 2010/10/18 17:17:22 UTC
[jira] Created: (SOLR-2173) Suggester should always rebuild Lookup
data if Lookup.load fails
Suggester should always rebuild Lookup data if Lookup.load fails
----------------------------------------------------------------
Key: SOLR-2173
URL: https://issues.apache.org/jira/browse/SOLR-2173
Project: Solr
Issue Type: Bug
Affects Versions: 3.1, 4.0
Reporter: Andrzej Bialecki
Assignee: Andrzej Bialecki
Fix For: 3.1, 4.0
See also the comments [here|https://issues.apache.org/jira/browse/SOLR-2002?focusedCommentId=12921507&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12921507]. Currently available Lookup implementations don't implement load/save - these calls always return false.
This means that Lookup dictionary is lost on searcher reload (or core reload) and needs to be rebuilt. However, this breaks the semantics of spellcheck.build=true, because with this patch the dictionary will always be recreated, even if this parameter is false... Still, this may be less surprising to users than a vanishing autosuggest functionality after commit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (SOLR-2173) Suggester should always rebuild Lookup
data if Lookup.load fails
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrzej Bialecki resolved SOLR-2173.
-------------------------------------
Resolution: Fixed
Committed to trunk (1025781) and branch_3x (1025783). Thanks!
> Suggester should always rebuild Lookup data if Lookup.load fails
> ----------------------------------------------------------------
>
> Key: SOLR-2173
> URL: https://issues.apache.org/jira/browse/SOLR-2173
> Project: Solr
> Issue Type: Bug
> Affects Versions: 3.1, 4.0
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2173.patch
>
>
> See also the comments [here|https://issues.apache.org/jira/browse/SOLR-2002?focusedCommentId=12921507&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12921507]. Currently available Lookup implementations don't implement load/save - these calls always return false.
> This means that Lookup dictionary is lost on searcher reload (or core reload) and needs to be rebuilt. However, this breaks the semantics of spellcheck.build=true, because with this patch the dictionary will always be recreated, even if this parameter is false... Still, this may be less surprising to users than a vanishing autosuggest functionality after commit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2173) Suggester should always rebuild
Lookup data if Lookup.load fails
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923060#action_12923060 ]
Yonik Seeley commented on SOLR-2173:
------------------------------------
Seems like a reasonable approach to me.
> Suggester should always rebuild Lookup data if Lookup.load fails
> ----------------------------------------------------------------
>
> Key: SOLR-2173
> URL: https://issues.apache.org/jira/browse/SOLR-2173
> Project: Solr
> Issue Type: Bug
> Affects Versions: 3.1, 4.0
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2173.patch
>
>
> See also the comments [here|https://issues.apache.org/jira/browse/SOLR-2002?focusedCommentId=12921507&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12921507]. Currently available Lookup implementations don't implement load/save - these calls always return false.
> This means that Lookup dictionary is lost on searcher reload (or core reload) and needs to be rebuilt. However, this breaks the semantics of spellcheck.build=true, because with this patch the dictionary will always be recreated, even if this parameter is false... Still, this may be less surprising to users than a vanishing autosuggest functionality after commit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2173) Suggester should always rebuild Lookup
data if Lookup.load fails
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrzej Bialecki updated SOLR-2173:
------------------------------------
Attachment: SOLR-2173.patch
Patch to fix the issue and a unit test.
> Suggester should always rebuild Lookup data if Lookup.load fails
> ----------------------------------------------------------------
>
> Key: SOLR-2173
> URL: https://issues.apache.org/jira/browse/SOLR-2173
> Project: Solr
> Issue Type: Bug
> Affects Versions: 3.1, 4.0
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2173.patch
>
>
> See also the comments [here|https://issues.apache.org/jira/browse/SOLR-2002?focusedCommentId=12921507&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12921507]. Currently available Lookup implementations don't implement load/save - these calls always return false.
> This means that Lookup dictionary is lost on searcher reload (or core reload) and needs to be rebuilt. However, this breaks the semantics of spellcheck.build=true, because with this patch the dictionary will always be recreated, even if this parameter is false... Still, this may be less surprising to users than a vanishing autosuggest functionality after commit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org