You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zhaohehuhu (via GitHub)" <gi...@apache.org> on 2024/08/14 05:42:36 UTC
[PR] Fix make distribution shell to include client jars [celeborn]
zhaohehuhu opened a new pull request, #2682:
URL: https://github.com/apache/celeborn/pull/2682
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix make distribution shell to build client jars [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2682:
URL: https://github.com/apache/celeborn/pull/2682#issuecomment-2287954221
@zhaohehuhu, please update the title of this pull request to link with ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix make distribution shell to build client jars [celeborn]
Posted by "zhaohehuhu (via GitHub)" <gi...@apache.org>.
zhaohehuhu commented on PR #2682:
URL: https://github.com/apache/celeborn/pull/2682#issuecomment-2287902249
plz review this PR. Thanks @FMX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1559]Fix make distribution script failed to recognize specific profile [celeborn]
Posted by "zhaohehuhu (via GitHub)" <gi...@apache.org>.
zhaohehuhu commented on code in PR #2682:
URL: https://github.com/apache/celeborn/pull/2682#discussion_r1717828781
##########
build/make-distribution.sh:
##########
@@ -262,7 +256,8 @@ function sbt_build_service {
echo "Celeborn $VERSION$GITREVSTRING" > "$DIST_DIR/RELEASE"
echo "Build flags: $@" >> "$DIST_DIR/RELEASE"
- if [[ "$HADOOP_AWS_ENABLED" == "true" ]]; then
+
+ if [[ $@ == *"hadoop-aws"* ]]; then
export SBT_MAVEN_PROFILES="hadoop-aws"
Review Comment:
Done. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix make distribution shell to build client jars [celeborn]
Posted by "zhaohehuhu (via GitHub)" <gi...@apache.org>.
zhaohehuhu commented on PR #2682:
URL: https://github.com/apache/celeborn/pull/2682#issuecomment-2290393712
> @zhaohehuhu, please update the title of this pull request to link with ticket.
Got it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1559]Fix make distribution script failed to recognize specific profile [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on code in PR #2682:
URL: https://github.com/apache/celeborn/pull/2682#discussion_r1717812126
##########
build/make-distribution.sh:
##########
@@ -262,7 +256,8 @@ function sbt_build_service {
echo "Celeborn $VERSION$GITREVSTRING" > "$DIST_DIR/RELEASE"
echo "Build flags: $@" >> "$DIST_DIR/RELEASE"
- if [[ "$HADOOP_AWS_ENABLED" == "true" ]]; then
+
+ if [[ $@ == *"hadoop-aws"* ]]; then
export SBT_MAVEN_PROFILES="hadoop-aws"
Review Comment:
There is no need to export this variable. Just setting this variable should be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1559]Fix make distribution script failed to recognize specific profile [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #2682: [CELEBORN-1559]Fix make distribution script failed to recognize specific profile
URL: https://github.com/apache/celeborn/pull/2682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org