You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2006/03/06 06:42:23 UTC
[jira] Commented: (MWAR-12) Add resource filtering to war plugin
[ http://jira.codehaus.org/browse/MWAR-12?page=comments#action_60182 ]
Brett Porter commented on MWAR-12:
----------------------------------
Scott, IIUC your solution will only work for WARs, and will break resources for JARs.
We agreed on dev@maven.apache.org that classpath resources and webapp resources are different, which would be confused if the resources plugin were duplicated.
Brian's patch is closest to the correct solution (we can avoid the need for the implementation attribute), and the filtering/resource code needs to be in a library shared by the resources plugin and the war plugin (I'm not sure if this is the case in here or not).
I'll try and find some cycles to apply this.
> Add resource filtering to war plugin
> ------------------------------------
>
> Key: MWAR-12
> URL: http://jira.codehaus.org/browse/MWAR-12
> Project: Maven 2.x War Plugin
> Type: Improvement
> Reporter: Mark Hobson
> Assignee: Brett Porter
> Attachments: AbstractWarMojo.patch, MWAR-12.patch, ResourcesMojo.patch, test.zip
>
> Original Estimate: 15 minutes
> Remaining: 15 minutes
>
> I'd like to patch the war plugin to perform resource filtering as per the resources plugin. This is a trivial patch but would duplicate the following code from the resources plugin:
> PropertyUtils
> ReflectionProperties
> ResourcesMojo.copyFile(File, File)
> These look like handy util methods that could be incorporated into plexus-utils - what do the developers think?
> Also not sure how resource filtering will be affected by MNG-788.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org