[jira] [Commented] (DRILL-4726) Dynamic UDFs support

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459284#comment-15459284 ] 

ASF GitHub Bot commented on DRILL-4726:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r77395331
  
    --- Diff: distribution/src/resources/drill-config.sh ---
    @@ -366,11 +366,18 @@ if [ $? -eq 0 ]; then
       fatal_error "Java 1.7 or later is required to run Apache Drill."
     fi
     
    +# Create Drill local udf area, if it does not exist
    +DRILL_UDF_DIR="$DRILL_HOME/udf"
    +if [[ ! -d "$DRILL_UDF_DIR" ]]; then
    +  mkdir -p "$DRILL_UDF_DIR"
    +fi
    +
    --- End diff --
    
    This should be $DRILL_CONF_DIR/udf, not $DRILL_HOME. $DRILL_CONF_DIR points to the user's "site" directory, which will be outside of $DRILL_HOME for Drill-on-YARN.
    
    Not sure we need to create this directory. The pattern followed elsewhere is to include the directory on the class path if it exists.
    
    In Drill-on-YARN, we CAN'T create the directory; the "localized" Drill and site directories are read-only.


> Dynamic UDFs support
> --------------------
>
>                 Key: DRILL-4726
>                 URL: https://issues.apache.org/jira/browse/DRILL-4726
>             Project: Apache Drill
>          Issue Type: New Feature
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>             Fix For: Future
>
>
> Allow register UDFs without  restart of Drillbits.
> Design is described in document below:
> https://docs.google.com/document/d/1FfyJtWae5TLuyheHCfldYUpCdeIezR2RlNsrOTYyAB4/edit?usp=sharing 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)