You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/03/29 14:47:55 UTC
[07/41] hbase-site git commit: Published site at
d8b550fabcacf3050583b514c4081adf5d087d65.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/2a4c7d89/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ZKWatcher.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ZKWatcher.html b/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ZKWatcher.html
index 6eadb58..d74aa78 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ZKWatcher.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ZKWatcher.html
@@ -124,507 +124,542 @@
<span class="sourceLineNo">116</span> public ZKWatcher(Configuration conf, String identifier,<a name="line.116"></a>
<span class="sourceLineNo">117</span> Abortable abortable, boolean canCreateBaseZNode)<a name="line.117"></a>
<span class="sourceLineNo">118</span> throws IOException, ZooKeeperConnectionException {<a name="line.118"></a>
-<span class="sourceLineNo">119</span> this.conf = conf;<a name="line.119"></a>
-<span class="sourceLineNo">120</span> this.quorum = ZKConfig.getZKQuorumServersString(conf);<a name="line.120"></a>
-<span class="sourceLineNo">121</span> this.prefix = identifier;<a name="line.121"></a>
-<span class="sourceLineNo">122</span> // Identifier will get the sessionid appended later below down when we<a name="line.122"></a>
-<span class="sourceLineNo">123</span> // handle the syncconnect event.<a name="line.123"></a>
-<span class="sourceLineNo">124</span> this.identifier = identifier + "0x0";<a name="line.124"></a>
-<span class="sourceLineNo">125</span> this.abortable = abortable;<a name="line.125"></a>
-<span class="sourceLineNo">126</span> this.znodePaths = new ZNodePaths(conf);<a name="line.126"></a>
-<span class="sourceLineNo">127</span> PendingWatcher pendingWatcher = new PendingWatcher();<a name="line.127"></a>
-<span class="sourceLineNo">128</span> this.recoverableZooKeeper = ZKUtil.connect(conf, quorum, pendingWatcher, identifier);<a name="line.128"></a>
-<span class="sourceLineNo">129</span> pendingWatcher.prepare(this);<a name="line.129"></a>
-<span class="sourceLineNo">130</span> if (canCreateBaseZNode) {<a name="line.130"></a>
-<span class="sourceLineNo">131</span> try {<a name="line.131"></a>
-<span class="sourceLineNo">132</span> createBaseZNodes();<a name="line.132"></a>
-<span class="sourceLineNo">133</span> } catch (ZooKeeperConnectionException zce) {<a name="line.133"></a>
-<span class="sourceLineNo">134</span> try {<a name="line.134"></a>
-<span class="sourceLineNo">135</span> this.recoverableZooKeeper.close();<a name="line.135"></a>
-<span class="sourceLineNo">136</span> } catch (InterruptedException ie) {<a name="line.136"></a>
-<span class="sourceLineNo">137</span> LOG.debug("Encountered InterruptedException when closing " + this.recoverableZooKeeper);<a name="line.137"></a>
-<span class="sourceLineNo">138</span> Thread.currentThread().interrupt();<a name="line.138"></a>
-<span class="sourceLineNo">139</span> }<a name="line.139"></a>
-<span class="sourceLineNo">140</span> throw zce;<a name="line.140"></a>
-<span class="sourceLineNo">141</span> }<a name="line.141"></a>
-<span class="sourceLineNo">142</span> }<a name="line.142"></a>
-<span class="sourceLineNo">143</span> }<a name="line.143"></a>
-<span class="sourceLineNo">144</span><a name="line.144"></a>
-<span class="sourceLineNo">145</span> private void createBaseZNodes() throws ZooKeeperConnectionException {<a name="line.145"></a>
-<span class="sourceLineNo">146</span> try {<a name="line.146"></a>
-<span class="sourceLineNo">147</span> // Create all the necessary "directories" of znodes<a name="line.147"></a>
-<span class="sourceLineNo">148</span> ZKUtil.createWithParents(this, znodePaths.baseZNode);<a name="line.148"></a>
-<span class="sourceLineNo">149</span> ZKUtil.createAndFailSilent(this, znodePaths.rsZNode);<a name="line.149"></a>
-<span class="sourceLineNo">150</span> ZKUtil.createAndFailSilent(this, znodePaths.drainingZNode);<a name="line.150"></a>
-<span class="sourceLineNo">151</span> ZKUtil.createAndFailSilent(this, znodePaths.tableZNode);<a name="line.151"></a>
-<span class="sourceLineNo">152</span> ZKUtil.createAndFailSilent(this, znodePaths.splitLogZNode);<a name="line.152"></a>
-<span class="sourceLineNo">153</span> ZKUtil.createAndFailSilent(this, znodePaths.backupMasterAddressesZNode);<a name="line.153"></a>
-<span class="sourceLineNo">154</span> ZKUtil.createAndFailSilent(this, znodePaths.tableLockZNode);<a name="line.154"></a>
-<span class="sourceLineNo">155</span> ZKUtil.createAndFailSilent(this, znodePaths.masterMaintZNode);<a name="line.155"></a>
-<span class="sourceLineNo">156</span> } catch (KeeperException e) {<a name="line.156"></a>
-<span class="sourceLineNo">157</span> throw new ZooKeeperConnectionException(<a name="line.157"></a>
-<span class="sourceLineNo">158</span> prefix("Unexpected KeeperException creating base node"), e);<a name="line.158"></a>
-<span class="sourceLineNo">159</span> }<a name="line.159"></a>
-<span class="sourceLineNo">160</span> }<a name="line.160"></a>
-<span class="sourceLineNo">161</span><a name="line.161"></a>
-<span class="sourceLineNo">162</span> /**<a name="line.162"></a>
-<span class="sourceLineNo">163</span> * On master start, we check the znode ACLs under the root directory and set the ACLs properly<a name="line.163"></a>
-<span class="sourceLineNo">164</span> * if needed. If the cluster goes from an unsecure setup to a secure setup, this step is needed<a name="line.164"></a>
-<span class="sourceLineNo">165</span> * so that the existing znodes created with open permissions are now changed with restrictive<a name="line.165"></a>
-<span class="sourceLineNo">166</span> * perms.<a name="line.166"></a>
-<span class="sourceLineNo">167</span> */<a name="line.167"></a>
-<span class="sourceLineNo">168</span> public void checkAndSetZNodeAcls() {<a name="line.168"></a>
-<span class="sourceLineNo">169</span> if (!ZKUtil.isSecureZooKeeper(getConfiguration())) {<a name="line.169"></a>
-<span class="sourceLineNo">170</span> LOG.info("not a secure deployment, proceeding");<a name="line.170"></a>
-<span class="sourceLineNo">171</span> return;<a name="line.171"></a>
-<span class="sourceLineNo">172</span> }<a name="line.172"></a>
-<span class="sourceLineNo">173</span><a name="line.173"></a>
-<span class="sourceLineNo">174</span> // Check the base znodes permission first. Only do the recursion if base znode's perms are not<a name="line.174"></a>
-<span class="sourceLineNo">175</span> // correct.<a name="line.175"></a>
-<span class="sourceLineNo">176</span> try {<a name="line.176"></a>
-<span class="sourceLineNo">177</span> List<ACL> actualAcls = recoverableZooKeeper.getAcl(znodePaths.baseZNode, new Stat());<a name="line.177"></a>
-<span class="sourceLineNo">178</span><a name="line.178"></a>
-<span class="sourceLineNo">179</span> if (!isBaseZnodeAclSetup(actualAcls)) {<a name="line.179"></a>
-<span class="sourceLineNo">180</span> LOG.info("setting znode ACLs");<a name="line.180"></a>
-<span class="sourceLineNo">181</span> setZnodeAclsRecursive(znodePaths.baseZNode);<a name="line.181"></a>
-<span class="sourceLineNo">182</span> }<a name="line.182"></a>
-<span class="sourceLineNo">183</span> } catch(KeeperException.NoNodeException nne) {<a name="line.183"></a>
-<span class="sourceLineNo">184</span> return;<a name="line.184"></a>
-<span class="sourceLineNo">185</span> } catch(InterruptedException ie) {<a name="line.185"></a>
-<span class="sourceLineNo">186</span> interruptedExceptionNoThrow(ie, false);<a name="line.186"></a>
-<span class="sourceLineNo">187</span> } catch (IOException|KeeperException e) {<a name="line.187"></a>
-<span class="sourceLineNo">188</span> LOG.warn("Received exception while checking and setting zookeeper ACLs", e);<a name="line.188"></a>
-<span class="sourceLineNo">189</span> }<a name="line.189"></a>
-<span class="sourceLineNo">190</span> }<a name="line.190"></a>
-<span class="sourceLineNo">191</span><a name="line.191"></a>
-<span class="sourceLineNo">192</span> /**<a name="line.192"></a>
-<span class="sourceLineNo">193</span> * Set the znode perms recursively. This will do post-order recursion, so that baseZnode ACLs<a name="line.193"></a>
-<span class="sourceLineNo">194</span> * will be set last in case the master fails in between.<a name="line.194"></a>
-<span class="sourceLineNo">195</span> * @param znode the ZNode to set the permissions for<a name="line.195"></a>
-<span class="sourceLineNo">196</span> */<a name="line.196"></a>
-<span class="sourceLineNo">197</span> private void setZnodeAclsRecursive(String znode) throws KeeperException, InterruptedException {<a name="line.197"></a>
-<span class="sourceLineNo">198</span> List<String> children = recoverableZooKeeper.getChildren(znode, false);<a name="line.198"></a>
-<span class="sourceLineNo">199</span><a name="line.199"></a>
-<span class="sourceLineNo">200</span> for (String child : children) {<a name="line.200"></a>
-<span class="sourceLineNo">201</span> setZnodeAclsRecursive(ZNodePaths.joinZNode(znode, child));<a name="line.201"></a>
-<span class="sourceLineNo">202</span> }<a name="line.202"></a>
-<span class="sourceLineNo">203</span> List<ACL> acls = ZKUtil.createACL(this, znode, true);<a name="line.203"></a>
-<span class="sourceLineNo">204</span> LOG.info("Setting ACLs for znode:" + znode + " , acl:" + acls);<a name="line.204"></a>
-<span class="sourceLineNo">205</span> recoverableZooKeeper.setAcl(znode, acls, -1);<a name="line.205"></a>
-<span class="sourceLineNo">206</span> }<a name="line.206"></a>
-<span class="sourceLineNo">207</span><a name="line.207"></a>
-<span class="sourceLineNo">208</span> /**<a name="line.208"></a>
-<span class="sourceLineNo">209</span> * Checks whether the ACLs returned from the base znode (/hbase) is set for secure setup.<a name="line.209"></a>
-<span class="sourceLineNo">210</span> * @param acls acls from zookeeper<a name="line.210"></a>
-<span class="sourceLineNo">211</span> * @return whether ACLs are set for the base znode<a name="line.211"></a>
-<span class="sourceLineNo">212</span> * @throws IOException if getting the current user fails<a name="line.212"></a>
-<span class="sourceLineNo">213</span> */<a name="line.213"></a>
-<span class="sourceLineNo">214</span> private boolean isBaseZnodeAclSetup(List<ACL> acls) throws IOException {<a name="line.214"></a>
-<span class="sourceLineNo">215</span> if (LOG.isDebugEnabled()) {<a name="line.215"></a>
-<span class="sourceLineNo">216</span> LOG.debug("Checking znode ACLs");<a name="line.216"></a>
-<span class="sourceLineNo">217</span> }<a name="line.217"></a>
-<span class="sourceLineNo">218</span> String[] superUsers = conf.getStrings(Superusers.SUPERUSER_CONF_KEY);<a name="line.218"></a>
-<span class="sourceLineNo">219</span> // Check whether ACL set for all superusers<a name="line.219"></a>
-<span class="sourceLineNo">220</span> if (superUsers != null && !checkACLForSuperUsers(superUsers, acls)) {<a name="line.220"></a>
-<span class="sourceLineNo">221</span> return false;<a name="line.221"></a>
-<span class="sourceLineNo">222</span> }<a name="line.222"></a>
-<span class="sourceLineNo">223</span><a name="line.223"></a>
-<span class="sourceLineNo">224</span> // this assumes that current authenticated user is the same as zookeeper client user<a name="line.224"></a>
-<span class="sourceLineNo">225</span> // configured via JAAS<a name="line.225"></a>
-<span class="sourceLineNo">226</span> String hbaseUser = UserGroupInformation.getCurrentUser().getShortUserName();<a name="line.226"></a>
-<span class="sourceLineNo">227</span><a name="line.227"></a>
-<span class="sourceLineNo">228</span> if (acls.isEmpty()) {<a name="line.228"></a>
-<span class="sourceLineNo">229</span> if (LOG.isDebugEnabled()) {<a name="line.229"></a>
-<span class="sourceLineNo">230</span> LOG.debug("ACL is empty");<a name="line.230"></a>
-<span class="sourceLineNo">231</span> }<a name="line.231"></a>
-<span class="sourceLineNo">232</span> return false;<a name="line.232"></a>
-<span class="sourceLineNo">233</span> }<a name="line.233"></a>
+<span class="sourceLineNo">119</span> this(conf, identifier, abortable, canCreateBaseZNode, false);<a name="line.119"></a>
+<span class="sourceLineNo">120</span> }<a name="line.120"></a>
+<span class="sourceLineNo">121</span><a name="line.121"></a>
+<span class="sourceLineNo">122</span> /**<a name="line.122"></a>
+<span class="sourceLineNo">123</span> * Instantiate a ZooKeeper connection and watcher.<a name="line.123"></a>
+<span class="sourceLineNo">124</span> * @param conf the configuration to use<a name="line.124"></a>
+<span class="sourceLineNo">125</span> * @param identifier string that is passed to RecoverableZookeeper to be used as identifier for<a name="line.125"></a>
+<span class="sourceLineNo">126</span> * this instance. Use null for default.<a name="line.126"></a>
+<span class="sourceLineNo">127</span> * @param abortable Can be null if there is on error there is no host to abort: e.g. client<a name="line.127"></a>
+<span class="sourceLineNo">128</span> * context.<a name="line.128"></a>
+<span class="sourceLineNo">129</span> * @param canCreateBaseZNode true if a base ZNode can be created<a name="line.129"></a>
+<span class="sourceLineNo">130</span> * @param clientZK whether this watcher is set to access client ZK<a name="line.130"></a>
+<span class="sourceLineNo">131</span> * @throws IOException if the connection to ZooKeeper fails<a name="line.131"></a>
+<span class="sourceLineNo">132</span> * @throws ZooKeeperConnectionException if the connection to Zookeeper fails when create base<a name="line.132"></a>
+<span class="sourceLineNo">133</span> * ZNodes<a name="line.133"></a>
+<span class="sourceLineNo">134</span> */<a name="line.134"></a>
+<span class="sourceLineNo">135</span> public ZKWatcher(Configuration conf, String identifier, Abortable abortable,<a name="line.135"></a>
+<span class="sourceLineNo">136</span> boolean canCreateBaseZNode, boolean clientZK)<a name="line.136"></a>
+<span class="sourceLineNo">137</span> throws IOException, ZooKeeperConnectionException {<a name="line.137"></a>
+<span class="sourceLineNo">138</span> this.conf = conf;<a name="line.138"></a>
+<span class="sourceLineNo">139</span> if (clientZK) {<a name="line.139"></a>
+<span class="sourceLineNo">140</span> String clientZkQuorumServers = ZKConfig.getClientZKQuorumServersString(conf);<a name="line.140"></a>
+<span class="sourceLineNo">141</span> String serverZkQuorumServers = ZKConfig.getZKQuorumServersString(conf);<a name="line.141"></a>
+<span class="sourceLineNo">142</span> if (clientZkQuorumServers != null) {<a name="line.142"></a>
+<span class="sourceLineNo">143</span> if (clientZkQuorumServers.equals(serverZkQuorumServers)) {<a name="line.143"></a>
+<span class="sourceLineNo">144</span> // Don't allow same settings to avoid dead loop when master trying<a name="line.144"></a>
+<span class="sourceLineNo">145</span> // to sync meta information from server ZK to client ZK<a name="line.145"></a>
+<span class="sourceLineNo">146</span> throw new IllegalArgumentException(<a name="line.146"></a>
+<span class="sourceLineNo">147</span> "The quorum settings for client ZK should be different from those for server");<a name="line.147"></a>
+<span class="sourceLineNo">148</span> }<a name="line.148"></a>
+<span class="sourceLineNo">149</span> this.quorum = clientZkQuorumServers;<a name="line.149"></a>
+<span class="sourceLineNo">150</span> } else {<a name="line.150"></a>
+<span class="sourceLineNo">151</span> this.quorum = serverZkQuorumServers;<a name="line.151"></a>
+<span class="sourceLineNo">152</span> }<a name="line.152"></a>
+<span class="sourceLineNo">153</span> } else {<a name="line.153"></a>
+<span class="sourceLineNo">154</span> this.quorum = ZKConfig.getZKQuorumServersString(conf);<a name="line.154"></a>
+<span class="sourceLineNo">155</span> }<a name="line.155"></a>
+<span class="sourceLineNo">156</span> this.prefix = identifier;<a name="line.156"></a>
+<span class="sourceLineNo">157</span> // Identifier will get the sessionid appended later below down when we<a name="line.157"></a>
+<span class="sourceLineNo">158</span> // handle the syncconnect event.<a name="line.158"></a>
+<span class="sourceLineNo">159</span> this.identifier = identifier + "0x0";<a name="line.159"></a>
+<span class="sourceLineNo">160</span> this.abortable = abortable;<a name="line.160"></a>
+<span class="sourceLineNo">161</span> this.znodePaths = new ZNodePaths(conf);<a name="line.161"></a>
+<span class="sourceLineNo">162</span> PendingWatcher pendingWatcher = new PendingWatcher();<a name="line.162"></a>
+<span class="sourceLineNo">163</span> this.recoverableZooKeeper = ZKUtil.connect(conf, quorum, pendingWatcher, identifier);<a name="line.163"></a>
+<span class="sourceLineNo">164</span> pendingWatcher.prepare(this);<a name="line.164"></a>
+<span class="sourceLineNo">165</span> if (canCreateBaseZNode) {<a name="line.165"></a>
+<span class="sourceLineNo">166</span> try {<a name="line.166"></a>
+<span class="sourceLineNo">167</span> createBaseZNodes();<a name="line.167"></a>
+<span class="sourceLineNo">168</span> } catch (ZooKeeperConnectionException zce) {<a name="line.168"></a>
+<span class="sourceLineNo">169</span> try {<a name="line.169"></a>
+<span class="sourceLineNo">170</span> this.recoverableZooKeeper.close();<a name="line.170"></a>
+<span class="sourceLineNo">171</span> } catch (InterruptedException ie) {<a name="line.171"></a>
+<span class="sourceLineNo">172</span> LOG.debug("Encountered InterruptedException when closing " + this.recoverableZooKeeper);<a name="line.172"></a>
+<span class="sourceLineNo">173</span> Thread.currentThread().interrupt();<a name="line.173"></a>
+<span class="sourceLineNo">174</span> }<a name="line.174"></a>
+<span class="sourceLineNo">175</span> throw zce;<a name="line.175"></a>
+<span class="sourceLineNo">176</span> }<a name="line.176"></a>
+<span class="sourceLineNo">177</span> }<a name="line.177"></a>
+<span class="sourceLineNo">178</span> }<a name="line.178"></a>
+<span class="sourceLineNo">179</span><a name="line.179"></a>
+<span class="sourceLineNo">180</span> private void createBaseZNodes() throws ZooKeeperConnectionException {<a name="line.180"></a>
+<span class="sourceLineNo">181</span> try {<a name="line.181"></a>
+<span class="sourceLineNo">182</span> // Create all the necessary "directories" of znodes<a name="line.182"></a>
+<span class="sourceLineNo">183</span> ZKUtil.createWithParents(this, znodePaths.baseZNode);<a name="line.183"></a>
+<span class="sourceLineNo">184</span> ZKUtil.createAndFailSilent(this, znodePaths.rsZNode);<a name="line.184"></a>
+<span class="sourceLineNo">185</span> ZKUtil.createAndFailSilent(this, znodePaths.drainingZNode);<a name="line.185"></a>
+<span class="sourceLineNo">186</span> ZKUtil.createAndFailSilent(this, znodePaths.tableZNode);<a name="line.186"></a>
+<span class="sourceLineNo">187</span> ZKUtil.createAndFailSilent(this, znodePaths.splitLogZNode);<a name="line.187"></a>
+<span class="sourceLineNo">188</span> ZKUtil.createAndFailSilent(this, znodePaths.backupMasterAddressesZNode);<a name="line.188"></a>
+<span class="sourceLineNo">189</span> ZKUtil.createAndFailSilent(this, znodePaths.tableLockZNode);<a name="line.189"></a>
+<span class="sourceLineNo">190</span> ZKUtil.createAndFailSilent(this, znodePaths.masterMaintZNode);<a name="line.190"></a>
+<span class="sourceLineNo">191</span> } catch (KeeperException e) {<a name="line.191"></a>
+<span class="sourceLineNo">192</span> throw new ZooKeeperConnectionException(<a name="line.192"></a>
+<span class="sourceLineNo">193</span> prefix("Unexpected KeeperException creating base node"), e);<a name="line.193"></a>
+<span class="sourceLineNo">194</span> }<a name="line.194"></a>
+<span class="sourceLineNo">195</span> }<a name="line.195"></a>
+<span class="sourceLineNo">196</span><a name="line.196"></a>
+<span class="sourceLineNo">197</span> /**<a name="line.197"></a>
+<span class="sourceLineNo">198</span> * On master start, we check the znode ACLs under the root directory and set the ACLs properly<a name="line.198"></a>
+<span class="sourceLineNo">199</span> * if needed. If the cluster goes from an unsecure setup to a secure setup, this step is needed<a name="line.199"></a>
+<span class="sourceLineNo">200</span> * so that the existing znodes created with open permissions are now changed with restrictive<a name="line.200"></a>
+<span class="sourceLineNo">201</span> * perms.<a name="line.201"></a>
+<span class="sourceLineNo">202</span> */<a name="line.202"></a>
+<span class="sourceLineNo">203</span> public void checkAndSetZNodeAcls() {<a name="line.203"></a>
+<span class="sourceLineNo">204</span> if (!ZKUtil.isSecureZooKeeper(getConfiguration())) {<a name="line.204"></a>
+<span class="sourceLineNo">205</span> LOG.info("not a secure deployment, proceeding");<a name="line.205"></a>
+<span class="sourceLineNo">206</span> return;<a name="line.206"></a>
+<span class="sourceLineNo">207</span> }<a name="line.207"></a>
+<span class="sourceLineNo">208</span><a name="line.208"></a>
+<span class="sourceLineNo">209</span> // Check the base znodes permission first. Only do the recursion if base znode's perms are not<a name="line.209"></a>
+<span class="sourceLineNo">210</span> // correct.<a name="line.210"></a>
+<span class="sourceLineNo">211</span> try {<a name="line.211"></a>
+<span class="sourceLineNo">212</span> List<ACL> actualAcls = recoverableZooKeeper.getAcl(znodePaths.baseZNode, new Stat());<a name="line.212"></a>
+<span class="sourceLineNo">213</span><a name="line.213"></a>
+<span class="sourceLineNo">214</span> if (!isBaseZnodeAclSetup(actualAcls)) {<a name="line.214"></a>
+<span class="sourceLineNo">215</span> LOG.info("setting znode ACLs");<a name="line.215"></a>
+<span class="sourceLineNo">216</span> setZnodeAclsRecursive(znodePaths.baseZNode);<a name="line.216"></a>
+<span class="sourceLineNo">217</span> }<a name="line.217"></a>
+<span class="sourceLineNo">218</span> } catch(KeeperException.NoNodeException nne) {<a name="line.218"></a>
+<span class="sourceLineNo">219</span> return;<a name="line.219"></a>
+<span class="sourceLineNo">220</span> } catch(InterruptedException ie) {<a name="line.220"></a>
+<span class="sourceLineNo">221</span> interruptedExceptionNoThrow(ie, false);<a name="line.221"></a>
+<span class="sourceLineNo">222</span> } catch (IOException|KeeperException e) {<a name="line.222"></a>
+<span class="sourceLineNo">223</span> LOG.warn("Received exception while checking and setting zookeeper ACLs", e);<a name="line.223"></a>
+<span class="sourceLineNo">224</span> }<a name="line.224"></a>
+<span class="sourceLineNo">225</span> }<a name="line.225"></a>
+<span class="sourceLineNo">226</span><a name="line.226"></a>
+<span class="sourceLineNo">227</span> /**<a name="line.227"></a>
+<span class="sourceLineNo">228</span> * Set the znode perms recursively. This will do post-order recursion, so that baseZnode ACLs<a name="line.228"></a>
+<span class="sourceLineNo">229</span> * will be set last in case the master fails in between.<a name="line.229"></a>
+<span class="sourceLineNo">230</span> * @param znode the ZNode to set the permissions for<a name="line.230"></a>
+<span class="sourceLineNo">231</span> */<a name="line.231"></a>
+<span class="sourceLineNo">232</span> private void setZnodeAclsRecursive(String znode) throws KeeperException, InterruptedException {<a name="line.232"></a>
+<span class="sourceLineNo">233</span> List<String> children = recoverableZooKeeper.getChildren(znode, false);<a name="line.233"></a>
<span class="sourceLineNo">234</span><a name="line.234"></a>
-<span class="sourceLineNo">235</span> for (ACL acl : acls) {<a name="line.235"></a>
-<span class="sourceLineNo">236</span> int perms = acl.getPerms();<a name="line.236"></a>
-<span class="sourceLineNo">237</span> Id id = acl.getId();<a name="line.237"></a>
-<span class="sourceLineNo">238</span> // We should only set at most 3 possible ACLs for 3 Ids. One for everyone, one for superuser<a name="line.238"></a>
-<span class="sourceLineNo">239</span> // and one for the hbase user<a name="line.239"></a>
-<span class="sourceLineNo">240</span> if (Ids.ANYONE_ID_UNSAFE.equals(id)) {<a name="line.240"></a>
-<span class="sourceLineNo">241</span> if (perms != Perms.READ) {<a name="line.241"></a>
-<span class="sourceLineNo">242</span> if (LOG.isDebugEnabled()) {<a name="line.242"></a>
-<span class="sourceLineNo">243</span> LOG.debug(String.format("permissions for '%s' are not correct: have 0x%x, want 0x%x",<a name="line.243"></a>
-<span class="sourceLineNo">244</span> id, perms, Perms.READ));<a name="line.244"></a>
-<span class="sourceLineNo">245</span> }<a name="line.245"></a>
-<span class="sourceLineNo">246</span> return false;<a name="line.246"></a>
-<span class="sourceLineNo">247</span> }<a name="line.247"></a>
-<span class="sourceLineNo">248</span> } else if (superUsers != null && isSuperUserId(superUsers, id)) {<a name="line.248"></a>
-<span class="sourceLineNo">249</span> if (perms != Perms.ALL) {<a name="line.249"></a>
-<span class="sourceLineNo">250</span> if (LOG.isDebugEnabled()) {<a name="line.250"></a>
-<span class="sourceLineNo">251</span> LOG.debug(String.format("permissions for '%s' are not correct: have 0x%x, want 0x%x",<a name="line.251"></a>
-<span class="sourceLineNo">252</span> id, perms, Perms.ALL));<a name="line.252"></a>
-<span class="sourceLineNo">253</span> }<a name="line.253"></a>
-<span class="sourceLineNo">254</span> return false;<a name="line.254"></a>
-<span class="sourceLineNo">255</span> }<a name="line.255"></a>
-<span class="sourceLineNo">256</span> } else if ("sasl".equals(id.getScheme())) {<a name="line.256"></a>
-<span class="sourceLineNo">257</span> String name = id.getId();<a name="line.257"></a>
-<span class="sourceLineNo">258</span> // If ZooKeeper recorded the Kerberos full name in the ACL, use only the shortname<a name="line.258"></a>
-<span class="sourceLineNo">259</span> Matcher match = NAME_PATTERN.matcher(name);<a name="line.259"></a>
-<span class="sourceLineNo">260</span> if (match.matches()) {<a name="line.260"></a>
-<span class="sourceLineNo">261</span> name = match.group(1);<a name="line.261"></a>
-<span class="sourceLineNo">262</span> }<a name="line.262"></a>
-<span class="sourceLineNo">263</span> if (name.equals(hbaseUser)) {<a name="line.263"></a>
-<span class="sourceLineNo">264</span> if (perms != Perms.ALL) {<a name="line.264"></a>
-<span class="sourceLineNo">265</span> if (LOG.isDebugEnabled()) {<a name="line.265"></a>
-<span class="sourceLineNo">266</span> LOG.debug(String.format("permissions for '%s' are not correct: have 0x%x, want 0x%x",<a name="line.266"></a>
-<span class="sourceLineNo">267</span> id, perms, Perms.ALL));<a name="line.267"></a>
-<span class="sourceLineNo">268</span> }<a name="line.268"></a>
-<span class="sourceLineNo">269</span> return false;<a name="line.269"></a>
-<span class="sourceLineNo">270</span> }<a name="line.270"></a>
-<span class="sourceLineNo">271</span> } else {<a name="line.271"></a>
-<span class="sourceLineNo">272</span> if (LOG.isDebugEnabled()) {<a name="line.272"></a>
-<span class="sourceLineNo">273</span> LOG.debug("Unexpected shortname in SASL ACL: " + id);<a name="line.273"></a>
-<span class="sourceLineNo">274</span> }<a name="line.274"></a>
-<span class="sourceLineNo">275</span> return false;<a name="line.275"></a>
-<span class="sourceLineNo">276</span> }<a name="line.276"></a>
-<span class="sourceLineNo">277</span> } else {<a name="line.277"></a>
-<span class="sourceLineNo">278</span> if (LOG.isDebugEnabled()) {<a name="line.278"></a>
-<span class="sourceLineNo">279</span> LOG.debug("unexpected ACL id '" + id + "'");<a name="line.279"></a>
-<span class="sourceLineNo">280</span> }<a name="line.280"></a>
-<span class="sourceLineNo">281</span> return false;<a name="line.281"></a>
-<span class="sourceLineNo">282</span> }<a name="line.282"></a>
-<span class="sourceLineNo">283</span> }<a name="line.283"></a>
-<span class="sourceLineNo">284</span> return true;<a name="line.284"></a>
-<span class="sourceLineNo">285</span> }<a name="line.285"></a>
-<span class="sourceLineNo">286</span><a name="line.286"></a>
-<span class="sourceLineNo">287</span> /*<a name="line.287"></a>
-<span class="sourceLineNo">288</span> * Validate whether ACL set for all superusers.<a name="line.288"></a>
-<span class="sourceLineNo">289</span> */<a name="line.289"></a>
-<span class="sourceLineNo">290</span> private boolean checkACLForSuperUsers(String[] superUsers, List<ACL> acls) {<a name="line.290"></a>
-<span class="sourceLineNo">291</span> for (String user : superUsers) {<a name="line.291"></a>
-<span class="sourceLineNo">292</span> boolean hasAccess = false;<a name="line.292"></a>
-<span class="sourceLineNo">293</span> // TODO: Validate super group members also when ZK supports setting node ACL for groups.<a name="line.293"></a>
-<span class="sourceLineNo">294</span> if (!AuthUtil.isGroupPrincipal(user)) {<a name="line.294"></a>
-<span class="sourceLineNo">295</span> for (ACL acl : acls) {<a name="line.295"></a>
-<span class="sourceLineNo">296</span> if (user.equals(acl.getId().getId())) {<a name="line.296"></a>
-<span class="sourceLineNo">297</span> if (acl.getPerms() == Perms.ALL) {<a name="line.297"></a>
-<span class="sourceLineNo">298</span> hasAccess = true;<a name="line.298"></a>
-<span class="sourceLineNo">299</span> } else {<a name="line.299"></a>
-<span class="sourceLineNo">300</span> if (LOG.isDebugEnabled()) {<a name="line.300"></a>
-<span class="sourceLineNo">301</span> LOG.debug(String.format(<a name="line.301"></a>
-<span class="sourceLineNo">302</span> "superuser '%s' does not have correct permissions: have 0x%x, want 0x%x",<a name="line.302"></a>
-<span class="sourceLineNo">303</span> acl.getId().getId(), acl.getPerms(), Perms.ALL));<a name="line.303"></a>
-<span class="sourceLineNo">304</span> }<a name="line.304"></a>
-<span class="sourceLineNo">305</span> }<a name="line.305"></a>
-<span class="sourceLineNo">306</span> break;<a name="line.306"></a>
-<span class="sourceLineNo">307</span> }<a name="line.307"></a>
-<span class="sourceLineNo">308</span> }<a name="line.308"></a>
-<span class="sourceLineNo">309</span> if (!hasAccess) {<a name="line.309"></a>
+<span class="sourceLineNo">235</span> for (String child : children) {<a name="line.235"></a>
+<span class="sourceLineNo">236</span> setZnodeAclsRecursive(ZNodePaths.joinZNode(znode, child));<a name="line.236"></a>
+<span class="sourceLineNo">237</span> }<a name="line.237"></a>
+<span class="sourceLineNo">238</span> List<ACL> acls = ZKUtil.createACL(this, znode, true);<a name="line.238"></a>
+<span class="sourceLineNo">239</span> LOG.info("Setting ACLs for znode:" + znode + " , acl:" + acls);<a name="line.239"></a>
+<span class="sourceLineNo">240</span> recoverableZooKeeper.setAcl(znode, acls, -1);<a name="line.240"></a>
+<span class="sourceLineNo">241</span> }<a name="line.241"></a>
+<span class="sourceLineNo">242</span><a name="line.242"></a>
+<span class="sourceLineNo">243</span> /**<a name="line.243"></a>
+<span class="sourceLineNo">244</span> * Checks whether the ACLs returned from the base znode (/hbase) is set for secure setup.<a name="line.244"></a>
+<span class="sourceLineNo">245</span> * @param acls acls from zookeeper<a name="line.245"></a>
+<span class="sourceLineNo">246</span> * @return whether ACLs are set for the base znode<a name="line.246"></a>
+<span class="sourceLineNo">247</span> * @throws IOException if getting the current user fails<a name="line.247"></a>
+<span class="sourceLineNo">248</span> */<a name="line.248"></a>
+<span class="sourceLineNo">249</span> private boolean isBaseZnodeAclSetup(List<ACL> acls) throws IOException {<a name="line.249"></a>
+<span class="sourceLineNo">250</span> if (LOG.isDebugEnabled()) {<a name="line.250"></a>
+<span class="sourceLineNo">251</span> LOG.debug("Checking znode ACLs");<a name="line.251"></a>
+<span class="sourceLineNo">252</span> }<a name="line.252"></a>
+<span class="sourceLineNo">253</span> String[] superUsers = conf.getStrings(Superusers.SUPERUSER_CONF_KEY);<a name="line.253"></a>
+<span class="sourceLineNo">254</span> // Check whether ACL set for all superusers<a name="line.254"></a>
+<span class="sourceLineNo">255</span> if (superUsers != null && !checkACLForSuperUsers(superUsers, acls)) {<a name="line.255"></a>
+<span class="sourceLineNo">256</span> return false;<a name="line.256"></a>
+<span class="sourceLineNo">257</span> }<a name="line.257"></a>
+<span class="sourceLineNo">258</span><a name="line.258"></a>
+<span class="sourceLineNo">259</span> // this assumes that current authenticated user is the same as zookeeper client user<a name="line.259"></a>
+<span class="sourceLineNo">260</span> // configured via JAAS<a name="line.260"></a>
+<span class="sourceLineNo">261</span> String hbaseUser = UserGroupInformation.getCurrentUser().getShortUserName();<a name="line.261"></a>
+<span class="sourceLineNo">262</span><a name="line.262"></a>
+<span class="sourceLineNo">263</span> if (acls.isEmpty()) {<a name="line.263"></a>
+<span class="sourceLineNo">264</span> if (LOG.isDebugEnabled()) {<a name="line.264"></a>
+<span class="sourceLineNo">265</span> LOG.debug("ACL is empty");<a name="line.265"></a>
+<span class="sourceLineNo">266</span> }<a name="line.266"></a>
+<span class="sourceLineNo">267</span> return false;<a name="line.267"></a>
+<span class="sourceLineNo">268</span> }<a name="line.268"></a>
+<span class="sourceLineNo">269</span><a name="line.269"></a>
+<span class="sourceLineNo">270</span> for (ACL acl : acls) {<a name="line.270"></a>
+<span class="sourceLineNo">271</span> int perms = acl.getPerms();<a name="line.271"></a>
+<span class="sourceLineNo">272</span> Id id = acl.getId();<a name="line.272"></a>
+<span class="sourceLineNo">273</span> // We should only set at most 3 possible ACLs for 3 Ids. One for everyone, one for superuser<a name="line.273"></a>
+<span class="sourceLineNo">274</span> // and one for the hbase user<a name="line.274"></a>
+<span class="sourceLineNo">275</span> if (Ids.ANYONE_ID_UNSAFE.equals(id)) {<a name="line.275"></a>
+<span class="sourceLineNo">276</span> if (perms != Perms.READ) {<a name="line.276"></a>
+<span class="sourceLineNo">277</span> if (LOG.isDebugEnabled()) {<a name="line.277"></a>
+<span class="sourceLineNo">278</span> LOG.debug(String.format("permissions for '%s' are not correct: have 0x%x, want 0x%x",<a name="line.278"></a>
+<span class="sourceLineNo">279</span> id, perms, Perms.READ));<a name="line.279"></a>
+<span class="sourceLineNo">280</span> }<a name="line.280"></a>
+<span class="sourceLineNo">281</span> return false;<a name="line.281"></a>
+<span class="sourceLineNo">282</span> }<a name="line.282"></a>
+<span class="sourceLineNo">283</span> } else if (superUsers != null && isSuperUserId(superUsers, id)) {<a name="line.283"></a>
+<span class="sourceLineNo">284</span> if (perms != Perms.ALL) {<a name="line.284"></a>
+<span class="sourceLineNo">285</span> if (LOG.isDebugEnabled()) {<a name="line.285"></a>
+<span class="sourceLineNo">286</span> LOG.debug(String.format("permissions for '%s' are not correct: have 0x%x, want 0x%x",<a name="line.286"></a>
+<span class="sourceLineNo">287</span> id, perms, Perms.ALL));<a name="line.287"></a>
+<span class="sourceLineNo">288</span> }<a name="line.288"></a>
+<span class="sourceLineNo">289</span> return false;<a name="line.289"></a>
+<span class="sourceLineNo">290</span> }<a name="line.290"></a>
+<span class="sourceLineNo">291</span> } else if ("sasl".equals(id.getScheme())) {<a name="line.291"></a>
+<span class="sourceLineNo">292</span> String name = id.getId();<a name="line.292"></a>
+<span class="sourceLineNo">293</span> // If ZooKeeper recorded the Kerberos full name in the ACL, use only the shortname<a name="line.293"></a>
+<span class="sourceLineNo">294</span> Matcher match = NAME_PATTERN.matcher(name);<a name="line.294"></a>
+<span class="sourceLineNo">295</span> if (match.matches()) {<a name="line.295"></a>
+<span class="sourceLineNo">296</span> name = match.group(1);<a name="line.296"></a>
+<span class="sourceLineNo">297</span> }<a name="line.297"></a>
+<span class="sourceLineNo">298</span> if (name.equals(hbaseUser)) {<a name="line.298"></a>
+<span class="sourceLineNo">299</span> if (perms != Perms.ALL) {<a name="line.299"></a>
+<span class="sourceLineNo">300</span> if (LOG.isDebugEnabled()) {<a name="line.300"></a>
+<span class="sourceLineNo">301</span> LOG.debug(String.format("permissions for '%s' are not correct: have 0x%x, want 0x%x",<a name="line.301"></a>
+<span class="sourceLineNo">302</span> id, perms, Perms.ALL));<a name="line.302"></a>
+<span class="sourceLineNo">303</span> }<a name="line.303"></a>
+<span class="sourceLineNo">304</span> return false;<a name="line.304"></a>
+<span class="sourceLineNo">305</span> }<a name="line.305"></a>
+<span class="sourceLineNo">306</span> } else {<a name="line.306"></a>
+<span class="sourceLineNo">307</span> if (LOG.isDebugEnabled()) {<a name="line.307"></a>
+<span class="sourceLineNo">308</span> LOG.debug("Unexpected shortname in SASL ACL: " + id);<a name="line.308"></a>
+<span class="sourceLineNo">309</span> }<a name="line.309"></a>
<span class="sourceLineNo">310</span> return false;<a name="line.310"></a>
<span class="sourceLineNo">311</span> }<a name="line.311"></a>
-<span class="sourceLineNo">312</span> }<a name="line.312"></a>
-<span class="sourceLineNo">313</span> }<a name="line.313"></a>
-<span class="sourceLineNo">314</span> return true;<a name="line.314"></a>
-<span class="sourceLineNo">315</span> }<a name="line.315"></a>
-<span class="sourceLineNo">316</span><a name="line.316"></a>
-<span class="sourceLineNo">317</span> /*<a name="line.317"></a>
-<span class="sourceLineNo">318</span> * Validate whether ACL ID is superuser.<a name="line.318"></a>
-<span class="sourceLineNo">319</span> */<a name="line.319"></a>
-<span class="sourceLineNo">320</span> public static boolean isSuperUserId(String[] superUsers, Id id) {<a name="line.320"></a>
-<span class="sourceLineNo">321</span> for (String user : superUsers) {<a name="line.321"></a>
-<span class="sourceLineNo">322</span> // TODO: Validate super group members also when ZK supports setting node ACL for groups.<a name="line.322"></a>
-<span class="sourceLineNo">323</span> if (!AuthUtil.isGroupPrincipal(user) && new Id("sasl", user).equals(id)) {<a name="line.323"></a>
-<span class="sourceLineNo">324</span> return true;<a name="line.324"></a>
-<span class="sourceLineNo">325</span> }<a name="line.325"></a>
-<span class="sourceLineNo">326</span> }<a name="line.326"></a>
-<span class="sourceLineNo">327</span> return false;<a name="line.327"></a>
-<span class="sourceLineNo">328</span> }<a name="line.328"></a>
-<span class="sourceLineNo">329</span><a name="line.329"></a>
-<span class="sourceLineNo">330</span> @Override<a name="line.330"></a>
-<span class="sourceLineNo">331</span> public String toString() {<a name="line.331"></a>
-<span class="sourceLineNo">332</span> return this.identifier + ", quorum=" + quorum + ", baseZNode=" + znodePaths.baseZNode;<a name="line.332"></a>
-<span class="sourceLineNo">333</span> }<a name="line.333"></a>
-<span class="sourceLineNo">334</span><a name="line.334"></a>
-<span class="sourceLineNo">335</span> /**<a name="line.335"></a>
-<span class="sourceLineNo">336</span> * Adds this instance's identifier as a prefix to the passed <code>str</code><a name="line.336"></a>
-<span class="sourceLineNo">337</span> * @param str String to amend.<a name="line.337"></a>
-<span class="sourceLineNo">338</span> * @return A new string with this instance's identifier as prefix: e.g.<a name="line.338"></a>
-<span class="sourceLineNo">339</span> * if passed 'hello world', the returned string could be<a name="line.339"></a>
-<span class="sourceLineNo">340</span> */<a name="line.340"></a>
-<span class="sourceLineNo">341</span> public String prefix(final String str) {<a name="line.341"></a>
-<span class="sourceLineNo">342</span> return this.toString() + " " + str;<a name="line.342"></a>
-<span class="sourceLineNo">343</span> }<a name="line.343"></a>
-<span class="sourceLineNo">344</span><a name="line.344"></a>
-<span class="sourceLineNo">345</span> /**<a name="line.345"></a>
-<span class="sourceLineNo">346</span> * Get the znodes corresponding to the meta replicas from ZK<a name="line.346"></a>
-<span class="sourceLineNo">347</span> * @return list of znodes<a name="line.347"></a>
-<span class="sourceLineNo">348</span> * @throws KeeperException if a ZooKeeper operation fails<a name="line.348"></a>
-<span class="sourceLineNo">349</span> */<a name="line.349"></a>
-<span class="sourceLineNo">350</span> public List<String> getMetaReplicaNodes() throws KeeperException {<a name="line.350"></a>
-<span class="sourceLineNo">351</span> List<String> childrenOfBaseNode = ZKUtil.listChildrenNoWatch(this, znodePaths.baseZNode);<a name="line.351"></a>
-<span class="sourceLineNo">352</span> List<String> metaReplicaNodes = new ArrayList<>(2);<a name="line.352"></a>
-<span class="sourceLineNo">353</span> if (childrenOfBaseNode != null) {<a name="line.353"></a>
-<span class="sourceLineNo">354</span> String pattern = conf.get("zookeeper.znode.metaserver","meta-region-server");<a name="line.354"></a>
-<span class="sourceLineNo">355</span> for (String child : childrenOfBaseNode) {<a name="line.355"></a>
-<span class="sourceLineNo">356</span> if (child.startsWith(pattern)) {<a name="line.356"></a>
-<span class="sourceLineNo">357</span> metaReplicaNodes.add(child);<a name="line.357"></a>
-<span class="sourceLineNo">358</span> }<a name="line.358"></a>
-<span class="sourceLineNo">359</span> }<a name="line.359"></a>
-<span class="sourceLineNo">360</span> }<a name="line.360"></a>
-<span class="sourceLineNo">361</span> return metaReplicaNodes;<a name="line.361"></a>
-<span class="sourceLineNo">362</span> }<a name="line.362"></a>
-<span class="sourceLineNo">363</span><a name="line.363"></a>
-<span class="sourceLineNo">364</span> /**<a name="line.364"></a>
-<span class="sourceLineNo">365</span> * Register the specified listener to receive ZooKeeper events.<a name="line.365"></a>
-<span class="sourceLineNo">366</span> * @param listener the listener to register<a name="line.366"></a>
-<span class="sourceLineNo">367</span> */<a name="line.367"></a>
-<span class="sourceLineNo">368</span> public void registerListener(ZKListener listener) {<a name="line.368"></a>
-<span class="sourceLineNo">369</span> listeners.add(listener);<a name="line.369"></a>
-<span class="sourceLineNo">370</span> }<a name="line.370"></a>
-<span class="sourceLineNo">371</span><a name="line.371"></a>
-<span class="sourceLineNo">372</span> /**<a name="line.372"></a>
-<span class="sourceLineNo">373</span> * Register the specified listener to receive ZooKeeper events and add it as<a name="line.373"></a>
-<span class="sourceLineNo">374</span> * the first in the list of current listeners.<a name="line.374"></a>
-<span class="sourceLineNo">375</span> * @param listener the listener to register<a name="line.375"></a>
-<span class="sourceLineNo">376</span> */<a name="line.376"></a>
-<span class="sourceLineNo">377</span> public void registerListenerFirst(ZKListener listener) {<a name="line.377"></a>
-<span class="sourceLineNo">378</span> listeners.add(0, listener);<a name="line.378"></a>
-<span class="sourceLineNo">379</span> }<a name="line.379"></a>
-<span class="sourceLineNo">380</span><a name="line.380"></a>
-<span class="sourceLineNo">381</span> public void unregisterListener(ZKListener listener) {<a name="line.381"></a>
-<span class="sourceLineNo">382</span> listeners.remove(listener);<a name="line.382"></a>
-<span class="sourceLineNo">383</span> }<a name="line.383"></a>
-<span class="sourceLineNo">384</span><a name="line.384"></a>
-<span class="sourceLineNo">385</span> /**<a name="line.385"></a>
-<span class="sourceLineNo">386</span> * Clean all existing listeners<a name="line.386"></a>
-<span class="sourceLineNo">387</span> */<a name="line.387"></a>
-<span class="sourceLineNo">388</span> public void unregisterAllListeners() {<a name="line.388"></a>
-<span class="sourceLineNo">389</span> listeners.clear();<a name="line.389"></a>
-<span class="sourceLineNo">390</span> }<a name="line.390"></a>
-<span class="sourceLineNo">391</span><a name="line.391"></a>
-<span class="sourceLineNo">392</span> /**<a name="line.392"></a>
-<span class="sourceLineNo">393</span> * Get a copy of current registered listeners<a name="line.393"></a>
-<span class="sourceLineNo">394</span> */<a name="line.394"></a>
-<span class="sourceLineNo">395</span> public List<ZKListener> getListeners() {<a name="line.395"></a>
-<span class="sourceLineNo">396</span> return new ArrayList<>(listeners);<a name="line.396"></a>
+<span class="sourceLineNo">312</span> } else {<a name="line.312"></a>
+<span class="sourceLineNo">313</span> if (LOG.isDebugEnabled()) {<a name="line.313"></a>
+<span class="sourceLineNo">314</span> LOG.debug("unexpected ACL id '" + id + "'");<a name="line.314"></a>
+<span class="sourceLineNo">315</span> }<a name="line.315"></a>
+<span class="sourceLineNo">316</span> return false;<a name="line.316"></a>
+<span class="sourceLineNo">317</span> }<a name="line.317"></a>
+<span class="sourceLineNo">318</span> }<a name="line.318"></a>
+<span class="sourceLineNo">319</span> return true;<a name="line.319"></a>
+<span class="sourceLineNo">320</span> }<a name="line.320"></a>
+<span class="sourceLineNo">321</span><a name="line.321"></a>
+<span class="sourceLineNo">322</span> /*<a name="line.322"></a>
+<span class="sourceLineNo">323</span> * Validate whether ACL set for all superusers.<a name="line.323"></a>
+<span class="sourceLineNo">324</span> */<a name="line.324"></a>
+<span class="sourceLineNo">325</span> private boolean checkACLForSuperUsers(String[] superUsers, List<ACL> acls) {<a name="line.325"></a>
+<span class="sourceLineNo">326</span> for (String user : superUsers) {<a name="line.326"></a>
+<span class="sourceLineNo">327</span> boolean hasAccess = false;<a name="line.327"></a>
+<span class="sourceLineNo">328</span> // TODO: Validate super group members also when ZK supports setting node ACL for groups.<a name="line.328"></a>
+<span class="sourceLineNo">329</span> if (!AuthUtil.isGroupPrincipal(user)) {<a name="line.329"></a>
+<span class="sourceLineNo">330</span> for (ACL acl : acls) {<a name="line.330"></a>
+<span class="sourceLineNo">331</span> if (user.equals(acl.getId().getId())) {<a name="line.331"></a>
+<span class="sourceLineNo">332</span> if (acl.getPerms() == Perms.ALL) {<a name="line.332"></a>
+<span class="sourceLineNo">333</span> hasAccess = true;<a name="line.333"></a>
+<span class="sourceLineNo">334</span> } else {<a name="line.334"></a>
+<span class="sourceLineNo">335</span> if (LOG.isDebugEnabled()) {<a name="line.335"></a>
+<span class="sourceLineNo">336</span> LOG.debug(String.format(<a name="line.336"></a>
+<span class="sourceLineNo">337</span> "superuser '%s' does not have correct permissions: have 0x%x, want 0x%x",<a name="line.337"></a>
+<span class="sourceLineNo">338</span> acl.getId().getId(), acl.getPerms(), Perms.ALL));<a name="line.338"></a>
+<span class="sourceLineNo">339</span> }<a name="line.339"></a>
+<span class="sourceLineNo">340</span> }<a name="line.340"></a>
+<span class="sourceLineNo">341</span> break;<a name="line.341"></a>
+<span class="sourceLineNo">342</span> }<a name="line.342"></a>
+<span class="sourceLineNo">343</span> }<a name="line.343"></a>
+<span class="sourceLineNo">344</span> if (!hasAccess) {<a name="line.344"></a>
+<span class="sourceLineNo">345</span> return false;<a name="line.345"></a>
+<span class="sourceLineNo">346</span> }<a name="line.346"></a>
+<span class="sourceLineNo">347</span> }<a name="line.347"></a>
+<span class="sourceLineNo">348</span> }<a name="line.348"></a>
+<span class="sourceLineNo">349</span> return true;<a name="line.349"></a>
+<span class="sourceLineNo">350</span> }<a name="line.350"></a>
+<span class="sourceLineNo">351</span><a name="line.351"></a>
+<span class="sourceLineNo">352</span> /*<a name="line.352"></a>
+<span class="sourceLineNo">353</span> * Validate whether ACL ID is superuser.<a name="line.353"></a>
+<span class="sourceLineNo">354</span> */<a name="line.354"></a>
+<span class="sourceLineNo">355</span> public static boolean isSuperUserId(String[] superUsers, Id id) {<a name="line.355"></a>
+<span class="sourceLineNo">356</span> for (String user : superUsers) {<a name="line.356"></a>
+<span class="sourceLineNo">357</span> // TODO: Validate super group members also when ZK supports setting node ACL for groups.<a name="line.357"></a>
+<span class="sourceLineNo">358</span> if (!AuthUtil.isGroupPrincipal(user) && new Id("sasl", user).equals(id)) {<a name="line.358"></a>
+<span class="sourceLineNo">359</span> return true;<a name="line.359"></a>
+<span class="sourceLineNo">360</span> }<a name="line.360"></a>
+<span class="sourceLineNo">361</span> }<a name="line.361"></a>
+<span class="sourceLineNo">362</span> return false;<a name="line.362"></a>
+<span class="sourceLineNo">363</span> }<a name="line.363"></a>
+<span class="sourceLineNo">364</span><a name="line.364"></a>
+<span class="sourceLineNo">365</span> @Override<a name="line.365"></a>
+<span class="sourceLineNo">366</span> public String toString() {<a name="line.366"></a>
+<span class="sourceLineNo">367</span> return this.identifier + ", quorum=" + quorum + ", baseZNode=" + znodePaths.baseZNode;<a name="line.367"></a>
+<span class="sourceLineNo">368</span> }<a name="line.368"></a>
+<span class="sourceLineNo">369</span><a name="line.369"></a>
+<span class="sourceLineNo">370</span> /**<a name="line.370"></a>
+<span class="sourceLineNo">371</span> * Adds this instance's identifier as a prefix to the passed <code>str</code><a name="line.371"></a>
+<span class="sourceLineNo">372</span> * @param str String to amend.<a name="line.372"></a>
+<span class="sourceLineNo">373</span> * @return A new string with this instance's identifier as prefix: e.g.<a name="line.373"></a>
+<span class="sourceLineNo">374</span> * if passed 'hello world', the returned string could be<a name="line.374"></a>
+<span class="sourceLineNo">375</span> */<a name="line.375"></a>
+<span class="sourceLineNo">376</span> public String prefix(final String str) {<a name="line.376"></a>
+<span class="sourceLineNo">377</span> return this.toString() + " " + str;<a name="line.377"></a>
+<span class="sourceLineNo">378</span> }<a name="line.378"></a>
+<span class="sourceLineNo">379</span><a name="line.379"></a>
+<span class="sourceLineNo">380</span> /**<a name="line.380"></a>
+<span class="sourceLineNo">381</span> * Get the znodes corresponding to the meta replicas from ZK<a name="line.381"></a>
+<span class="sourceLineNo">382</span> * @return list of znodes<a name="line.382"></a>
+<span class="sourceLineNo">383</span> * @throws KeeperException if a ZooKeeper operation fails<a name="line.383"></a>
+<span class="sourceLineNo">384</span> */<a name="line.384"></a>
+<span class="sourceLineNo">385</span> public List<String> getMetaReplicaNodes() throws KeeperException {<a name="line.385"></a>
+<span class="sourceLineNo">386</span> List<String> childrenOfBaseNode = ZKUtil.listChildrenNoWatch(this, znodePaths.baseZNode);<a name="line.386"></a>
+<span class="sourceLineNo">387</span> List<String> metaReplicaNodes = new ArrayList<>(2);<a name="line.387"></a>
+<span class="sourceLineNo">388</span> if (childrenOfBaseNode != null) {<a name="line.388"></a>
+<span class="sourceLineNo">389</span> String pattern = conf.get("zookeeper.znode.metaserver","meta-region-server");<a name="line.389"></a>
+<span class="sourceLineNo">390</span> for (String child : childrenOfBaseNode) {<a name="line.390"></a>
+<span class="sourceLineNo">391</span> if (child.startsWith(pattern)) {<a name="line.391"></a>
+<span class="sourceLineNo">392</span> metaReplicaNodes.add(child);<a name="line.392"></a>
+<span class="sourceLineNo">393</span> }<a name="line.393"></a>
+<span class="sourceLineNo">394</span> }<a name="line.394"></a>
+<span class="sourceLineNo">395</span> }<a name="line.395"></a>
+<span class="sourceLineNo">396</span> return metaReplicaNodes;<a name="line.396"></a>
<span class="sourceLineNo">397</span> }<a name="line.397"></a>
<span class="sourceLineNo">398</span><a name="line.398"></a>
<span class="sourceLineNo">399</span> /**<a name="line.399"></a>
-<span class="sourceLineNo">400</span> * @return The number of currently registered listeners<a name="line.400"></a>
-<span class="sourceLineNo">401</span> */<a name="line.401"></a>
-<span class="sourceLineNo">402</span> public int getNumberOfListeners() {<a name="line.402"></a>
-<span class="sourceLineNo">403</span> return listeners.size();<a name="line.403"></a>
-<span class="sourceLineNo">404</span> }<a name="line.404"></a>
-<span class="sourceLineNo">405</span><a name="line.405"></a>
-<span class="sourceLineNo">406</span> /**<a name="line.406"></a>
-<span class="sourceLineNo">407</span> * Get the connection to ZooKeeper.<a name="line.407"></a>
-<span class="sourceLineNo">408</span> * @return connection reference to zookeeper<a name="line.408"></a>
-<span class="sourceLineNo">409</span> */<a name="line.409"></a>
-<span class="sourceLineNo">410</span> public RecoverableZooKeeper getRecoverableZooKeeper() {<a name="line.410"></a>
-<span class="sourceLineNo">411</span> return recoverableZooKeeper;<a name="line.411"></a>
-<span class="sourceLineNo">412</span> }<a name="line.412"></a>
-<span class="sourceLineNo">413</span><a name="line.413"></a>
-<span class="sourceLineNo">414</span> public void reconnectAfterExpiration() throws IOException, KeeperException, InterruptedException {<a name="line.414"></a>
-<span class="sourceLineNo">415</span> recoverableZooKeeper.reconnectAfterExpiration();<a name="line.415"></a>
-<span class="sourceLineNo">416</span> }<a name="line.416"></a>
-<span class="sourceLineNo">417</span><a name="line.417"></a>
-<span class="sourceLineNo">418</span> /**<a name="line.418"></a>
-<span class="sourceLineNo">419</span> * Get the quorum address of this instance.<a name="line.419"></a>
-<span class="sourceLineNo">420</span> * @return quorum string of this zookeeper connection instance<a name="line.420"></a>
-<span class="sourceLineNo">421</span> */<a name="line.421"></a>
-<span class="sourceLineNo">422</span> public String getQuorum() {<a name="line.422"></a>
-<span class="sourceLineNo">423</span> return quorum;<a name="line.423"></a>
-<span class="sourceLineNo">424</span> }<a name="line.424"></a>
-<span class="sourceLineNo">425</span><a name="line.425"></a>
-<span class="sourceLineNo">426</span> /**<a name="line.426"></a>
-<span class="sourceLineNo">427</span> * Get the znodePaths.<a name="line.427"></a>
-<span class="sourceLineNo">428</span> * <p><a name="line.428"></a>
-<span class="sourceLineNo">429</span> * Mainly used for mocking as mockito can not mock a field access.<a name="line.429"></a>
-<span class="sourceLineNo">430</span> */<a name="line.430"></a>
-<span class="sourceLineNo">431</span> public ZNodePaths getZNodePaths() {<a name="line.431"></a>
-<span class="sourceLineNo">432</span> return znodePaths;<a name="line.432"></a>
-<span class="sourceLineNo">433</span> }<a name="line.433"></a>
-<span class="sourceLineNo">434</span><a name="line.434"></a>
-<span class="sourceLineNo">435</span> /**<a name="line.435"></a>
-<span class="sourceLineNo">436</span> * Method called from ZooKeeper for events and connection status.<a name="line.436"></a>
-<span class="sourceLineNo">437</span> * <p><a name="line.437"></a>
-<span class="sourceLineNo">438</span> * Valid events are passed along to listeners. Connection status changes<a name="line.438"></a>
-<span class="sourceLineNo">439</span> * are dealt with locally.<a name="line.439"></a>
-<span class="sourceLineNo">440</span> */<a name="line.440"></a>
-<span class="sourceLineNo">441</span> @Override<a name="line.441"></a>
-<span class="sourceLineNo">442</span> public void process(WatchedEvent event) {<a name="line.442"></a>
-<span class="sourceLineNo">443</span> LOG.debug(prefix("Received ZooKeeper Event, " +<a name="line.443"></a>
-<span class="sourceLineNo">444</span> "type=" + event.getType() + ", " +<a name="line.444"></a>
-<span class="sourceLineNo">445</span> "state=" + event.getState() + ", " +<a name="line.445"></a>
-<span class="sourceLineNo">446</span> "path=" + event.getPath()));<a name="line.446"></a>
-<span class="sourceLineNo">447</span><a name="line.447"></a>
-<span class="sourceLineNo">448</span> switch(event.getType()) {<a name="line.448"></a>
-<span class="sourceLineNo">449</span><a name="line.449"></a>
-<span class="sourceLineNo">450</span> // If event type is NONE, this is a connection status change<a name="line.450"></a>
-<span class="sourceLineNo">451</span> case None: {<a name="line.451"></a>
-<span class="sourceLineNo">452</span> connectionEvent(event);<a name="line.452"></a>
-<span class="sourceLineNo">453</span> break;<a name="line.453"></a>
-<span class="sourceLineNo">454</span> }<a name="line.454"></a>
-<span class="sourceLineNo">455</span><a name="line.455"></a>
-<span class="sourceLineNo">456</span> // Otherwise pass along to the listeners<a name="line.456"></a>
-<span class="sourceLineNo">457</span><a name="line.457"></a>
-<span class="sourceLineNo">458</span> case NodeCreated: {<a name="line.458"></a>
-<span class="sourceLineNo">459</span> for(ZKListener listener : listeners) {<a name="line.459"></a>
-<span class="sourceLineNo">460</span> listener.nodeCreated(event.getPath());<a name="line.460"></a>
-<span class="sourceLineNo">461</span> }<a name="line.461"></a>
-<span class="sourceLineNo">462</span> break;<a name="line.462"></a>
-<span class="sourceLineNo">463</span> }<a name="line.463"></a>
-<span class="sourceLineNo">464</span><a name="line.464"></a>
-<span class="sourceLineNo">465</span> case NodeDeleted: {<a name="line.465"></a>
-<span class="sourceLineNo">466</span> for(ZKListener listener : listeners) {<a name="line.466"></a>
-<span class="sourceLineNo">467</span> listener.nodeDeleted(event.getPath());<a name="line.467"></a>
-<span class="sourceLineNo">468</span> }<a name="line.468"></a>
-<span class="sourceLineNo">469</span> break;<a name="line.469"></a>
-<span class="sourceLineNo">470</span> }<a name="line.470"></a>
-<span class="sourceLineNo">471</span><a name="line.471"></a>
-<span class="sourceLineNo">472</span> case NodeDataChanged: {<a name="line.472"></a>
-<span class="sourceLineNo">473</span> for(ZKListener listener : listeners) {<a name="line.473"></a>
-<span class="sourceLineNo">474</span> listener.nodeDataChanged(event.getPath());<a name="line.474"></a>
-<span class="sourceLineNo">475</span> }<a name="line.475"></a>
-<span class="sourceLineNo">476</span> break;<a name="line.476"></a>
-<span class="sourceLineNo">477</span> }<a name="line.477"></a>
-<span class="sourceLineNo">478</span><a name="line.478"></a>
-<span class="sourceLineNo">479</span> case NodeChildrenChanged: {<a name="line.479"></a>
-<span class="sourceLineNo">480</span> for(ZKListener listener : listeners) {<a name="line.480"></a>
-<span class="sourceLineNo">481</span> listener.nodeChildrenChanged(event.getPath());<a name="line.481"></a>
-<span class="sourceLineNo">482</span> }<a name="line.482"></a>
-<span class="sourceLineNo">483</span> break;<a name="line.483"></a>
-<span class="sourceLineNo">484</span> }<a name="line.484"></a>
-<span class="sourceLineNo">485</span> }<a name="line.485"></a>
-<span class="sourceLineNo">486</span> }<a name="line.486"></a>
-<span class="sourceLineNo">487</span><a name="line.487"></a>
-<span class="sourceLineNo">488</span> // Connection management<a name="line.488"></a>
-<span class="sourceLineNo">489</span><a name="line.489"></a>
-<span class="sourceLineNo">490</span> /**<a name="line.490"></a>
-<span class="sourceLineNo">491</span> * Called when there is a connection-related event via the Watcher callback.<a name="line.491"></a>
-<span class="sourceLineNo">492</span> * <p><a name="line.492"></a>
-<span class="sourceLineNo">493</span> * If Disconnected or Expired, this should shutdown the cluster. But, since<a name="line.493"></a>
-<span class="sourceLineNo">494</span> * we send a KeeperException.SessionExpiredException along with the abort<a name="line.494"></a>
-<span class="sourceLineNo">495</span> * call, it's possible for the Abortable to catch it and try to create a new<a name="line.495"></a>
-<span class="sourceLineNo">496</span> * session with ZooKeeper. This is what the client does in HCM.<a name="line.496"></a>
-<span class="sourceLineNo">497</span> * <p><a name="line.497"></a>
-<span class="sourceLineNo">498</span> * @param event the connection-related event<a name="line.498"></a>
-<span class="sourceLineNo">499</span> */<a name="line.499"></a>
-<span class="sourceLineNo">500</span> private void connectionEvent(WatchedEvent event) {<a name="line.500"></a>
-<span class="sourceLineNo">501</span> switch(event.getState()) {<a name="line.501"></a>
-<span class="sourceLineNo">502</span> case SyncConnected:<a name="line.502"></a>
-<span class="sourceLineNo">503</span> this.identifier = this.prefix + "-0x" +<a name="line.503"></a>
-<span class="sourceLineNo">504</span> Long.toHexString(this.recoverableZooKeeper.getSessionId());<a name="line.504"></a>
-<span class="sourceLineNo">505</span> // Update our identifier. Otherwise ignore.<a name="line.505"></a>
-<span class="sourceLineNo">506</span> LOG.debug(this.identifier + " connected");<a name="line.506"></a>
-<span class="sourceLineNo">507</span> break;<a name="line.507"></a>
-<span class="sourceLineNo">508</span><a name="line.508"></a>
-<span class="sourceLineNo">509</span> // Abort the server if Disconnected or Expired<a name="line.509"></a>
-<span class="sourceLineNo">510</span> case Disconnected:<a name="line.510"></a>
-<span class="sourceLineNo">511</span> LOG.debug(prefix("Received Disconnected from ZooKeeper, ignoring"));<a name="line.511"></a>
-<span class="sourceLineNo">512</span> break;<a name="line.512"></a>
+<span class="sourceLineNo">400</span> * Register the specified listener to receive ZooKeeper events.<a name="line.400"></a>
+<span class="sourceLineNo">401</span> * @param listener the listener to register<a name="line.401"></a>
+<span class="sourceLineNo">402</span> */<a name="line.402"></a>
+<span class="sourceLineNo">403</span> public void registerListener(ZKListener listener) {<a name="line.403"></a>
+<span class="sourceLineNo">404</span> listeners.add(listener);<a name="line.404"></a>
+<span class="sourceLineNo">405</span> }<a name="line.405"></a>
+<span class="sourceLineNo">406</span><a name="line.406"></a>
+<span class="sourceLineNo">407</span> /**<a name="line.407"></a>
+<span class="sourceLineNo">408</span> * Register the specified listener to receive ZooKeeper events and add it as<a name="line.408"></a>
+<span class="sourceLineNo">409</span> * the first in the list of current listeners.<a name="line.409"></a>
+<span class="sourceLineNo">410</span> * @param listener the listener to register<a name="line.410"></a>
+<span class="sourceLineNo">411</span> */<a name="line.411"></a>
+<span class="sourceLineNo">412</span> public void registerListenerFirst(ZKListener listener) {<a name="line.412"></a>
+<span class="sourceLineNo">413</span> listeners.add(0, listener);<a name="line.413"></a>
+<span class="sourceLineNo">414</span> }<a name="line.414"></a>
+<span class="sourceLineNo">415</span><a name="line.415"></a>
+<span class="sourceLineNo">416</span> public void unregisterListener(ZKListener listener) {<a name="line.416"></a>
+<span class="sourceLineNo">417</span> listeners.remove(listener);<a name="line.417"></a>
+<span class="sourceLineNo">418</span> }<a name="line.418"></a>
+<span class="sourceLineNo">419</span><a name="line.419"></a>
+<span class="sourceLineNo">420</span> /**<a name="line.420"></a>
+<span class="sourceLineNo">421</span> * Clean all existing listeners<a name="line.421"></a>
+<span class="sourceLineNo">422</span> */<a name="line.422"></a>
+<span class="sourceLineNo">423</span> public void unregisterAllListeners() {<a name="line.423"></a>
+<span class="sourceLineNo">424</span> listeners.clear();<a name="line.424"></a>
+<span class="sourceLineNo">425</span> }<a name="line.425"></a>
+<span class="sourceLineNo">426</span><a name="line.426"></a>
+<span class="sourceLineNo">427</span> /**<a name="line.427"></a>
+<span class="sourceLineNo">428</span> * Get a copy of current registered listeners<a name="line.428"></a>
+<span class="sourceLineNo">429</span> */<a name="line.429"></a>
+<span class="sourceLineNo">430</span> public List<ZKListener> getListeners() {<a name="line.430"></a>
+<span class="sourceLineNo">431</span> return new ArrayList<>(listeners);<a name="line.431"></a>
+<span class="sourceLineNo">432</span> }<a name="line.432"></a>
+<span class="sourceLineNo">433</span><a name="line.433"></a>
+<span class="sourceLineNo">434</span> /**<a name="line.434"></a>
+<span class="sourceLineNo">435</span> * @return The number of currently registered listeners<a name="line.435"></a>
+<span class="sourceLineNo">436</span> */<a name="line.436"></a>
+<span class="sourceLineNo">437</span> public int getNumberOfListeners() {<a name="line.437"></a>
+<span class="sourceLineNo">438</span> return listeners.size();<a name="line.438"></a>
+<span class="sourceLineNo">439</span> }<a name="line.439"></a>
+<span class="sourceLineNo">440</span><a name="line.440"></a>
+<span class="sourceLineNo">441</span> /**<a name="line.441"></a>
+<span class="sourceLineNo">442</span> * Get the connection to ZooKeeper.<a name="line.442"></a>
+<span class="sourceLineNo">443</span> * @return connection reference to zookeeper<a name="line.443"></a>
+<span class="sourceLineNo">444</span> */<a name="line.444"></a>
+<span class="sourceLineNo">445</span> public RecoverableZooKeeper getRecoverableZooKeeper() {<a name="line.445"></a>
+<span class="sourceLineNo">446</span> return recoverableZooKeeper;<a name="line.446"></a>
+<span class="sourceLineNo">447</span> }<a name="line.447"></a>
+<span class="sourceLineNo">448</span><a name="line.448"></a>
+<span class="sourceLineNo">449</span> public void reconnectAfterExpiration() throws IOException, KeeperException, InterruptedException {<a name="line.449"></a>
+<span class="sourceLineNo">450</span> recoverableZooKeeper.reconnectAfterExpiration();<a name="line.450"></a>
+<span class="sourceLineNo">451</span> }<a name="line.451"></a>
+<span class="sourceLineNo">452</span><a name="line.452"></a>
+<span class="sourceLineNo">453</span> /**<a name="line.453"></a>
+<span class="sourceLineNo">454</span> * Get the quorum address of this instance.<a name="line.454"></a>
+<span class="sourceLineNo">455</span> * @return quorum string of this zookeeper connection instance<a name="line.455"></a>
+<span class="sourceLineNo">456</span> */<a name="line.456"></a>
+<span class="sourceLineNo">457</span> public String getQuorum() {<a name="line.457"></a>
+<span class="sourceLineNo">458</span> return quorum;<a name="line.458"></a>
+<span class="sourceLineNo">459</span> }<a name="line.459"></a>
+<span class="sourceLineNo">460</span><a name="line.460"></a>
+<span class="sourceLineNo">461</span> /**<a name="line.461"></a>
+<span class="sourceLineNo">462</span> * Get the znodePaths.<a name="line.462"></a>
+<span class="sourceLineNo">463</span> * <p><a name="line.463"></a>
+<span class="sourceLineNo">464</span> * Mainly used for mocking as mockito can not mock a field access.<a name="line.464"></a>
+<span class="sourceLineNo">465</span> */<a name="line.465"></a>
+<span class="sourceLineNo">466</span> public ZNodePaths getZNodePaths() {<a name="line.466"></a>
+<span class="sourceLineNo">467</span> return znodePaths;<a name="line.467"></a>
+<span class="sourceLineNo">468</span> }<a name="line.468"></a>
+<span class="sourceLineNo">469</span><a name="line.469"></a>
+<span class="sourceLineNo">470</span> /**<a name="line.470"></a>
+<span class="sourceLineNo">471</span> * Method called from ZooKeeper for events and connection status.<a name="line.471"></a>
+<span class="sourceLineNo">472</span> * <p><a name="line.472"></a>
+<span class="sourceLineNo">473</span> * Valid events are passed along to listeners. Connection status changes<a name="line.473"></a>
+<span class="sourceLineNo">474</span> * are dealt with locally.<a name="line.474"></a>
+<span class="sourceLineNo">475</span> */<a name="line.475"></a>
+<span class="sourceLineNo">476</span> @Override<a name="line.476"></a>
+<span class="sourceLineNo">477</span> public void process(WatchedEvent event) {<a name="line.477"></a>
+<span class="sourceLineNo">478</span> LOG.debug(prefix("Received ZooKeeper Event, " +<a name="line.478"></a>
+<span class="sourceLineNo">479</span> "type=" + event.getType() + ", " +<a name="line.479"></a>
+<span class="sourceLineNo">480</span> "state=" + event.getState() + ", " +<a name="line.480"></a>
+<span class="sourceLineNo">481</span> "path=" + event.getPath()));<a name="line.481"></a>
+<span class="sourceLineNo">482</span><a name="line.482"></a>
+<span class="sourceLineNo">483</span> switch(event.getType()) {<a name="line.483"></a>
+<span class="sourceLineNo">484</span><a name="line.484"></a>
+<span class="sourceLineNo">485</span> // If event type is NONE, this is a connection status change<a name="line.485"></a>
+<span class="sourceLineNo">486</span> case None: {<a name="line.486"></a>
+<span class="sourceLineNo">487</span> connectionEvent(event);<a name="line.487"></a>
+<span class="sourceLineNo">488</span> break;<a name="line.488"></a>
+<span class="sourceLineNo">489</span> }<a name="line.489"></a>
+<span class="sourceLineNo">490</span><a name="line.490"></a>
+<span class="sourceLineNo">491</span> // Otherwise pass along to the listeners<a name="line.491"></a>
+<span class="sourceLineNo">492</span><a name="line.492"></a>
+<span class="sourceLineNo">493</span> case NodeCreated: {<a name="line.493"></a>
+<span class="sourceLineNo">494</span> for(ZKListener listener : listeners) {<a name="line.494"></a>
+<span class="sourceLineNo">495</span> listener.nodeCreated(event.getPath());<a name="line.495"></a>
+<span class="sourceLineNo">496</span> }<a name="line.496"></a>
+<span class="sourceLineNo">497</span> break;<a name="line.497"></a>
+<span class="sourceLineNo">498</span> }<a name="line.498"></a>
+<span class="sourceLineNo">499</span><a name="line.499"></a>
+<span class="sourceLineNo">500</span> case NodeDeleted: {<a name="line.500"></a>
+<span class="sourceLineNo">501</span> for(ZKListener listener : listeners) {<a name="line.501"></a>
+<span class="sourceLineNo">502</span> listener.nodeDeleted(event.getPath());<a name="line.502"></a>
+<span class="sourceLineNo">503</span> }<a name="line.503"></a>
+<span class="sourceLineNo">504</span> break;<a name="line.504"></a>
+<span class="sourceLineNo">505</span> }<a name="line.505"></a>
+<span class="sourceLineNo">506</span><a name="line.506"></a>
+<span class="sourceLineNo">507</span> case NodeDataChanged: {<a name="line.507"></a>
+<span class="sourceLineNo">508</span> for(ZKListener listener : listeners) {<a name="line.508"></a>
+<span class="sourceLineNo">509</span> listener.nodeDataChanged(event.getPath());<a name="line.509"></a>
+<span class="sourceLineNo">510</span> }<a name="line.510"></a>
+<span class="sourceLineNo">511</span> break;<a name="line.511"></a>
+<span class="sourceLineNo">512</span> }<a name="line.512"></a>
<span class="sourceLineNo">513</span><a name="line.513"></a>
-<span class="sourceLineNo">514</span> case Expired:<a name="line.514"></a>
-<span class="sourceLineNo">515</span> String msg = prefix(this.identifier + " received expired from " +<a name="line.515"></a>
-<span class="sourceLineNo">516</span> "ZooKeeper, aborting");<a name="line.516"></a>
-<span class="sourceLineNo">517</span> // TODO: One thought is to add call to ZKListener so say,<a name="line.517"></a>
-<span class="sourceLineNo">518</span> // ZKNodeTracker can zero out its data values.<a name="line.518"></a>
-<span class="sourceLineNo">519</span> if (this.abortable != null) {<a name="line.519"></a>
-<span class="sourceLineNo">520</span> this.abortable.abort(msg, new KeeperException.SessionExpiredException());<a name="line.520"></a>
-<span class="sourceLineNo">521</span> }<a name="line.521"></a>
-<span class="sourceLineNo">522</span> break;<a name="line.522"></a>
-<span class="sourceLineNo">523</span><a name="line.523"></a>
-<span class="sourceLineNo">524</span> case ConnectedReadOnly:<a name="line.524"></a>
-<span class="sourceLineNo">525</span> case SaslAuthenticated:<a name="line.525"></a>
-<span class="sourceLineNo">526</span> case AuthFailed:<a name="line.526"></a>
-<span class="sourceLineNo">527</span> break;<a name="line.527"></a>
-<span class="sourceLineNo">528</span><a name="line.528"></a>
-<span class="sourceLineNo">529</span> default:<a name="line.529"></a>
-<span class="sourceLineNo">530</span> throw new IllegalStateException("Received event is not valid: " + event.getState());<a name="line.530"></a>
-<span class="sourceLineNo">531</span> }<a name="line.531"></a>
-<span class="sourceLineNo">532</span> }<a name="line.532"></a>
-<span class="sourceLineNo">533</span><a name="line.533"></a>
-<span class="sourceLineNo">534</span> /**<a name="line.534"></a>
-<span class="sourceLineNo">535</span> * Forces a synchronization of this ZooKeeper client connection.<a name="line.535"></a>
-<span class="sourceLineNo">536</span> * <p><a name="line.536"></a>
-<span class="sourceLineNo">537</span> * Executing this method before running other methods will ensure that the<a name="line.537"></a>
-<span class="sourceLineNo">538</span> * subsequent operations are up-to-date and consistent as of the time that<a name="line.538"></a>
-<span class="sourceLineNo">539</span> * the sync is complete.<a name="line.539"></a>
-<span class="sourceLineNo">540</span> * <p><a name="line.540"></a>
-<span class="sourceLineNo">541</span> * This is used for compareAndSwap type operations where we need to read the<a name="line.541"></a>
-<span class="sourceLineNo">542</span> * data of an existing node and delete or transition that node, utilizing the<a name="line.542"></a>
-<span class="sourceLineNo">543</span> * previously read version and data. We want to ensure that the version read<a name="line.543"></a>
-<span class="sourceLineNo">544</span> * is up-to-date from when we begin the operation.<a name="line.544"></a>
-<span class="sourceLineNo">545</span> */<a name="line.545"></a>
-<span class="sourceLineNo">546</span> public void sync(String path) throws KeeperException {<a name="line.546"></a>
-<span class="sourceLineNo">547</span> this.recoverableZooKeeper.sync(path, null, null);<a name="line.547"></a>
-<span class="sourceLineNo">548</span> }<a name="line.548"></a>
-<span class="sourceLineNo">549</span><a name="line.549"></a>
-<span class="sourceLineNo">550</span> /**<a name="line.550"></a>
-<span class="sourceLineNo">551</span> * Handles KeeperExceptions in client calls.<a name="line.551"></a>
-<span class="sourceLineNo">552</span> * <p><a name="line.552"></a>
-<span class="sourceLineNo">553</span> * This may be temporary but for now this gives one place to deal with these.<a name="line.553"></a>
-<span class="sourceLineNo">554</span> * <p><a name="line.554"></a>
-<span class="sourceLineNo">555</span> * TODO: Currently this method rethrows the exception to let the caller handle<a name="line.555"></a>
-<span class="sourceLineNo">556</span> * <p><a name="line.556"></a>
-<span class="sourceLineNo">557</span> * @param ke the exception to rethrow<a name="line.557"></a>
-<span class="sourceLineNo">558</span> * @throws KeeperException if a ZooKeeper operation fails<a name="line.558"></a>
-<span class="sourceLineNo">559</span> */<a name="line.559"></a>
-<span class="sourceLineNo">560</span> public void keeperException(KeeperException ke) throws KeeperException {<a name="line.560"></a>
-<span class="sourceLineNo">561</span> LOG.error(prefix("Received unexpected KeeperException, re-throwing exception"), ke);<a name="line.561"></a>
-<span class="sourceLineNo">562</span> throw ke;<a name="line.562"></a>
-<span class="sourceLineNo">563</span> }<a name="line.563"></a>
-<span class="sourceLineNo">564</span><a name="line.564"></a>
-<span class="sourceLineNo">565</span> /**<a name="line.565"></a>
-<span class="sourceLineNo">566</span> * Handles InterruptedExceptions in client calls.<a name="line.566"></a>
-<span class="sourceLineNo">567</span> * @param ie the InterruptedException instance thrown<a name="line.567"></a>
-<span class="sourceLineNo">568</span> * @throws KeeperException the exception to throw, transformed from the InterruptedException<a name="line.568"></a>
-<span class="sourceLineNo">569</span> */<a name="line.569"></a>
-<span class="sourceLineNo">570</span> public void interruptedException(InterruptedException ie) throws KeeperException {<a name="line.570"></a>
-<span class="sourceLineNo">571</span> interruptedExceptionNoThrow(ie, true);<a name="line.571"></a>
-<span class="sourceLineNo">572</span> // Throw a system error exception to let upper level handle it<a name="line.572"></a>
-<span class="sourceLineNo">573</span> throw new KeeperException.SystemErrorException();<a name="line.573"></a>
-<span class="sourceLineNo">574</span> }<a name="line.574"></a>
-<span class="sourceLineNo">575</span><a name="line.575"></a>
-<span class="sourceLineNo">576</span> /**<a name="line.576"></a>
-<span class="sourceLineNo">577</span> * Log the InterruptedException and interrupt current thread<a name="line.577"></a>
-<span class="sourceLineNo">578</span> * @param ie The IterruptedException to log<a name="line.578"></a>
-<span class="sourceLineNo">579</span> * @param throwLater Whether we will throw the exception latter<a name="line.579"></a>
+<span class="sourceLineNo">514</span> case NodeChildrenChanged: {<a name="line.514"></a>
+<span class="sourceLineNo">515</span> for(ZKListener listener : listeners) {<a name="line.515"></a>
+<span class="sourceLineNo">516</span> listener.nodeChildrenChanged(event.getPath());<a name="line.516"></a>
+<span class="sourceLineNo">517</span> }<a name="line.517"></a>
+<span class="sourceLineNo">518</span> break;<a name="line.518"></a>
+<span class="sourceLineNo">519</span> }<a name="line.519"></a>
+<span class="sourceLineNo">520</span> }<a name="line.520"></a>
+<span class="sourceLineNo">521</span> }<a name="line.521"></a>
+<span class="sourceLineNo">522</span><a name="line.522"></a>
+<span class="sourceLineNo">523</span> // Connection management<a name="line.523"></a>
+<span class="sourceLineNo">524</span><a name="line.524"></a>
+<span class="sourceLineNo">525</span> /**<a name="line.525"></a>
+<span class="sourceLineNo">526</span> * Called when there is a connection-related event via the Watcher callback.<a name="line.526"></a>
+<span class="sourceLineNo">527</span> * <p><a name="line.527"></a>
+<span class="sourceLineNo">528</span> * If Disconnected or Expired, this should shutdown the cluster. But, since<a name="line.528"></a>
+<span class="sourceLineNo">529</span> * we send a KeeperException.SessionExpiredException along with the abort<a name="line.529"></a>
+<span class="sourceLineNo">530</span> * call, it's possible for the Abortable to catch it and try to create a new<a name="line.530"></a>
+<span class="sourceLineNo">531</span> * session with ZooKeeper. This is what the client does in HCM.<a name="line.531"></a>
+<span class="sourceLineNo">532</span> * <p><a name="line.532"></a>
+<span class="sourceLineNo">533</span> * @param event the connection-related event<a name="line.533"></a>
+<span class="sourceLineNo">534</span> */<a name="line.534"></a>
+<span class="sourceLineNo">535</span> private void connectionEvent(WatchedEvent event) {<a name="line.535"></a>
+<span class="sourceLineNo">536</span> switch(event.getState()) {<a name="line.536"></a>
+<span class="sourceLineNo">537</span> case SyncConnected:<a name="line.537"></a>
+<span class="sourceLineNo">538</span> this.identifier = this.prefix + "-0x" +<a name="line.538"></a>
+<span class="sourceLineNo">539</span> Long.toHexString(this.recoverableZooKeeper.getSessionId());<a name="line.539"></a>
+<span class="sourceLineNo">540</span> // Update our identifier. Otherwise ignore.<a name="line.540"></a>
+<span class="sourceLineNo">541</span> LOG.debug(this.identifier + " connected");<a name="line.541"></a>
+<span class="sourceLineNo">542</span> break;<a name="line.542"></a>
+<span class="sourceLineNo">543</span><a name="line.543"></a>
+<span class="sourceLineNo">544</span> // Abort the server if Disconnected or Expired<a name="line.544"></a>
+<span class="sourceLineNo">545</span> case Disconnected:<a name="line.545"></a>
+<span class="sourceLineNo">546</span> LOG.debug(prefix("Received Disconnected from ZooKeeper, ignoring"));<a name="line.546"></a>
+<span class="sourceLineNo">547</span> break;<a name="line.547"></a>
+<span class="sourceLineNo">548</span><a name="line.548"></a>
+<span class="sourceLineNo">549</span> case Expired:<a name="line.549"></a>
+<span class="sourceLineNo">550</span> String msg = prefix(this.identifier + " received expired from " +<a name="line.550"></a>
+<span class="sourceLineNo">551</span> "ZooKeeper, aborting");<a name="line.551"></a>
+<span class="sourceLineNo">552</span> // TODO: One thought is to add call to ZKListener so say,<a name="line.552"></a>
+<span class="sourceLineNo">553</span> // ZKNodeTracker can zero out its data values.<a name="line.553"></a>
+<span class="sourceLineNo">554</span> if (this.abortable != null) {<a name="line.554"></a>
+<span class="sourceLineNo">555</span> this.abortable.abort(msg, new KeeperException.SessionExpiredException());<a name="line.555"></a>
+<span class="sourceLineNo">556</span> }<a name="line.556"></a>
+<span class="sourceLineNo">557</span> break;<a name="line.557"></a>
+<span class="sourceLineNo">558</span><a name="line.558"></a>
+<span class="sourceLineNo">559</span> case ConnectedReadOnly:<a name="line.559"></a>
+<span class="sourceLineNo">560</span> case SaslAuthenticated:<a name="line.560"></a>
+<span class="sourceLineNo">561</span> case AuthFailed:<a name="line.561"></a>
+<span class="sourceLineNo">562</span> break;<a name="line.562"></a>
+<span class="sourceLineNo">563</span><a name="line.563"></a>
+<span class="sourceLineNo">564</span> default:<a name="line.564"></a>
+<span class="sourceLineNo">565</span> throw new IllegalStateException("Received event is not valid: " + event.getState());<a name="line.565"></a>
+<span class="sourceLineNo">566</span> }<a name="line.566"></a>
+<span class="sourceLineNo">567</span> }<a name="line.567"></a>
+<span class="sourceLineNo">568</span><a name="line.568"></a>
+<span class="sourceLineNo">569</span> /**<a name="line.569"></a>
+<span class="sourceLineNo">570</span> * Forces a synchronization of this ZooKeeper client connection.<a name="line.570"></a>
+<span class="sourceLineNo">571</span> * <p><a name="line.571"></a>
+<span class="sourceLineNo">572</span> * Executing this method before running other methods will ensure that the<a name="line.572"></a>
+<span class="sourceLineNo">573</span> * subsequent operations are up-to-date and consistent as of the time that<a name="line.573"></a>
+<span class="sourceLineNo">574</span> * the sync is complete.<a name="line.574"></a>
+<span class="sourceLineNo">575</span> * <p><a name="line.575"></a>
+<span class="sourceLineNo">576</span> * This is used for compareAndSwap type operations where we need to read the<a name="line.576"></a>
+<span class="sourceLineNo">577</span> * data of an existing node and delete or transition that node, utilizing the<a name="line.577"></a>
+<span class="sourceLineNo">578</span> * previously read version and data. We want to ensure that the version read<a name="line.578"></a>
+<span class="sourceLineNo">579</span> * is up-to-date from when we begin the operation.<a name="line.579"></a>
<span class="sourceLineNo">580</span> */<a name="line.580"></a>
-<span class="sourceLineNo">581</span> public void interruptedExceptionNoThrow(InterruptedException ie, boolean throwLater) {<a name="line.581"></a>
-<span class="sourceLineNo">582</span> LOG.debug(prefix("Received InterruptedException, will interrupt current thread"<a name="line.582"></a>
-<span class="sourceLineNo">583</span> + (throwLater ? " and rethrow a SystemErrorException" : "")),<a name="line.583"></a>
-<span class="sourceLineNo">584</span> ie);<a name="line.584"></a>
-<span class="sourceLineNo">585</span> // At least preserve interrupt.<a name="line.585"></a>
-<span class="sourceLineNo">586</span> Thread.currentThread().interrupt();<a name="line.586"></a>
-<span class="sourceLineNo">587</span> }<a name="line.587"></a>
-<span class="sourceLineNo">588</span><a name="line.588"></a>
-<span class="sourceLineNo">589</span> /**<a name="line.589"></a>
-<span class="sourceLineNo">590</span> * Close the connection to ZooKeeper.<a name="line.590"></a>
-<span class="sourceLineNo">591</span> *<a name="line.591"></a>
-<span class="sourceLineNo">592</span> */<a name="line.592"></a>
-<span class="sourceLineNo">593</span> @Override<a name="line.593"></a>
-<span class="sourceLineNo">594</span> public void close() {<a name="line.594"></a>
-<span class="sourceLineNo">595</span> try {<a name="line.595"><
<TRUNCATED>