[GitHub] [commons-lang] theshoeshiner commented on pull request #1062: Syntax for optional tokens in DurationFormatUtils

["theshoeshiner (via GitHub)" <gi...@apache.org>]

theshoeshiner commented on PR #1062:
URL: https://github.com/apache/commons-lang/pull/1062#issuecomment-1611667733

   I will add tests for `formatPeriod` as well, and check on my end for other library methods invoking these.
   
   In regards to the javadocs, the method level `formatDuration` and `formatPeriod` docs not go into any other details about the syntax of the format string, as those details are covered in the class level doc. To follow that precedent I can put a paragraph at the class level that explains the optional syntax (unless anyone feels like this change deserves mentioning in both areas).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org