Help on submitting a patch to ant

["Tobias K. Tobiasen" <to...@kapowtech.com>]

Hello,

As you properly know the junit task there are some classloading
problems. 
See
http://ant.apache.org/faq.html#delegating-classloader

I have made a patch that solves these classloader problems. See
http://issues.apache.org/bugzilla/show_bug.cgi?id=6606#c22

I would like to submit the patch. But I am not sure how I do it. I have
read this http://ant.apache.org/ant_task_guidelines.html
But I still have a few questions.

*) Should I make the patch for 1.6.x or 1.7?
*) If you are not forking the junit task you still have to put junit.jar
in the system classpath. Is it OK to change the junit task so it forks a
new process for junit if junit.jar isn't present in the system
classpath? Even if people have fork="false" in the build file? Or is it
more appropriate to fail with an error message that says you have to
fork or add junit.jar to the system classpath.
*) Where is the proper place to post these questions? I have looked at
the dev@ant.apache.org archive and it does not seem to be the right
place.

Tobias K. Tobiasen



---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
For additional commands, e-mail: user-help@ant.apache.org

Re: Help on submitting a patch to ant

[Stefan Bodewig <bo...@apache.org>]

On Wed, 15 Jun 2005, Tobias K. Tobiasen <to...@kapowtech.com> wrote:

> *) Should I make the patch for 1.6.x or 1.7?

CVS HEAD.  There most probably won't be any 1.6.x release after 1.6.5.

> *) If you are not forking the junit task you still have to put
> junit.jar in the system classpath. Is it OK to change the junit task
> so it forks a new process for junit if junit.jar isn't present in
> the system classpath?

Why?  Print a warning and fail seems to be the better choice to me,
otherwise we are only hiding a setup problem.

> Even if people have fork="false" in the build file?

No.  If people set an attribute, Ant should respect that.

> *) Where is the proper place to post these questions?

dev@ant.apache.org

> I have looked at the dev@ant.apache.org archive and it does not seem
> to be the right place.

Why not?  What makes you think it was not appropriate?

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@ant.apache.org
For additional commands, e-mail: user-help@ant.apache.org