[GitHub] [iotdb] xinzhongtianxia commented on a change in pull request #4167: [IOTDB-1851] Optimize iot-grafana code and fix some bugs

[GitBox <gi...@apache.org>]

xinzhongtianxia commented on a change in pull request #4167:
URL: https://github.com/apache/iotdb/pull/4167#discussion_r750906931



##########
File path: grafana/src/main/java/org/apache/iotdb/web/grafana/controller/DatabaseConnectController.java
##########
@@ -69,15 +68,12 @@ public void testDataConnection(HttpServletResponse response) throws IOException
   /**
    * get metrics numbers in JSON string structure.
    *
-   * @param request http request
-   * @param response http response
    * @return metrics numbers in JSON string structure
    */
   @RequestMapping(value = "/search")
   @ResponseBody
-  public String metricFindQuery(HttpServletRequest request, HttpServletResponse response) {
+  public String metricFindQuery() {

Review comment:
       In method body, we have not used the `request` param and the response's default code is 200, so we do not need these two params.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org