You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/09 00:54:48 UTC
[GitHub] [spark] zero323 commented on a change in pull request #34515: [SPARK-37235][PYTHON] Inline type hints for python/pyspark/mllib/stat/distribution.py and __init__.py
zero323 commented on a change in pull request #34515:
URL: https://github.com/apache/spark/pull/34515#discussion_r745206215
##########
File path: python/pyspark/mllib/stat/__init__.pyi
##########
@@ -1,29 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-from pyspark.mllib.stat.KernelDensity import ( # noqa: F401
- KernelDensity as KernelDensity,
-)
-from pyspark.mllib.stat._statistics import ( # noqa: F401
- MultivariateStatisticalSummary as MultivariateStatisticalSummary,
- Statistics as Statistics,
-)
-from pyspark.mllib.stat.distribution import ( # noqa: F401
- MultivariateGaussian as MultivariateGaussian,
-)
-from pyspark.mllib.stat.test import ChiSqTestResult as ChiSqTestResult # noqa: F401
Review comment:
Seem like it @HyukjinKwon. There is nothing here, that we cannot pick out of `py` file.
##########
File path: python/pyspark/mllib/stat/__init__.pyi
##########
@@ -1,29 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-from pyspark.mllib.stat.KernelDensity import ( # noqa: F401
- KernelDensity as KernelDensity,
-)
-from pyspark.mllib.stat._statistics import ( # noqa: F401
- MultivariateStatisticalSummary as MultivariateStatisticalSummary,
- Statistics as Statistics,
-)
-from pyspark.mllib.stat.distribution import ( # noqa: F401
- MultivariateGaussian as MultivariateGaussian,
-)
-from pyspark.mllib.stat.test import ChiSqTestResult as ChiSqTestResult # noqa: F401
Review comment:
Seem like it @HyukjinKwon. There is nothing here, that we cannot pick out of the `py` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org