You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/22 05:32:23 UTC

[GitHub] [arrow] cyb70289 commented on a change in pull request #7512: ARROW-9204: [C++][Flight] Change records_per_stream to int64

cyb70289 commented on a change in pull request #7512:
URL: https://github.com/apache/arrow/pull/7512#discussion_r443324836



##########
File path: cpp/src/arrow/flight/flight_benchmark.cc
##########
@@ -42,7 +42,7 @@ DEFINE_int32(server_port, 31337, "The port to connect to");
 DEFINE_int32(num_servers, 1, "Number of performance servers to run");
 DEFINE_int32(num_streams, 4, "Number of streams for each server");
 DEFINE_int32(num_threads, 4, "Number of concurrent gets");
-DEFINE_int32(records_per_stream, 10000000, "Total records per stream");
+DEFINE_int64(records_per_stream, 10000000, "Total records per stream");

Review comment:
       It's defined as int64 at protobuf
   https://github.com/apache/arrow/blob/master/cpp/src/arrow/flight/perf.proto#L26




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org