You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/07/10 08:40:51 UTC
[GitHub] [incubator-eventmesh] Roc-00 opened a new pull request #431: [ISSUE #428]:The Chinese existing in the project was changed to English
Roc-00 opened a new pull request #431:
URL: https://github.com/apache/incubator-eventmesh/pull/431
Translate the Chinese to English on the common module.
Only the Chinese part of the notes has been translated, and the Chinese in the code has not changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #431: [ISSUE #428]Fix Chinese annotation
Posted by GitBox <gi...@apache.org>.
qqeasonchen merged pull request #431:
URL: https://github.com/apache/incubator-eventmesh/pull/431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #431: [ISSUE #428]:The Chinese existing in the project was changed to English
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #431:
URL: https://github.com/apache/incubator-eventmesh/pull/431#discussion_r668018030
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/client/HeartbeatResponseBody.java
##########
@@ -27,13 +27,13 @@
public class HeartbeatResponseBody extends Body {
- //响应码
+ //react code
Review comment:
I think we may not need to add comments for each attribute, for example here, the `retCode` can express variable information. And I would probably prefer to rename it to `returnCode` rather than add a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter commented on pull request #431: [ISSUE #428]Fix Chinese annotation
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #431:
URL: https://github.com/apache/incubator-eventmesh/pull/431#issuecomment-879637664
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/431?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#431](https://codecov.io/gh/apache/incubator-eventmesh/pull/431?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fad0381) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/d8ac875e58f0f77458fe0e3373cc408594466b1f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d8ac875) will **not change** coverage.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-eventmesh/pull/431?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #431 +/- ##
=========================================
Coverage 8.49% 8.49%
Complexity 256 256
=========================================
Files 228 228
Lines 10783 10783
Branches 918 918
=========================================
Hits 916 916
Misses 9793 9793
Partials 74 74
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/431?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/eventmesh/common/command/HttpCommand.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb21tYW5kL0h0dHBDb21tYW5kLmphdmE=) | `67.56% <ø> (ø)` | |
| [...otocol/http/body/client/HeartbeatResponseBody.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvY2xpZW50L0hlYXJ0YmVhdFJlc3BvbnNlQm9keS5qYXZh) | `0.00% <ø> (ø)` | |
| [...ol/http/body/message/ReplyMessageResponseBody.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9SZXBseU1lc3NhZ2VSZXNwb25zZUJvZHkuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...ttp/body/message/SendMessageBatchResponseBody.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9TZW5kTWVzc2FnZUJhdGNoUmVzcG9uc2VCb2R5LmphdmE=) | `0.00% <ø> (ø)` | |
| [...p/body/message/SendMessageBatchV2ResponseBody.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9TZW5kTWVzc2FnZUJhdGNoVjJSZXNwb25zZUJvZHkuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...esh/common/protocol/http/common/ClientRetCode.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2NvbW1vbi9DbGllbnRSZXRDb2RlLmphdmE=) | `0.00% <ø> (ø)` | |
| [...tmesh/common/protocol/http/common/ProtocolKey.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2NvbW1vbi9Qcm90b2NvbEtleS5qYXZh) | `0.00% <ø> (ø)` | |
| [...col/http/header/client/HeartbeatRequestHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9jbGllbnQvSGVhcnRiZWF0UmVxdWVzdEhlYWRlci5qYXZh) | `66.66% <ø> (ø)` | |
| [...protocol/http/header/client/RegResponseHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9jbGllbnQvUmVnUmVzcG9uc2VIZWFkZXIuamF2YQ==) | `65.78% <ø> (ø)` | |
| [...rotocol/http/header/client/UnRegRequestHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9jbGllbnQvVW5SZWdSZXF1ZXN0SGVhZGVyLmphdmE=) | `66.66% <ø> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/431/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/431?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/431?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d8ac875...fad0381](https://codecov.io/gh/apache/incubator-eventmesh/pull/431?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #431: [ISSUE #428]Fix Chinese annotation
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #431:
URL: https://github.com/apache/incubator-eventmesh/pull/431#discussion_r669297972
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/common/ClientRetCode.java
##########
@@ -21,6 +21,7 @@
/**
* 这个RETRY的意思是 客户端发现投递的消息它没有监听时, 告诉EventMesh 发往下一个, 重试几次以实现灰度 , 预留
Review comment:
We may also need to remove this Chinese comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #431: [ISSUE #428]Fix Chinese annotation
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #431:
URL: https://github.com/apache/incubator-eventmesh/pull/431#discussion_r669376283
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/common/ProtocolKey.java
##########
@@ -24,7 +24,7 @@
public static final String VERSION = "Version";
public static class ClientInstanceKey {
- ////////////////////////////////////协议层请求方描述///////////
+ ////////////////////////////////////Protocol layer requester description///////////
Review comment:
I think it might be better not use symbols in comments, the book 《Clean code》 suggests that we should use the simplest comments.
But this is just programming style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on a change in pull request #431: [ISSUE #428]:The Chinese existing in the project was changed to English
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on a change in pull request #431:
URL: https://github.com/apache/incubator-eventmesh/pull/431#discussion_r667688510
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/message/ReplyMessageResponseBody.java
##########
@@ -27,13 +27,13 @@
public class ReplyMessageResponseBody extends Body {
- //响应码
+ //react code
Review comment:
same as above
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/client/HeartbeatResponseBody.java
##########
@@ -27,13 +27,13 @@
public class HeartbeatResponseBody extends Body {
- //响应码
+ //react code
Review comment:
return code may be more appropriate
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/message/ReplyMessageResponseBody.java
##########
@@ -27,13 +27,13 @@
public class ReplyMessageResponseBody extends Body {
- //响应码
+ //react code
private Integer retCode;
- //响应信息
+ //react message
Review comment:
response message
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/message/SendMessageBatchResponseBody.java
##########
@@ -27,13 +27,13 @@
public class SendMessageBatchResponseBody extends Body {
- //响应码
+ //react code
Review comment:
same as above
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/message/SendMessageBatchV2ResponseBody.java
##########
@@ -27,13 +27,13 @@
public class SendMessageBatchV2ResponseBody extends Body {
- //响应码
+ //react code
private Integer retCode;
- //响应信息
+ //react code
Review comment:
same as above
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/message/SendMessageBatchResponseBody.java
##########
@@ -27,13 +27,13 @@
public class SendMessageBatchResponseBody extends Body {
- //响应码
+ //react code
private Integer retCode;
- //响应信息
+ //react message
Review comment:
same as above
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/message/SendMessageBatchV2ResponseBody.java
##########
@@ -27,13 +27,13 @@
public class SendMessageBatchV2ResponseBody extends Body {
- //响应码
+ //react code
Review comment:
same as above
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/message/SendMessageBatchResponseBody.java
##########
@@ -27,13 +27,13 @@
public class SendMessageBatchResponseBody extends Body {
- //响应码
+ //react code
Review comment:
same as above
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/message/SendMessageBatchResponseBody.java
##########
@@ -27,13 +27,13 @@
public class SendMessageBatchResponseBody extends Body {
- //响应码
+ //react code
private Integer retCode;
- //响应信息
+ //react message
Review comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Roc-00 commented on a change in pull request #431: [ISSUE #428]Fix Chinese annotation
Posted by GitBox <gi...@apache.org>.
Roc-00 commented on a change in pull request #431:
URL: https://github.com/apache/incubator-eventmesh/pull/431#discussion_r669301064
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/common/ProtocolKey.java
##########
@@ -24,7 +24,7 @@
public static final String VERSION = "Version";
public static class ClientInstanceKey {
- ////////////////////////////////////协议层请求方描述///////////
+ ////////////////////////////////////Protocol layer requester description///////////
Review comment:
what about this“//Protocol layer requester description//”?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Roc-00 commented on a change in pull request #431: [ISSUE #428]Fix Chinese annotation
Posted by GitBox <gi...@apache.org>.
Roc-00 commented on a change in pull request #431:
URL: https://github.com/apache/incubator-eventmesh/pull/431#discussion_r669300275
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/common/ClientRetCode.java
##########
@@ -21,6 +21,7 @@
/**
* 这个RETRY的意思是 客户端发现投递的消息它没有监听时, 告诉EventMesh 发往下一个, 重试几次以实现灰度 , 预留
Review comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #431: [ISSUE #428]Fix Chinese annotation
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #431:
URL: https://github.com/apache/incubator-eventmesh/pull/431#discussion_r669298559
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/common/ProtocolKey.java
##########
@@ -24,7 +24,7 @@
public static final String VERSION = "Version";
public static class ClientInstanceKey {
- ////////////////////////////////////协议层请求方描述///////////
+ ////////////////////////////////////Protocol layer requester description///////////
Review comment:
It seems not to be a good practice using `///////////////////////` in code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org