[GitHub] [hive] sourabh912 commented on a change in pull request #2638: HIVE-25517: Fixes a bug in setting external table location if the table name is in uppercase

[GitBox <gi...@apache.org>]

sourabh912 commented on a change in pull request #2638:
URL: https://github.com/apache/hive/pull/2638#discussion_r714280331



##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java
##########
@@ -355,7 +355,11 @@ public Path getDefaultTablePath(Database db, String tableName, boolean isExterna
     Path dbPath = null;
     if (isExternal) {
       dbPath = new Path(db.getLocationUri());
-      if (FileUtils.isSubdirectory(getWhRoot().toString(), dbPath.toString() + Path.SEPARATOR)) {
+      Path dbLocation = Path.getPathWithoutSchemeAndAuthority(dbPath);

Review comment:
       Good catch ! 
   We shouldn't do schema less comparison here. Will fix it. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org