[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #229: Restore Git Credentials on NuttX repo

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #229:
URL: https://github.com/apache/incubator-nuttx-apps/pull/229#discussion_r419877153



##########
File path: .github/workflows/build.yml
##########
@@ -162,13 +162,23 @@ jobs:
           retry_wait_seconds: 10
           command: docker pull docker.pkg.github.com/apache/incubator-nuttx-testing/nuttx-ci-linux
 
+      - name: Export NuttX Repo SHA
+        run:  echo "::set-env name=nuttx_sha::`git -C sources/nuttx rev-parse HEAD`"
+      - name: Refresh Git Credentials
+        uses: actions/checkout@v2
+        with:
+          repository: apache/incubator-nuttx

Review comment:
       Does this mean we fetch the source code again?

##########
File path: .github/workflows/build.yml
##########
@@ -162,13 +162,23 @@ jobs:
           retry_wait_seconds: 10
           command: docker pull docker.pkg.github.com/apache/incubator-nuttx-testing/nuttx-ci-linux
 
+      - name: Export NuttX Repo SHA
+        run:  echo "::set-env name=nuttx_sha::`git -C sources/nuttx rev-parse HEAD`"
+      - name: Refresh Git Credentials
+        uses: actions/checkout@v2
+        with:
+          repository: apache/incubator-nuttx
+          ref: ${{ env.nuttx_sha }}
+          path: sources/nuttx
+          fetch-depth: 1
+      - name: Get Tags for NuttX Repo
+        run: git -C sources/nuttx fetch --tags

Review comment:
       I may ask the same question before: does it make sense to move the tag fetch to 'Fetch-Source->Checkout nuttx repo'?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org