You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by John Sichi <js...@fb.com> on 2011/08/01 21:12:50 UTC

Re: Review Request: HIVE-2326: Turn off bitmap indexing when map-side aggregation is turned off

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1232/#review1251
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java
<https://reviews.apache.org/r/1232/#comment2863>

    Typo:  wihtout



ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java
<https://reviews.apache.org/r/1232/#comment2864>

    Throw the exception here instead of returning null.


- John


On 2011-07-31 00:26:44, Syed Albiz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1232/
> -----------------------------------------------------------
> 
> (Updated 2011-07-31 00:26:44)
> 
> 
> Review request for hive, John Sichi and Ning Zhang.
> 
> 
> Summary
> -------
> 
> sets the correct object inspector for PARTIAL2, COMPLETE UDAF modes
> 
> 
> This addresses bug HIVE-2326.
>     https://issues.apache.org/jira/browse/HIVE-2326
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/index/TableBasedIndexHandler.java 02ab78c 
>   ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java 61bbbf5 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFEWAHBitmap.java 0a3df09 
> 
> Diff: https://reviews.apache.org/r/1232/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Syed
> 
>