You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "vinoyang (Jira)" <ji...@apache.org> on 2019/11/13 09:18:00 UTC

[jira] [Commented] (FLINK-14720) Mark ExecutionVertex#deployToSlot with @VisibleForTesting annotation

    [ https://issues.apache.org/jira/browse/FLINK-14720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973159#comment-16973159 ] 

vinoyang commented on FLINK-14720:
----------------------------------

It seems we can only mark it as {{@VisibleForTesting}}, because this method has been used in {{ExecutionGraphToInputsLocationsRetrieverAdapterTest#testGetTaskManagerLocationWhenScheduled}}, they are not in the same package.

> Mark ExecutionVertex#deployToSlot with @VisibleForTesting annotation
> --------------------------------------------------------------------
>
>                 Key: FLINK-14720
>                 URL: https://issues.apache.org/jira/browse/FLINK-14720
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> From tracking the call chain of {{ExecutionVertex#deployToSlot}}, it seems this method is only been called in the test code. IMO, we'd better bring down {{ExecutionVertex#deployToSlot}} access modifier and mark it with @VisibleForTesting annotation to reduce the risk of incorrect calls



--
This message was sent by Atlassian Jira
(v8.3.4#803005)