You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by gvramana <gi...@git.apache.org> on 2018/07/03 15:18:41 UTC

[GitHub] carbondata pull request #2391: [CARBONDATA-2625] Optimize the performance of...

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2391#discussion_r199847207
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java ---
    @@ -81,8 +83,16 @@ public BlockletDataMapIndexWrapper get(TableBlockIndexUniqueIdentifierWrapper id
             SegmentIndexFileStore indexFileStore = new SegmentIndexFileStore();
             Set<String> filesRead = new HashSet<>();
             String segmentFilePath = identifier.getIndexFilePath();
    -        Map<String, BlockMetaInfo> carbonDataFileBlockMetaInfoMapping = BlockletDataMapUtil
    -            .createCarbonDataFileBlockMetaInfoMapping(segmentFilePath);
    +        if (segInfoCache == null) {
    +          segInfoCache = new HashMap<String, Map<String, BlockMetaInfo>>();
    --- End diff --
    
    S3 does not require BlockMetaInfo as location is not valid for S3


---