You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/17 19:12:58 UTC

[GitHub] TisonKun commented on a change in pull request #7527: [FLINK-11106] [yarn] Remove legacy flink-yarn component

TisonKun commented on a change in pull request #7527: [FLINK-11106] [yarn] Remove legacy flink-yarn component
URL: https://github.com/apache/flink/pull/7527#discussion_r248803692
 
 

 ##########
 File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITCase.java
 ##########
 @@ -284,7 +284,7 @@ public void testTaskManagerFailure() throws Exception {
 			ConcurrentMap<ContainerId, Container> containers = nm.getNMContext().getContainers();
 			for (Map.Entry<ContainerId, Container> entry : containers.entrySet()) {
 				String command = StringUtils.join(entry.getValue().getLaunchContext().getCommands(), " ");
-				if (command.contains(YarnTaskManager.class.getSimpleName())) {
 
 Review comment:
   The rework of this test is handled by [FLINK-11348](https://issues.apache.org/jira/browse/FLINK-11348). Currently it is ignored. We simply make this change in order not to block the removal of legacy yarn components.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services