You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/18 12:35:44 UTC

[GitHub] [dolphinscheduler] WangJPLeo commented on a diff in pull request #11543: [Improvement]Add a stop function when you are ready to do pause operation

WangJPLeo commented on code in PR #11543:
URL: https://github.com/apache/dolphinscheduler/pull/11543#discussion_r949078404


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java:
##########
@@ -479,7 +479,7 @@ private Map<String, Object> checkExecuteType(ProcessInstance processInstance, Ex
         switch (executeType) {
             case PAUSE:
             case STOP:
-                if (executionStatus.isRunning()) {
+                if (executionStatus.canStop()) {

Review Comment:
   PAUSE status check not same as STOP.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org