You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by hn...@apache.org on 2020/04/14 09:42:47 UTC

[myfaces-tobago] branch tobago-4.x updated (4dc3b0f -> bb1638c)

This is an automated email from the ASF dual-hosted git repository.

hnoeth pushed a change to branch tobago-4.x
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git.


    from 4dc3b0f  TOBAGO-1994: TreeListbox is not working correctly * enhance Demo
     new f0da74b  fix checkstyle
     new bb1638c  add a title for date picker button

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../tobago/internal/renderkit/renderer/DateRenderer.java       |  3 +++
 .../org/apache/myfaces/tobago/example/demo/CategoryNode.java   | 10 +++++-----
 .../apache/myfaces/tobago/example/demo/SheetController.java    |  5 +++--
 3 files changed, 11 insertions(+), 7 deletions(-)


[myfaces-tobago] 02/02: add a title for date picker button

Posted by hn...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

hnoeth pushed a commit to branch tobago-4.x
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git

commit bb1638c18460f0fddf52710a27a1de88bbef816f
Author: Henning Nöth <hn...@apache.org>
AuthorDate: Tue Apr 14 11:23:39 2020 +0200

    add a title for date picker button
    
    Issue: TOBAGO-2028
---
 .../myfaces/tobago/internal/renderkit/renderer/DateRenderer.java       | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/DateRenderer.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/DateRenderer.java
index 9a0d832..2246966 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/DateRenderer.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/DateRenderer.java
@@ -19,6 +19,7 @@
 
 package org.apache.myfaces.tobago.internal.renderkit.renderer;
 
+import org.apache.myfaces.tobago.context.TobagoResourceBundle;
 import org.apache.myfaces.tobago.internal.component.AbstractUIDate;
 import org.apache.myfaces.tobago.internal.component.AbstractUIInput;
 import org.apache.myfaces.tobago.internal.context.DateTimeI18n;
@@ -97,6 +98,8 @@ public class DateRenderer extends InRenderer {
         BootstrapClass.BTN_SECONDARY,
         BootstrapDateTimePickerClass.DATEPICKERBUTTON);
     writer.writeAttribute(HtmlAttributes.TYPE, HtmlButtonTypes.BUTTON);
+    writer.writeAttribute(HtmlAttributes.TITLE,
+        TobagoResourceBundle.getString(facesContext, "datePickerTitle"), true);
     writer.writeAttribute(HtmlAttributes.DISABLED, date.isDisabled() || date.isReadonly());
     writer.writeAttribute(HtmlAttributes.TABINDEX, date.getTabIndex());
 


[myfaces-tobago] 01/02: fix checkstyle

Posted by hn...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

hnoeth pushed a commit to branch tobago-4.x
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git

commit f0da74bc2a181b695d3656b31ffd5445a517bf88
Author: Henning Nöth <hn...@apache.org>
AuthorDate: Fri Apr 3 11:39:44 2020 +0200

    fix checkstyle
    
    * SheetController.java (whitespace) NoWhitespaceBefore: ';' is preceded with whitespace.
    * CategoryNode.java (whitespace) OperatorWrap: '+' should be on a new line.
    
    (cherry picked from commit b84ca16851108f7fa307bad56252652192703cc6)
---
 .../org/apache/myfaces/tobago/example/demo/CategoryNode.java   | 10 +++++-----
 .../apache/myfaces/tobago/example/demo/SheetController.java    |  5 +++--
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/CategoryNode.java b/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/CategoryNode.java
index 8637d16..2f6ed78 100644
--- a/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/CategoryNode.java
+++ b/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/CategoryNode.java
@@ -37,10 +37,10 @@ public class CategoryNode {
 
   @Override
   public String toString() {
-    return "CategoryNode{" +
-        "id='" + id + '\'' +
-        ", name='" + name + '\'' +
-        ", children=" + children +
-        '}';
+    return "CategoryNode{"
+        + "id='" + id + '\''
+        + ", name='" + name + '\''
+        + ", children=" + children
+        + '}';
   }
 }
diff --git a/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/SheetController.java b/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/SheetController.java
index da42d44..edcaf88 100644
--- a/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/SheetController.java
+++ b/tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/SheetController.java
@@ -37,6 +37,7 @@ import javax.faces.event.FacesEvent;
 import javax.inject.Inject;
 import javax.inject.Named;
 import java.io.Serializable;
+import java.lang.invoke.MethodHandles;
 import java.util.ArrayList;
 import java.util.Calendar;
 import java.util.Date;
@@ -48,7 +49,7 @@ import java.util.stream.Collectors;
 @Named
 public class SheetController implements Serializable {
 
-  private static final Logger LOG = LoggerFactory.getLogger(SheetController.class);
+  private static final Logger LOG = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
 
   private static final SelectItem[] SHEET_SELECTABLE;
 
@@ -84,7 +85,7 @@ public class SheetController implements Serializable {
 
     int i = 1;
     hugeSolarList = new ArrayList<>();
-    for (;;) {
+    while (true) {
       for (final SolarObject solarObject : solarList) {
         final SolarObject solarObjectClone = new SolarObject(solarObject);
         hugeSolarList.add(solarObjectClone);