You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Cameron Gandevia <cg...@gmail.com> on 2012/11/26 20:04:28 UTC

Review Request: FLUME-1709 - HDFS CompressedDataStream doesn't support serializer parameter

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8227/
-----------------------------------------------------------

Review request for Flume.


Description
-------

When configuring the HDFS sink you can specify a serializer parameter which is hooked
into the append method of the sink. 

The HDFSCompressedDataStream does not respect this parameter and the specified serializer
is not used.


Diffs
-----

  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSCompressedDataStream.java 80341ef 
  flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSCompressedDataStream.java f537732 

Diff: https://reviews.apache.org/r/8227/diff/


Testing
-------


Thanks,

Cameron Gandevia


Re: Review Request: FLUME-1709 - HDFS CompressedDataStream doesn't support serializer parameter

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8227/#review13905
-----------------------------------------------------------

Ship it!


Ship It!

- Brock Noland


On Nov. 26, 2012, 7:04 p.m., Cameron Gandevia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8227/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2012, 7:04 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> When configuring the HDFS sink you can specify a serializer parameter which is hooked
> into the append method of the sink. 
> 
> The HDFSCompressedDataStream does not respect this parameter and the specified serializer
> is not used.
> 
> 
> Diffs
> -----
> 
>   flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSCompressedDataStream.java 80341ef 
>   flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSCompressedDataStream.java f537732 
> 
> Diff: https://reviews.apache.org/r/8227/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cameron Gandevia
> 
>