[GitHub] [maven-integration-testing] cstamas opened a new pull request, #252: [MNG-7737] IT for profiles

["cstamas (via GitHub)" <gi...@apache.org>]

cstamas opened a new pull request, #252:
URL: https://github.com/apache/maven-integration-testing/pull/252

   Just a simple IT that would catch issues like Maven 3.9.0 went out with, where files were wrongly interpolated: MNG-7726
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7737


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on pull request #252: [MNG-7737] IT for profiles

["cstamas (via GitHub)" <gi...@apache.org>]

cstamas commented on PR #252:
URL: https://github.com/apache/maven-integration-testing/pull/252#issuecomment-1465804353

   Verified locally that IT fails w/ 3.9.0 and passes with 3.9.1 (for this the IT range needs change)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on pull request #252: [MNG-7737] IT for profiles

["cstamas (via GitHub)" <gi...@apache.org>]

cstamas commented on PR #252:
URL: https://github.com/apache/maven-integration-testing/pull/252#issuecomment-1465769174

   Oh, but then why is "settings-active-default" active?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on pull request #252: [MNG-7737] IT for profiles

["cstamas (via GitHub)" <gi...@apache.org>]

cstamas commented on PR #252:
URL: https://github.com/apache/maven-integration-testing/pull/252#issuecomment-1465788708

   Seems this is true for POM profiles only: "pom-active-default" gets enabled ONLY when I comment out any other profile in POM. The presence of ANY settings (default or other way activated profile) does not matter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-integration-testing] cstamas merged pull request #252: [MNG-7737] IT for profiles

["cstamas (via GitHub)" <gi...@apache.org>]

cstamas merged PR #252:
URL: https://github.com/apache/maven-integration-testing/pull/252


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on pull request #252: [MNG-7737] IT for profiles

["cstamas (via GitHub)" <gi...@apache.org>]

cstamas commented on PR #252:
URL: https://github.com/apache/maven-integration-testing/pull/252#issuecomment-1465741054

   Q: shouldn't the POM "pom-active-default" become active as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #252: [MNG-7737] IT for profiles

["slawekjaranowski (via GitHub)" <gi...@apache.org>]

slawekjaranowski commented on PR #252:
URL: https://github.com/apache/maven-integration-testing/pull/252#issuecomment-1465760007

   > Q: shouldn't the POM "pom-active-default" become active as well?
   
   As I know - no, activeByDefault - is only activated when no other profiles are active
   
   From docs:
   
   > This profile will automatically be active for all builds unless another profile in the same POM is activated using one of the previously described methods. All profiles that are active by default are automatically deactivated when a profile in the POM is activated on the command line or through its activation config.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-integration-testing] cstamas commented on pull request #252: [MNG-7737] IT for profiles

["cstamas (via GitHub)" <gi...@apache.org>]

cstamas commented on PR #252:
URL: https://github.com/apache/maven-integration-testing/pull/252#issuecomment-1465792428

   Hm, seems this is aligned with documentation. the doco snippet:
   "This profile will automatically be active for all builds unless another profile **in the same POM** is activated using one of the previously described methods. "


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org