You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/20 08:59:14 UTC
[GitHub] [incubator-shardingsphere] mylyed opened a new pull request #4049:
fix Chinese garbled
mylyed opened a new pull request #4049: fix Chinese garbled
URL: https://github.com/apache/incubator-shardingsphere/pull/4049
Fixes #ISSUSE_ID.
the ISSUSE_ID https://gitee.com/Sharding-Sphere/sharding-sphere/issues/I18LGE
but that is Chinese
Changes proposed in this pull request:
- PacketPayload class add charset
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull
request #4049: fix Chinese garbled
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #4049: fix Chinese garbled
URL: https://github.com/apache/incubator-shardingsphere/pull/4049#discussion_r368479472
##########
File path: sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/mysql/payload/MySQLPacketPayload.java
##########
@@ -21,164 +21,158 @@
import io.netty.buffer.ByteBuf;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
import org.apache.shardingsphere.shardingproxy.transport.payload.PacketPayload;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
+
/**
* MySQL payload operation for MySQL packet data types.
*
- * @see <a href="https://dev.mysql.com/doc/internals/en/describing-packets.html">describing packets</a>
- *
* @author zhangliang
* @author zhangyonglun
* @author wangkai
+ * @see <a href="https://dev.mysql.com/doc/internals/en/describing-packets.html">describing packets</a>
Review comment:
Please don't change the irrelevant codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #4049: fix
Chinese garbled
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #4049: fix Chinese garbled
URL: https://github.com/apache/incubator-shardingsphere/pull/4049#issuecomment-576514042
@mylyed To solve the Chinese garbled problem, please refer to an issue before: https://github.com/apache/incubator-shardingsphere/issues/2890
Please add these parameters in jdbcurl of Sharding-Proxy's conf file:
useUnicode=true&characterEncoding=UTF-8&character_set_server=utf8mb4
More information about the character set please refer to: https://dev.mysql.com/doc/connector-j/5.1/en/connector-j-reference-charsets.html.
I think we can resolve the problem this way instead of hard code charset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 edited a comment on issue
#4049: fix Chinese garbled
Posted by GitBox <gi...@apache.org>.
tuohai666 edited a comment on issue #4049: fix Chinese garbled
URL: https://github.com/apache/incubator-shardingsphere/pull/4049#issuecomment-576514042
@mylyed To solve the Chinese garbled problem, please refer to an issue before: https://github.com/apache/incubator-shardingsphere/issues/2890
Please add these parameters in jdbcurl of Sharding-Proxy's conf file:
`useUnicode=true&characterEncoding=UTF-8&character_set_server=utf8mb4`
More information about the character set please refer to: https://dev.mysql.com/doc/connector-j/5.1/en/connector-j-reference-charsets.html.
I think we can resolve the problem this way instead of hard code charset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas removed a comment on issue
#4049: fix Chinese garbled
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on issue #4049: fix Chinese garbled
URL: https://github.com/apache/incubator-shardingsphere/pull/4049#issuecomment-576180869
@mylyed Please create github issue of [sharing-proxy 中文乱码问题](https://gitee.com/Sharding-Sphere/sharding-sphere/issues/I18LGE).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 closed pull request #4049: fix
Chinese garbled
Posted by GitBox <gi...@apache.org>.
tuohai666 closed pull request #4049: fix Chinese garbled
URL: https://github.com/apache/incubator-shardingsphere/pull/4049
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #4049:
fix Chinese garbled
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #4049: fix Chinese garbled
URL: https://github.com/apache/incubator-shardingsphere/pull/4049#issuecomment-576180869
@mylyed Please create github issue of [sharing-proxy 中文乱码问题](https://gitee.com/Sharding-Sphere/sharding-sphere/issues/I18LGE).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services