You are viewing a plain text version of this content. The canonical link for it is here.

Posted to codereview@trafodion.apache.org by zellerh <gi...@git.apache.org> on 2018/06/27 16:12:46 UTC

[GitHub] trafodion pull request #1623: [TRAFODION-3099] Prepare execute fails to hand...

Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1623#discussion_r198544452
  
    --- Diff: core/sql/cli/CliExpExchange.cpp ---
    @@ -1603,7 +1603,7 @@ InputOutputExpr::outputValues(atp_struct *atp,
     	    sourceType = REC_DECIMAL_LSE;
     	  }
     	  
    -	  // 5/18/98: added to handle SJIS encoding charset case.
    +      // 5/18/98: added to handle SJIS encoding charset case.
    --- End diff --
    
    This is a minor comment, but if you plan to make more changes in Trafodion, you should set your editor to display 8 spaces for each tab, so the indentation is correct. It's good that your editor uses spaces and not tabs.


---