You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/04 04:51:28 UTC
[GitHub] [skywalking-satellite] EvanLjp opened a new pull request #46: remove-gen-codes-with-goapi
EvanLjp opened a new pull request #46:
URL: https://github.com/apache/skywalking-satellite/pull/46
remove-gen-codes-with-goapi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #46: remove-gen-codes-with-goapi
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #46:
URL: https://github.com/apache/skywalking-satellite/pull/46#discussion_r645288279
##########
File path: docs/en/setup/plugins/plugin-list.md
##########
@@ -8,9 +8,9 @@
- Fetcher
- Filter
- Forwarder
+ - [meter-grpc-forwarder](./forwarder_meter-grpc-forwarder.md)
- [nativelog-grpc-forwarder](./forwarder_nativelog-grpc-forwarder.md)
- [nativelog-kafka-forwarder](./forwarder_nativelog-kafka-forwarder.md)
- - [meter-grpc-forwarder](./forwarder_meter-grpc-forwarder.md)
Review comment:
this is auto-generated, I would check the reason
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #46: remove-gen-codes-with-goapi
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #46:
URL: https://github.com/apache/skywalking-satellite/pull/46#issuecomment-854362585
Have we removed submodule permanently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #46: remove-gen-codes-with-goapi
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #46:
URL: https://github.com/apache/skywalking-satellite/pull/46#discussion_r645287899
##########
File path: docs/en/setup/plugins/plugin-list.md
##########
@@ -8,9 +8,9 @@
- Fetcher
- Filter
- Forwarder
+ - [meter-grpc-forwarder](./forwarder_meter-grpc-forwarder.md)
- [nativelog-grpc-forwarder](./forwarder_nativelog-grpc-forwarder.md)
- [nativelog-kafka-forwarder](./forwarder_nativelog-kafka-forwarder.md)
- - [meter-grpc-forwarder](./forwarder_meter-grpc-forwarder.md)
Review comment:
Why remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #46: remove-gen-codes-with-goapi
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #46:
URL: https://github.com/apache/skywalking-satellite/pull/46#issuecomment-854362585
Have we removed submodule permanently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng merged pull request #46: remove-gen-codes-with-goapi
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #46:
URL: https://github.com/apache/skywalking-satellite/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #46: remove-gen-codes-with-goapi
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #46:
URL: https://github.com/apache/skywalking-satellite/pull/46#discussion_r645287899
##########
File path: docs/en/setup/plugins/plugin-list.md
##########
@@ -8,9 +8,9 @@
- Fetcher
- Filter
- Forwarder
+ - [meter-grpc-forwarder](./forwarder_meter-grpc-forwarder.md)
- [nativelog-grpc-forwarder](./forwarder_nativelog-grpc-forwarder.md)
- [nativelog-kafka-forwarder](./forwarder_nativelog-kafka-forwarder.md)
- - [meter-grpc-forwarder](./forwarder_meter-grpc-forwarder.md)
Review comment:
Why remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng merged pull request #46: remove-gen-codes-with-goapi
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #46:
URL: https://github.com/apache/skywalking-satellite/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #46: remove-gen-codes-with-goapi
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #46:
URL: https://github.com/apache/skywalking-satellite/pull/46#discussion_r645288279
##########
File path: docs/en/setup/plugins/plugin-list.md
##########
@@ -8,9 +8,9 @@
- Fetcher
- Filter
- Forwarder
+ - [meter-grpc-forwarder](./forwarder_meter-grpc-forwarder.md)
- [nativelog-grpc-forwarder](./forwarder_nativelog-grpc-forwarder.md)
- [nativelog-kafka-forwarder](./forwarder_nativelog-kafka-forwarder.md)
- - [meter-grpc-forwarder](./forwarder_meter-grpc-forwarder.md)
Review comment:
this is auto-generated, I would check the reason
##########
File path: docs/en/setup/plugins/plugin-list.md
##########
@@ -8,9 +8,9 @@
- Fetcher
- Filter
- Forwarder
+ - [meter-grpc-forwarder](./forwarder_meter-grpc-forwarder.md)
- [nativelog-grpc-forwarder](./forwarder_nativelog-grpc-forwarder.md)
- [nativelog-kafka-forwarder](./forwarder_nativelog-kafka-forwarder.md)
- - [meter-grpc-forwarder](./forwarder_meter-grpc-forwarder.md)
Review comment:
only sequence change, order by letter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #46: remove-gen-codes-with-goapi
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #46:
URL: https://github.com/apache/skywalking-satellite/pull/46#discussion_r645294334
##########
File path: docs/en/setup/plugins/plugin-list.md
##########
@@ -8,9 +8,9 @@
- Fetcher
- Filter
- Forwarder
+ - [meter-grpc-forwarder](./forwarder_meter-grpc-forwarder.md)
- [nativelog-grpc-forwarder](./forwarder_nativelog-grpc-forwarder.md)
- [nativelog-kafka-forwarder](./forwarder_nativelog-kafka-forwarder.md)
- - [meter-grpc-forwarder](./forwarder_meter-grpc-forwarder.md)
Review comment:
only sequence change, order by letter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org