[jira] [Commented] (ROCKETMQ-210) Logic Error in ConsumeMessageOrderlyService#checkReconsumeTimes

["Jaskey Lam (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040325#comment-16040325 ] 

Jaskey Lam commented on ROCKETMQ-210:
-------------------------------------

No I don't think it's buggy.

This method is to check if it should be suspend.

If it is not reconsumed for enough times, then suspend it and does not need to send back.

It should send back only when resume too many times but fail.

But indeed it is a little confusing, I think we should add comments to this method

Please review 
[~lizhanhui][~Yukon][~zander][~vongosling]

> Logic Error in ConsumeMessageOrderlyService#checkReconsumeTimes
> ---------------------------------------------------------------
>
>                 Key: ROCKETMQ-210
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-210
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-client
>    Affects Versions: 4.0.0-incubating, 4.1.0-incubating, 4.2.0-incubating, 4.3.0-incubating
>         Environment: All Environments
>            Reporter: binzhaomobile
>            Assignee: Xiaorui Wang
>            Priority: Minor
>
> According to the retry logic, the code "if (msg.getReconsumeTimes() >= getMaxReconsumeTimes())" should be changed to "if (msg.getReconsumeTimes() < getMaxReconsumeTimes())"



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)