You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2016/10/10 07:55:05 UTC
[GitHub] cordova-cli pull request #262: CB-11976 - Add deprecated node version warnin...
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-cli/pull/262
CB-11976 - Add deprecated node version warning for 0.x
### Platforms affected
All.
### What does this PR do?
Before running each command, it will check if the node version is 0.x. If it is, it prints out a warning.
### What testing has been done on this change?
Tested locally.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-cli CB-11976
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-cli/pull/262.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #262
----
commit 0814fe06c7851103ea321873cd160b47481596cd
Author: Shazron Abdullah <sh...@apache.org>
Date: 2016-10-10T07:53:58Z
CB-11976 - Add deprecated node version warning for 0.x
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli issue #262: CB-11976 - Add deprecated node version warning for 0...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-cli/pull/262
@stevengill yes, it should be `>=4.0.0` and remove the `engineStrict` key as well. I'll add it soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request #262: CB-11976 - Add deprecated node version warnin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/262
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request #262: CB-11976 - Add deprecated node version warnin...
Posted by shazron <gi...@git.apache.org>.
GitHub user shazron reopened a pull request:
https://github.com/apache/cordova-cli/pull/262
CB-11976 - Add deprecated node version warning for 0.x
### Platforms affected
All.
### What does this PR do?
Before running each command, it will check if the node version is 0.x. If it is, it prints out a warning.
### What testing has been done on this change?
Tested locally.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-cli CB-11976
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-cli/pull/262.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #262
----
commit 0814fe06c7851103ea321873cd160b47481596cd
Author: Shazron Abdullah <sh...@apache.org>
Date: 2016-10-10T07:53:58Z
CB-11976 - Add deprecated node version warning for 0.x
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli pull request #262: CB-11976 - Add deprecated node version warnin...
Posted by shazron <gi...@git.apache.org>.
Github user shazron closed the pull request at:
https://github.com/apache/cordova-cli/pull/262
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-cli issue #262: CB-11976 - Add deprecated node version warning for 0...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-cli/pull/262
LGTM
Should we update https://github.com/apache/cordova-cli/blob/master/package.json#L8 in this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org