You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/23 08:55:22 UTC
[GitHub] [camel-kafka-connector-examples] apupier opened a new issue #292: Fhir Source example is using 2 properties nto part of the catalog
apupier opened a new issue #292:
URL: https://github.com/apache/camel-kafka-connector-examples/issues/292
https://camel.apache.org/components/latest/dataformats/fhirJson-dataformat.html
https://github.com/apache/camel-kafka-connector-examples/blob/198d73de6ea9ad5f51bf6f20597a8d012fc9fe1f/fhir/source/CamelFhirSourceConnector.properties#L26
Not found somethign related, should be removed from example? or it is missing from the catalog?
https://camel.apache.org/camel-kafka-connector/latest/connectors/camel-fhir-kafka-source-connector.html
https://github.com/apache/camel-kafka-connector-examples/blob/198d73de6ea9ad5f51bf6f20597a8d012fc9fe1f/fhir/source/CamelFhirSourceConnector.properties#L36
Should it be `camel.source.endpoint.serverUrl`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector-examples] apupier commented on issue #292: Fhir Source example is using 2 properties not part of the catalog
Posted by GitBox <gi...@apache.org>.
apupier commented on issue #292:
URL: https://github.com/apache/camel-kafka-connector-examples/issues/292#issuecomment-784018500
updated my first comment, I pointed to the wrong lien for the first reported issue. it is `camel.dataformat.fhirJson.enabled` which is missing, not `camel.source.marshal` as i wrongly reported
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector-examples] oscerd commented on issue #292: Fhir Source example is using 2 properties not part of the catalog
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #292:
URL: https://github.com/apache/camel-kafka-connector-examples/issues/292#issuecomment-784018926
That's a specific property of the dataformat, so, no, it's not part of the catalog. It's like setting a field value on a POJO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector-examples] apupier commented on issue #292: Fhir Source example is using 2 properties not part of the catalog
Posted by GitBox <gi...@apache.org>.
apupier commented on issue #292:
URL: https://github.com/apache/camel-kafka-connector-examples/issues/292#issuecomment-784023104
> That's a specific property of the dataformat, so, no, it's not part of the catalog. It's like setting a field value on a POJO.
ok, then it is a bug in org.apache.camel.catalog.CamelCatalog.validateConfigurationProperty(String) method which is reporting a false positive
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector-examples] apupier commented on issue #292: Fhir Source example is using 2 properties not part of the catalog
Posted by GitBox <gi...@apache.org>.
apupier commented on issue #292:
URL: https://github.com/apache/camel-kafka-connector-examples/issues/292#issuecomment-784095340
> > camel.source.marshal is a dataformat specification, so it's not part of the catalog ootb.
> > The other yes, it should be camel.source.endpoint.serverUrl
> > @luigidemasi is that a leftover? Thanks
>
> No, it's not. It's the first parameter of the [searchByUrl](https://camel.apache.org/components/latest/fhir-component.html#_api_search) method.
>
> ```java-properties
> camel.source.endpoint.serverUrl=http://hapi.fhir.org/baseR4
> camel.source.endpoint.url=/Patient
> ```
ok sounds like the Camel Catalog is reporting false positive for API based components in Properties files then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector-examples] oscerd commented on issue #292: Fhir Source example is using 2 properties not part of the catalog
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #292:
URL: https://github.com/apache/camel-kafka-connector-examples/issues/292#issuecomment-784023471
It's not part of the ckc catalog.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector-examples] apupier closed issue #292: Fhir Source example is using 2 properties not part of the catalog
Posted by GitBox <gi...@apache.org>.
apupier closed issue #292:
URL: https://github.com/apache/camel-kafka-connector-examples/issues/292
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector-examples] apupier edited a comment on issue #292: Fhir Source example is using 2 properties not part of the catalog
Posted by GitBox <gi...@apache.org>.
apupier edited a comment on issue #292:
URL: https://github.com/apache/camel-kafka-connector-examples/issues/292#issuecomment-784095340
> > camel.source.marshal is a dataformat specification, so it's not part of the catalog ootb.
> > The other yes, it should be camel.source.endpoint.serverUrl
> > @luigidemasi is that a leftover? Thanks
>
> No, it's not. It's the first parameter of the [searchByUrl](https://camel.apache.org/components/latest/fhir-component.html#_api_search) method.
>
> ```java-properties
> camel.source.endpoint.serverUrl=http://hapi.fhir.org/baseR4
> camel.source.endpoint.url=/Patient
> ```
ok sounds like the Camel Catalog is reporting false positive for API based components in Properties files then.
reported https://issues.apache.org/jira/browse/CAMEL-16247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector-examples] luigidemasi commented on issue #292: Fhir Source example is using 2 properties not part of the catalog
Posted by GitBox <gi...@apache.org>.
luigidemasi commented on issue #292:
URL: https://github.com/apache/camel-kafka-connector-examples/issues/292#issuecomment-784070372
> camel.source.marshal is a dataformat specification, so it's not part of the catalog ootb.
>
> The other yes, it should be camel.source.endpoint.serverUrl
>
> @luigidemasi is that a leftover? Thanks
No, it's not. It's the first parameter of the [searchByUrl](https://camel.apache.org/components/latest/fhir-component.html#_api_search) method.
```java-properties
camel.source.endpoint.serverUrl=http://hapi.fhir.org/baseR4
camel.source.endpoint.url=/Patient
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector-examples] apupier commented on issue #292: Fhir Source example is using 2 properties not part of the catalog
Posted by GitBox <gi...@apache.org>.
apupier commented on issue #292:
URL: https://github.com/apache/camel-kafka-connector-examples/issues/292#issuecomment-784101152
> > That's a specific property of the dataformat, so, no, it's not part of the catalog. It's like setting a field value on a POJO.
>
> ok, then it is a bug in org.apache.camel.catalog.CamelCatalog.validateConfigurationProperty(String) method which is reporting a false positive
reported https://issues.apache.org/jira/browse/CAMEL-16248
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector-examples] oscerd commented on issue #292: Fhir Source example is using 2 properties not part of the catalog
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #292:
URL: https://github.com/apache/camel-kafka-connector-examples/issues/292#issuecomment-784016073
camel.source.marshal is a dataformat specification, so it's not part of the catalog ootb.
The other yes, it should be camel.source.endpoint.serverUrl
@luigidemasi is that a leftover? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org