[GitHub] [inlong] EMsnap commented on a diff in pull request #6585: [INLONG-6584][Sort] Add read phase metric and table level metric for MySQL

[GitBox <gi...@apache.org>]

EMsnap commented on code in PR #6585:
URL: https://github.com/apache/inlong/pull/6585#discussion_r1031096745


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -73,11 +79,48 @@ public final class Constants {
      * Node id used in inlong metric
      */
     public static final String NODE_ID = "nodeId";
+    /**
+     * Database Name used in inlong metric
+     */
+    public static final String DATABASE_NAME = "database";
+    /**
+     * Table Name used in inlong metric
+     */
+    public static final String TABLE_NAME = "table";
+    /**
+     * Schema Name used in inlong metric
+     */
+    public static final String SCHEMA_NAME = "schema";
+    /**
+     * Topic Name used in inlong metric
+     */
+    public static final String TOPIC_NAME = "topic";
+
     /**
      * It is used for inlong.metric
      */
     public static final String DELIMITER = "&";
 
+    /**
+     * It is used for metric data to build schema identify
+     */
+    public static final String SEMICOLON = ".";
+
+    /**
+     * It is used for metric data to spilt schema identify
+     */
+    public static final String SPILT_SEMICOLON = "\\.";
+
+    /**
+     * This indicator represents the snapshot phase during the read phase
+     */
+    public static final Long SNAPSHOT_PHASE = 1L;

Review Comment:
   suggest use enum for snapshot or incremental 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org