You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/03/03 09:06:52 UTC
[GitHub] [couchdb] dottorblaster opened a new pull request #3398: Update Makefile stripping remaining direct make refs
dottorblaster opened a new pull request #3398:
URL: https://github.com/apache/couchdb/pull/3398
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
Quoting from https://github.com/apache/couchdb-erlfdb/pull/15:
> There are also bare references to `make` in couchdb's `Makefile` that need to be replaced with `@$(MAKE)`.
I'm precisely addressing this.
## Testing recommendations
If the CI is happy, I assume we can be happy too.
## Related Issues or Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [ ] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] dottorblaster merged pull request #3398: Update Makefile stripping remaining direct make refs
Posted by GitBox <gi...@apache.org>.
dottorblaster merged pull request #3398:
URL: https://github.com/apache/couchdb/pull/3398
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] wohali commented on pull request #3398: Update Makefile stripping remaining direct make refs
Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #3398:
URL: https://github.com/apache/couchdb/pull/3398#issuecomment-789794714
Perfect, thanks. Merge away!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org