You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@age.apache.org by "markgomer (via GitHub)" <gi...@apache.org> on 2023/09/28 00:43:12 UTC
[GitHub] [age-website] markgomer opened a new pull request, #164: Fixed some information and typos on agload.md
markgomer opened a new pull request, #164:
URL: https://github.com/apache/age-website/pull/164
Also changed nomination of "nodes" to "vertices" or "vertexes" in order to keep consistency and avoid confusion to the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed some information and typos on agload.md [age-website]
Posted by "dehowef (via GitHub)" <gi...@apache.org>.
dehowef merged PR #164:
URL: https://github.com/apache/age-website/pull/164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age-website] markgomer commented on a diff in pull request #164: Fixed some information and typos on agload.md
Posted by "markgomer (via GitHub)" <gi...@apache.org>.
markgomer commented on code in PR #164:
URL: https://github.com/apache/age-website/pull/164#discussion_r1340344408
##########
docs/intro/agload.md:
##########
@@ -32,7 +32,7 @@ load_labels_from_file('<graph name>',
false)
```
-Function `load_edges_from_file` can be used to load properties from the CSV file. Please see the file structure in the following.
+Function `load_edges_from_file` can be used to load edges from the CSV file. Please see the file structure in the following.
Review Comment:
Changed this to conform with the prior sentence, which said "(...) to load ***vertices*** from the CSV files. "
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age-website] markgomer commented on pull request #164: Fixed some information and typos on agload.md
Posted by "markgomer (via GitHub)" <gi...@apache.org>.
markgomer commented on PR #164:
URL: https://github.com/apache/age-website/pull/164#issuecomment-1736444670
Hello @dehowef, I agree the semicolons are not important at all, but there are other parts of the PR that I consider important, like the default paths to the csv files when calling the function to load vertexes and edges, and the phrase by the end of the document "Create label `City` and load vertices from csv file. *** Note this CSV file has id field ***", which is wrong.
I can remove the aesthetic parts of the commit and leave just these ones I mentioned, if you would reconsider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age-website] markgomer closed pull request #164: Fixed some information and typos on agload.md
Posted by "markgomer (via GitHub)" <gi...@apache.org>.
markgomer closed pull request #164: Fixed some information and typos on agload.md
URL: https://github.com/apache/age-website/pull/164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age-website] dehowef closed pull request #164: Fixed some information and typos on agload.md
Posted by "dehowef (via GitHub)" <gi...@apache.org>.
dehowef closed pull request #164: Fixed some information and typos on agload.md
URL: https://github.com/apache/age-website/pull/164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age-website] dehowef commented on pull request #164: Fixed some information and typos on agload.md
Posted by "dehowef (via GitHub)" <gi...@apache.org>.
dehowef commented on PR #164:
URL: https://github.com/apache/age-website/pull/164#issuecomment-1735670661
We don't need semicolons after every list member
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age-website] dehowef commented on pull request #164: Fixed some information and typos on agload.md
Posted by "dehowef (via GitHub)" <gi...@apache.org>.
dehowef commented on PR #164:
URL: https://github.com/apache/age-website/pull/164#issuecomment-1738287479
@markgomer Valid, I kind of just went through and blazed through a bunch of PRs to remove the clutter. I also don't think that it's necessary to change the term node to vertice-- it just seems a bit ... redundant to do so to me? They already mean the same thing. I'll reopen this and you can go ahead and redo them. I might just go in and proofread all of the documentation myself at some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org