You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Satinder Singh <hi...@gmail.com> on 2016/04/04 13:20:39 UTC
QuerySenderListener : newSearcher
Hi,
I am working on handling OOM condition in my Solr setup. On
browsing solr 5.3.0 code, I came across file
"solr/core/src/java/org/apache/solr/core/QuerySenderListener.java".
Method newSearcher() in this file calls request hanlders:
getCore().execute(getCore().getRequestHandler(req.getParams().get(CommonParams.QT)),
req, rsp);
I see that this method catches all exceptions and do nothing. I think
this method gets called when I query solr and in case of OOM in a
request handler it will consume OOM exception and thus oom script
given in command line will not get called.
Is my understanding of this code is correct?
How about we throw OOM exception in this part?
Regards,
satti
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: QuerySenderListener : newSearcher
Posted by David Smiley <da...@gmail.com>.
Sounds reasonable to me; file an issue.
On Mon, Apr 4, 2016 at 7:20 AM Satinder Singh <hi...@gmail.com> wrote:
> Hi,
> I am working on handling OOM condition in my Solr setup. On
> browsing solr 5.3.0 code, I came across file
> "solr/core/src/java/org/apache/solr/core/QuerySenderListener.java".
> Method newSearcher() in this file calls request hanlders:
>
> getCore().execute(getCore().getRequestHandler(req.getParams().get(CommonParams.QT)),
> req, rsp);
>
> I see that this method catches all exceptions and do nothing. I think
> this method gets called when I query solr and in case of OOM in a
> request handler it will consume OOM exception and thus oom script
> given in command line will not get called.
>
> Is my understanding of this code is correct?
>
> How about we throw OOM exception in this part?
>
>
> Regards,
> satti
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
> --
Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
http://www.solrenterprisesearchserver.com