You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/07/30 15:08:52 UTC

[GitHub] [trafficcontrol] rob05c opened a new pull request #4923: Add ORT atstccfg log appending and logrotate

rob05c opened a new pull request #4923:
URL: https://github.com/apache/trafficcontrol/pull/4923


   Fixes atstccfg to append its log rather than overwrite. 
   
   It also adds logrotate, which is necessary for a continuously-appending log, and moves the log to `/var/log` - `/tmp` was never an appropriate place, and certainly not for a persistent log.
   
   Labeling 'bug' because the overwrite was a bug, and the other change are ancillary to the bug fix.
   
   ## What does this PR (Pull Request) do?
   Fixes atstccfg to append its log rather than overwrite. 
   
   I've manually tested, verified install puts logrotate in the right place, ORT logs atstccfg log to /var/log/ort/atstccfg.log, multiple runs append.
   
   No tests, ORT doesn't have an integration test framework yet.
   Includes docs.
   Includes changelog.
   
   - [x] This PR is not related to any other Issue
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops ORT
   
   ## What is the best way to verify this PR?
   Run ORT, verify atstccfg log is output at /var/log/atstccfg.log. Run again, verify log is appended and not overwritten.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master 
   - 4.0.0
   - 4.0.1
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mitchell852 merged pull request #4923: Add ORT atstccfg log appending and logrotate

Posted by GitBox <gi...@apache.org>.
mitchell852 merged pull request #4923:
URL: https://github.com/apache/trafficcontrol/pull/4923


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org