You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/22 15:02:47 UTC
[GitHub] [spark] maropu commented on a change in pull request #32264: [SPARK-35159][SQL][DOCS] Extract hive format doc
maropu commented on a change in pull request #32264:
URL: https://github.com/apache/spark/pull/32264#discussion_r618475129
##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,73 @@
+---
+layout: global
+title: Data Retrieval
Review comment:
`Data Retrieval` -> `Hive Row Format`?
##########
File path: docs/sql-ref-syntax-qry-select-transform.md
##########
@@ -49,45 +41,9 @@ row_format:
Specifies a combination of one or more values, operators and SQL functions that results in a value.
-* **row_format**
-
- Otherwise, uses the `DELIMITED` clause to specify the native SerDe and state the delimiter, escape character, null character and so on.
-
-* **SERDE**
-
- Specifies a custom SerDe for one table.
-
-* **serde_class**
-
- Specifies a fully-qualified class name of a custom SerDe.
-
-* **DELIMITED**
-
- The `DELIMITED` clause can be used to specify the native SerDe and state the delimiter, escape character, null character and so on.
-
-* **FIELDS TERMINATED BY**
-
- Used to define a column separator.
-
-* **COLLECTION ITEMS TERMINATED BY**
-
- Used to define a collection item separator.
-
-* **MAP KEYS TERMINATED BY**
-
- Used to define a map key separator.
-
-* **LINES TERMINATED BY**
-
- Used to define a row separator.
-
-* **NULL DEFINED AS**
-
- Used to define the specific value for NULL.
-
-* **ESCAPED BY**
+* **row_format**
- Used for escape mechanism.
+ All descriptions about syntax in `row_format` can refer to [HIVE FORMAT](sql-ref-syntax-hive-format.html)
Review comment:
ditto
##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,73 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,
Review comment:
"`CREATE TABLE` clause and `TRANSFORM` clause" => "`CREATE TABLE` and `TRANSFORM` clauses"?
##########
File path: docs/sql-ref-syntax-ddl-create-table-hiveformat.md
##########
@@ -82,50 +74,10 @@ as any order. For example, you can write COMMENT table_comment after TBLPROPERTI
* **INTO num_buckets BUCKETS**
Specifies buckets numbers, which is used in `CLUSTERED BY` clause.
-
-* **row_format**
-
- Use the `SERDE` clause to specify a custom SerDe for one table. Otherwise, use the `DELIMITED` clause to use the native SerDe and specify the delimiter, escape character, null character and so on.
-
-* **SERDE**
-
- Specifies a custom SerDe for one table.
-
-* **serde_class**
-
- Specifies a fully-qualified class name of a custom SerDe.
-
-* **SERDEPROPERTIES**
-
- A list of key-value pairs that is used to tag the SerDe definition.
-
-* **DELIMITED**
- The `DELIMITED` clause can be used to specify the native SerDe and state the delimiter, escape character, null character and so on.
-
-* **FIELDS TERMINATED BY**
-
- Used to define a column separator.
-
-* **COLLECTION ITEMS TERMINATED BY**
-
- Used to define a collection item separator.
-
-* **MAP KEYS TERMINATED BY**
-
- Used to define a map key separator.
-
-* **LINES TERMINATED BY**
-
- Used to define a row separator.
-
-* **NULL DEFINED AS**
-
- Used to define the specific value for NULL.
-
-* **ESCAPED BY**
+* **row_format**
- Used for escape mechanism.
+ All descriptions about syntax in `row_format` can refer to [HIVE FORMAT](sql-ref-syntax-hive-format.html)
Review comment:
How about `Specifies the row format for input and output. See [HIVE ROW FORMAT](...) for more syntax details.`?
##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,73 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,
Review comment:
`Hive format` -> `a Hive row format`
##########
File path: docs/sql-ref-syntax-hive-format.md
##########
@@ -0,0 +1,73 @@
+---
+layout: global
+title: Data Retrieval
+displayTitle: Data Retrieval
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+--
+
+### Description
+
+Spark supports Hive format in `CREATE TABLE` clause and `TRANSFORM` clause,
Review comment:
```
There are two ways to define a row format in `row_format` of `CREATE TABLE` and `TRANSFORM` clauses.
1. `SERDE` clause to specify a custom SerDe class.
2. `DELIMITED` clause to specify a delimiter, an escape character, a null character, and so on for the native SerDe.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org